From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A53C433ED for ; Wed, 28 Apr 2021 06:04:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5452861426 for ; Wed, 28 Apr 2021 06:04:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234587AbhD1GFC (ORCPT ); Wed, 28 Apr 2021 02:05:02 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:38931 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236003AbhD1GFB (ORCPT ); Wed, 28 Apr 2021 02:05:01 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1619589857; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=bx8J2U/YCTnNf7agVEpn/+hCnhROmQM6fBoT0Bn6L04=; b=hbytPyz2LQZZoaK/qete11fJXZGykPA6ZdtWdh5zrk8/Sw+BAHiN1LIVB/qpdFqVthQdObAN fpxmUca3nc37cFaPv22p1NB/5h4nFetDp/5U9aX4fjOIKjpr4j7ZeTk7lHqrKombfPTawc0N sgWXGNuV7HEVnTILY70IbqQ9y44= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 6088fae02cc44d3aeae56822 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 28 Apr 2021 06:04:16 GMT Sender: skakit=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C5B95C43460; Wed, 28 Apr 2021 06:04:16 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: skakit) by smtp.codeaurora.org (Postfix) with ESMTPSA id 79399C4338A; Wed, 28 Apr 2021 06:04:16 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 28 Apr 2021 11:34:16 +0530 From: skakit@codeaurora.org To: Matthias Kaehlcke Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kgunda@codeaurora.org Subject: Re: [RESEND PATCH V3 5/5] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280 In-Reply-To: References: <1618398783-7834-1-git-send-email-skakit@codeaurora.org> <1618398783-7834-6-git-send-email-skakit@codeaurora.org> Message-ID: <62b11bc7706d4d9e335f9f1cc09c98bc@codeaurora.org> X-Sender: skakit@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-04-20 23:32, Matthias Kaehlcke wrote: > On Wed, Apr 14, 2021 at 04:43:03PM +0530, satya priya wrote: > >> Subject: arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280 > > Please make sure to distinguish between the SoC (sc7280) and the > board (sc7280-idp), this patch primarily adds stuff to the board not > the SoC, this should be clear from the subject. > Sure, will mention sc7280-idp in the subject. >> Include pm7325, pm8350c, pmk8350 and pmr735a DT files. > > How about something like 'The sc7280-idp has four PMICs, include their > .dtsi files'? > Okay. >> Add channel nodes for pmk8350_vadc. > > It's not super important, but I don't like it when things like this get > sneaked in with a commit message saying 'Include PMIC DT files for > sc7280'. I would suggest a separate patch. And please mention that > the channels are for the on die temperatures of the PMICs. > Okay, will make a separate patch for adding channel nodes. >> Also, add the thermal_zones node in dtsi. > > This is not the right patch to add it. This patch is about the > sc7280-board > and doesn't do anything (directly) with thermal zones. However other > patches further down in the stack of in this series require the > 'thermal-zones' to exist, hence the node should exist before these > patches > reference it. A dedicated patch adding the node seems like the best > option > to me. Okay, I will add a separate patch for adding thermal-zones node and place it in the beginning of the series. Thanks, Satya Priya