linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Melody Olvera <quic_molvera@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: qcom: qdu1000: Add IPCC, MPSS, AOSS nodes
Date: Tue, 14 Feb 2023 13:47:33 -0800	[thread overview]
Message-ID: <63f41994-6408-1fe5-2d75-363dc6933eed@quicinc.com> (raw)
In-Reply-To: <7336923b-e322-1211-0c1d-7ad70c7bfef7@linaro.org>



On 2/14/2023 1:47 AM, Krzysztof Kozlowski wrote:
> On 13/02/2023 20:01, Melody Olvera wrote:
>> Add nodes for IPCC, MPSS, and AOSS drivers. Also update
>> the scm node to include its interconnect.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>
>>  
>> +		aoss_qmp: power-controller@c300000 {
>> +			compatible = "qcom,qdu1000-aoss-qmp", "qcom,aoss-qmp";
>> +			reg = <0x0 0xc300000 0x0 0x400>;
>> +			interrupts-extended = <&ipcc IPCC_CLIENT_AOP
>> +						     IPCC_MPROC_SIGNAL_GLINK_QMP
>> +						     IRQ_TYPE_EDGE_RISING>;
>> +			mboxes = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP>;
>> +
>> +			#clock-cells = <0>;
>> +			#power-domain-cells = <1>;
> This does not look right. Which part of aoss-qmp registers power domains?

You're right; I didn't realize part of the driver that registered this had been removed. Will drop
that line.

Thanks,
Melody
>
> Best regards,
> Krzysztof
>


  reply	other threads:[~2023-02-14 21:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 19:01 [PATCH 0/3] arm64: dts: qcom: Add mpss support to QDU1000/QRU1000 SoCs Melody Olvera
2023-02-13 19:01 ` [PATCH 1/3] arm64: dts: qcom: qdu1000: Add IPCC, MPSS, AOSS nodes Melody Olvera
2023-02-14  9:47   ` Krzysztof Kozlowski
2023-02-14 21:47     ` Melody Olvera [this message]
2023-02-13 19:01 ` [PATCH 2/3] arm64: dts: qcom: qdu1000-idp: Enable mpss Melody Olvera
2023-02-14  9:59   ` Dmitry Baryshkov
2023-02-13 19:01 ` [PATCH 3/3] arm64: dts: qcom: qru1000-idp: " Melody Olvera
2023-02-14  9:59   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63f41994-6408-1fe5-2d75-363dc6933eed@quicinc.com \
    --to=quic_molvera@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).