From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
agross@kernel.org, andersson@kernel.org, amitk@kernel.org,
thara.gopinath@gmail.com, rafael@kernel.org,
daniel.lezcano@linaro.org, rui.zhang@intel.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Praveenkumar I <quic_ipkumar@quicinc.com>
Subject: Re: [PATCH v5 2/3] arm64: dts: qcom: ipq9574: add tsens node
Date: Tue, 6 Jun 2023 15:15:56 +0200 [thread overview]
Message-ID: <6548a1d5-9635-7d97-7a0a-0114c463b152@linaro.org> (raw)
In-Reply-To: <dcb682766d8e01f8f4eed7f26fcbfba1b4091137.1685703605.git.quic_varada@quicinc.com>
On 2.06.2023 13:03, Varadarajan Narayanan wrote:
> IPQ9574 has a tsens v2.3.1 peripheral which monitors temperatures
> around the various subsystems on the die.
>
> Co-developed-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> [v5]:
> Incorporate review comments
"fix bug" is too vague..
>
> [v2]:
> Add "qcom,ipq8074-tsens" as fallback compatible
> ---
> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 0baeb10..cda3fd4 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -206,6 +206,16 @@
> #size-cells = <1>;
> };
>
> + tsens: thermal-sensor@4a9000 {
> + compatible = "qcom,ipq9574-tsens", "qcom,ipq8074-tsens";
> + reg = <0x004a9000 0x1000>, /* TM */
> + <0x004a8000 0x1000>; /* SROT */
The comments are unnecessary, we've been copypasting them from SoC to SoC
but it's time we stop.
With that:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> + interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "combined";
> + #qcom,sensors = <16>;
> + #thermal-sensor-cells = <1>;
> + };
> +
> tlmm: pinctrl@1000000 {
> compatible = "qcom,ipq9574-tlmm";
> reg = <0x01000000 0x300000>;
next prev parent reply other threads:[~2023-06-06 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 11:03 [PATCH v5 0/3] Enable IPQ9574 TSENS support Varadarajan Narayanan
2023-06-02 11:03 ` [PATCH v5 1/3] dt-bindings: thermal: tsens: Add ipq9574 compatible Varadarajan Narayanan
2023-06-03 10:25 ` Krzysztof Kozlowski
2023-06-02 11:03 ` [PATCH v5 2/3] arm64: dts: qcom: ipq9574: add tsens node Varadarajan Narayanan
2023-06-06 13:15 ` Konrad Dybcio [this message]
2023-06-02 11:03 ` [PATCH v5 3/3] arm64: dts: qcom: ipq9574: add thermal zone nodes Varadarajan Narayanan
2023-06-06 10:33 ` [PATCH v5 0/3] Enable IPQ9574 TSENS support Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6548a1d5-9635-7d97-7a0a-0114c463b152@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).