From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7EC1C282DD for ; Mon, 10 Jun 2019 11:47:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B723B20859 for ; Mon, 10 Jun 2019 11:47:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="F/dI8LIP"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="HfPMGgqi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389555AbfFJLrR (ORCPT ); Mon, 10 Jun 2019 07:47:17 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58334 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389517AbfFJLrQ (ORCPT ); Mon, 10 Jun 2019 07:47:16 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 410E86019D; Mon, 10 Jun 2019 11:47:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560167235; bh=4XDPRPKTvdPgn7fWEq49BU4VLSuWjWWn+L9RjxS4Tr4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=F/dI8LIPkR1zdhwduM0KxCFEvB4R6ylEK+IMajctYv7slDZptEe5nU0lculLlTMZQ Lg3tAfE9I7+Gk0OZiXfCU/WQagxn5xLuPfeRxffBFonuOox3TlDtWo7tIZ74Nrn7J2 AfjbGx6A3s0n0TQSFxBiSl2XXuIocxM3BIFaRuaw= Received: from [10.201.2.161] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sricharan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5252560209; Mon, 10 Jun 2019 11:47:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560167234; bh=4XDPRPKTvdPgn7fWEq49BU4VLSuWjWWn+L9RjxS4Tr4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=HfPMGgqiNfj2YJKVBh25nt5zqx5ec/y9KHWxNKJvfhFGKk9l84OrWrmGkfLDOvf4P ZnJ65lj203tCDVTIr73AOpExlWf94+9F/aA6lBqjitMDM8gEWDEAnvkIM5H/H/FKAm 6iSahlOERBQTYbRiirWGS29X26w5VJh3hNTma+R8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5252560209 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sricharan@codeaurora.org Subject: Re: [PATCH 4/6] clk: qcom: Add ipq6018 Global Clock Controller support To: Bjorn Andersson Cc: robh+dt@kernel.org, Stephen Boyd , linus.walleij@linaro.org, agross@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1559754961-26783-1-git-send-email-sricharan@codeaurora.org> <1559754961-26783-5-git-send-email-sricharan@codeaurora.org> <20190608033229.GE24059@builder> From: Sricharan R Message-ID: <6583f576-acf4-a71b-d691-bce548e2c008@codeaurora.org> Date: Mon, 10 Jun 2019 17:17:09 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190608033229.GE24059@builder> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Bjorn, On 6/8/2019 9:02 AM, Bjorn Andersson wrote: > On Wed 05 Jun 10:15 PDT 2019, Sricharan R wrote: > >> This patch adds support for the global clock controller found on >> the ipq6018 based devices. >> >> Signed-off-by: Sricharan R >> Signed-off-by: anusha >> Signed-off-by: Abhishek Sahu > > Please fix your s-o-b chain, as described in my reply to 1/8.. > ok. >> --- >> drivers/clk/qcom/Kconfig | 9 + >> drivers/clk/qcom/Makefile | 1 + >> drivers/clk/qcom/gcc-ipq6018.c | 5267 ++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 5277 insertions(+) >> create mode 100644 drivers/clk/qcom/gcc-ipq6018.c >> >> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig >> index e1ff83c..e5fb091 100644 >> --- a/drivers/clk/qcom/Kconfig >> +++ b/drivers/clk/qcom/Kconfig >> @@ -120,6 +120,15 @@ config IPQ_GCC_8074 >> i2c, USB, SD/eMMC, etc. Select this for the root clock >> of ipq8074. >> >> +config IPQ_GCC_6018 > > Please maintain sort order. > ok. >> + tristate "IPQ6018 Global Clock Controller" >> + depends on COMMON_CLK_QCOM >> + help >> + Support for global clock controller on ipq6018 devices. >> + Say Y if you want to use peripheral devices such as UART, SPI, >> + i2c, USB, SD/eMMC, etc. Select this for the root clock >> + of ipq6018. >> + >> config MSM_GCC_8660 >> tristate "MSM8660 Global Clock Controller" >> help >> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile >> index f0768fb..025137d 100644 >> --- a/drivers/clk/qcom/Makefile >> +++ b/drivers/clk/qcom/Makefile >> @@ -22,6 +22,7 @@ obj-$(CONFIG_APQ_MMCC_8084) += mmcc-apq8084.o >> obj-$(CONFIG_IPQ_GCC_4019) += gcc-ipq4019.o >> obj-$(CONFIG_IPQ_GCC_806X) += gcc-ipq806x.o >> obj-$(CONFIG_IPQ_GCC_8074) += gcc-ipq8074.o >> +obj-$(CONFIG_IPQ_GCC_6018) += gcc-ipq6018.o > > Ditto. > ok. >> obj-$(CONFIG_IPQ_LCC_806X) += lcc-ipq806x.o >> obj-$(CONFIG_MDM_GCC_9615) += gcc-mdm9615.o >> obj-$(CONFIG_MDM_LCC_9615) += lcc-mdm9615.o >> diff --git a/drivers/clk/qcom/gcc-ipq6018.c b/drivers/clk/qcom/gcc-ipq6018.c > [..] >> +static int gcc_ipq6018_probe(struct platform_device *pdev) >> +{ >> + return qcom_cc_probe(pdev, &gcc_ipq6018_desc); >> +} >> + >> +static int gcc_ipq6018_remove(struct platform_device *pdev) >> +{ >> + return 0; > > Just omit .remove from the gcc_ipq6018_driver instead of providing a > dummy function. > ok. >> +} >> + >> +static struct platform_driver gcc_ipq6018_driver = { >> + .probe = gcc_ipq6018_probe, >> + .remove = gcc_ipq6018_remove, >> + .driver = { >> + .name = "qcom,gcc-ipq6018", >> + .owner = THIS_MODULE, > > Don't specify .owner in platform drivers. > ok. > [..] >> +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. GCC IPQ6018 Driver"); >> +MODULE_LICENSE("GPL v2"); >> +MODULE_ALIAS("platform:gcc-ipq6018"); > > This modalias won't be used. > ok. But it looks to be there in other clk drivers as well. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation