From: Akash Asthana <akashast@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: gregkh@linuxfoundation.org, agross@kernel.org,
bjorn.andersson@linaro.org, wsa@the-dreams.de,
broonie@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org,
linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, swboyd@chromium.org,
mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-serial@vger.kernel.org, dianders@chromium.org,
msavaliy@codeaurora.org, evgreen@chromium.org
Subject: Re: [PATCH V7 6/7] spi: spi-qcom-qspi: Add interconnect support
Date: Tue, 9 Jun 2020 11:24:46 +0530 [thread overview]
Message-ID: <6905b55b-772d-e027-0675-e1467445f40b@codeaurora.org> (raw)
In-Reply-To: <20200526173613.GF4525@google.com>
Hi Matthias,
On 5/26/2020 11:06 PM, Matthias Kaehlcke wrote:
> On Tue, May 26, 2020 at 06:24:49PM +0530, Akash Asthana wrote:
>> Get the interconnect paths for QSPI device and vote according to the
>> current bus speed of the driver.
>>
>> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
>> ---
>> Changes in V2:
>> - As per Bjorn's comment, introduced and using devm_of_icc_get API for getting
>> path handle
>> - As per Matthias comment, added error handling for icc_set_bw call
>>
>> Changes in V3:
>> - No Change.
>>
>> Changes in V4:
>> - As per Mark's comment move peak_bw guess as twice of avg_bw if
>> nothing mentioned explicitly to ICC core.
>>
>> Changes in V5:
>> - Add icc_enable/disable to power on/off call.
>> - Save some non-zero avg/peak value to ICC core by calling geni_icc_set_bw
>> from probe so that when resume/icc_enable is called NOC are running at
>> some non-zero value.
>>
>> Changes in V6:
>> - As per Matthias's comment made print statement consistent across driver
>>
>> Changes in V7:
>> - As per Matthias's comment removed usage of peak_bw variable because we don't
>> have explicit peak requirement, we were voting peak = avg and this can be
>> tracked using single variable for avg bw.
>> - As per Matthias's comment improved print log.
>>
>> drivers/spi/spi-qcom-qspi.c | 57 ++++++++++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 56 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c
>> index 3c4f83b..092ac27 100644
>> --- a/drivers/spi/spi-qcom-qspi.c
>> +++ b/drivers/spi/spi-qcom-qspi.c
>> @@ -2,6 +2,7 @@
>> // Copyright (c) 2017-2018, The Linux foundation. All rights reserved.
>>
>> #include <linux/clk.h>
>> +#include <linux/interconnect.h>
>> #include <linux/interrupt.h>
>> #include <linux/io.h>
>> #include <linux/module.h>
>> @@ -139,7 +140,9 @@ struct qcom_qspi {
>> struct device *dev;
>> struct clk_bulk_data *clks;
>> struct qspi_xfer xfer;
>> - /* Lock to protect xfer and IRQ accessed registers */
>> + struct icc_path *icc_path_cpu_to_qspi;
>> + unsigned int avg_bw_cpu;
> I should have noticed this earlier, but the field isn't needed now that
> we have icc_enable/disable(). The bandwidth is set in
> qcom_qspi_transfer_one() and that's it.
>
> From my side it would be fine to remove the field in a follow up patch,
> to avoid respinning the series yet another time just for this.
>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
I will resend patch V7 with the suggested change.
Thankyou for reviewing
Regards,
Akash
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-06-09 5:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 12:54 [PATCH V7 0/7] Add interconnect support to QSPI and QUP drivers Akash Asthana
2020-05-26 12:54 ` [PATCH V7 1/7] soc: qcom: geni: Support for ICC voting Akash Asthana
2020-05-26 12:54 ` [PATCH V7 2/7] soc: qcom-geni-se: Add interconnect support to fix earlycon crash Akash Asthana
2020-05-26 12:54 ` [PATCH V7 3/7] i2c: i2c-qcom-geni: Add interconnect support Akash Asthana
2020-05-27 10:04 ` Wolfram Sang
2020-05-26 12:54 ` [PATCH V7 4/7] spi: spi-geni-qcom: " Akash Asthana
2020-05-26 12:54 ` [PATCH V7 5/7] tty: serial: qcom_geni_serial: " Akash Asthana
2020-05-27 8:46 ` Greg KH
2020-05-26 12:54 ` [PATCH V7 6/7] spi: spi-qcom-qspi: " Akash Asthana
2020-05-26 17:36 ` Matthias Kaehlcke
2020-06-09 5:54 ` Akash Asthana [this message]
2020-05-26 12:54 ` [PATCH V7 7/7] arm64: dts: sc7180: Add interconnect for QUP and QSPI Akash Asthana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6905b55b-772d-e027-0675-e1467445f40b@codeaurora.org \
--to=akashast@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=mka@chromium.org \
--cc=msavaliy@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).