From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0CD7C433EF for ; Wed, 13 Oct 2021 04:15:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D414460FDC for ; Wed, 13 Oct 2021 04:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229667AbhJMERt (ORCPT ); Wed, 13 Oct 2021 00:17:49 -0400 Received: from alexa-out.qualcomm.com ([129.46.98.28]:29638 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbhJMERt (ORCPT ); Wed, 13 Oct 2021 00:17:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1634098547; x=1665634547; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=14DSdTniDqdncTmwpMPC/7a3w4g78QTRnhRuSB5a/4E=; b=dMVvCvBwkdlB4jcKI4Xq5JxDCDv5YEowlMjOr+S+ViThUnsO5fhZsGsK eiBQQlDv99s1e7CqPpFGmMKpwGa9ts1kzBeL+AP5zg2RGZLJql8dWNVY4 6asepGVPpBQd2yktbJBM65d85TJe4VK03ziqLzrOS97t1Z/AwMz7CKAOH U=; Received: from ironmsg09-lv.qualcomm.com ([10.47.202.153]) by alexa-out.qualcomm.com with ESMTP; 12 Oct 2021 21:15:46 -0700 X-QCInternal: smtphost Received: from nalasex01c.na.qualcomm.com ([10.47.97.35]) by ironmsg09-lv.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2021 21:15:46 -0700 Received: from [10.231.205.174] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.7; Tue, 12 Oct 2021 21:15:44 -0700 Subject: Re: [RESEND PATCH v1 1/9] spmi: pmic-arb: add a print in cleanup_irq To: Stephen Boyd , , CC: , , Abhijeet Dharmapurikar References: <1631860384-26608-1-git-send-email-quic_fenglinw@quicinc.com> <1631860384-26608-2-git-send-email-quic_fenglinw@quicinc.com> <163406078422.936959.12726677103787301939@swboyd.mtv.corp.google.com> From: Fenglin Wu Message-ID: <6c91a6ad-0ff2-a431-138a-2ec83f2bfa74@quicinc.com> Date: Wed, 13 Oct 2021 12:15:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <163406078422.936959.12726677103787301939@swboyd.mtv.corp.google.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 10/13/2021 1:46 AM, Stephen Boyd wrote: > Quoting Fenglin Wu (2021-09-16 23:32:56) >> From: Abhijeet Dharmapurikar >> >> The cleanup_irq() was meant to clear and mask interrupts that were >> left enabled in the hardware but there was no interrupt handler >> registered for it. Add an error print when it gets invoked. > Why? Don't we get the genirq spurious irq message in this scenario? Thanks for reviewing the change. No, there is no existing message printed out in this special case ( IRQ fired for not registered interrupt). >> Signed-off-by: Abhijeet Dharmapurikar >> Signed-off-by: David Collins >> Signed-off-by: Fenglin Wu