From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Felipe Balbi <balbi@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Caleb Connolly <caleb@connolly.tech>,
Felipe Balbi <felipe.balbi@microsoft.com>
Subject: Re: [PATCH v2] arm64: boot: dts: qcom: sm8150: add SPI nodes
Date: Thu, 15 Apr 2021 20:58:57 +0200 [thread overview]
Message-ID: <6d861c1b-76e3-5572-8ee9-ca2c803eeac5@somainline.org> (raw)
In-Reply-To: <20210415104159.1811077-1-balbi@kernel.org>
Hi!
> Tested on Microsoft Surface Duo (DTS will be sent after -rc1).
Cool, along with the Lumias we'll now have all the MSFT arm64 qcom devices supported :)
>
> + qup_spi0_default: qup-spi0-default {
> + mux {
> + pins = "gpio0", "gpio1", "gpio2", "gpio3";
> + function = "qup0";
> + };
> +
> + config {
> + pins = "gpio0", "gpio1", "gpio2", "gpio3";
> + drive-strength = <6>;
> + bias-disable;
> + };
> + };
> +
This format - while technically still correct - is now considered obsolete. Please move the pin definitions into a more concise one, like so:
qup_spi0_default: qup-spi0-default {
pins = "gpio0", "gpio1", "gpio2", "gpio3";
function = "qup0";
drive-strength = <6>;
bias-disable;
};
(hopefully Thunderbird didn't mess up newlines here..)
Overall, the patch - while on the large side - looks correct to me. Thanks!
Konrad
next prev parent reply other threads:[~2021-04-15 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 10:41 [PATCH v2] arm64: boot: dts: qcom: sm8150: add SPI nodes Felipe Balbi
2021-04-15 18:58 ` Konrad Dybcio [this message]
2021-04-16 10:31 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d861c1b-76e3-5572-8ee9-ca2c803eeac5@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=caleb@connolly.tech \
--cc=devicetree@vger.kernel.org \
--cc=felipe.balbi@microsoft.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).