From: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: robh@kernel.org, swboyd@chromium.org, andy.gross@linaro.org,
shawn.guo@linaro.org, gregkh@linuxfoundation.org,
mark.rutland@arm.com, kishon@ti.com, jackp@codeaurora.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, khasim.mohammed@linaro.org
Subject: Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings
Date: Thu, 29 Aug 2019 09:03:48 +0200 [thread overview]
Message-ID: <6dc0957d-5806-7643-4454-966015865d38@linaro.org> (raw)
In-Reply-To: <20190223165218.GB572@tuxbook-pro>
On 2/23/19 17:52, Bjorn Andersson wrote:
> On Thu 07 Feb 03:17 PST 2019, Jorge Ramirez-Ortiz wrote:
>
>> Binding description for Qualcomm's Synopsys 1.0.0 SuperSpeed phy
>> controller embedded in QCS404.
>>
>> Based on Sriharsha Allenki's <sallenki@codeaurora.org> original
>> definitions.
>>
>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>> ---
>> .../bindings/phy/qcom,snps-usb-ssphy.txt | 79 +++++++++++++++++++
>> 1 file changed, 79 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/phy/qcom,snps-usb-ssphy.txt
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-usb-ssphy.txt b/Documentation/devicetree/bindings/phy/qcom,snps-usb-ssphy.txt
>> new file mode 100644
>> index 000000000000..354e6f9cef62
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-usb-ssphy.txt
>> @@ -0,0 +1,79 @@
>> +Qualcomm Synopsys 1.0.0 SS phy controller
>> +===========================================
>> +
>> +Qualcomm 1.0.0 SS phy controller supports SuperSpeed USB connectivity on
>> +some Qualcomm platforms.
>> +
>> +Required properties:
>> +
>> +- compatible:
>> + Value type: <string>
>> + Definition: Should contain "qcom,snps-usb-ssphy".
>
> Per Rob's request make this:
>
> Should contain "qcom,qcs404-snps-usb-ssphy" and "qcom,snps-usb-ssphy"
ok
>
> You can then leave the driver matching on qcom,snps-usb-ssphy for now
> and if we ever find this to be incompatible with other platforms we can
> make the driver match on the platform-specific compatible.
ok
>
>> +
>> +- reg:
>> + Value type: <prop-encoded-array>
>> + Definition: USB PHY base address and length of the register map.
>> +
>> +- #phy-cells:
>> + Value type: <u32>
>> + Definition: Should be 0. See phy/phy-bindings.txt for details.
>> +
>> +- clocks:
>> + Value type: <prop-encoded-array>
>> + Definition: See clock-bindings.txt section "consumers". List of
>> + three clock specifiers for reference, phy core and
>> + pipe clocks.
>> +
>> +- clock-names:
>> + Value type: <string>
>> + Definition: Names of the clocks in 1-1 correspondence with the "clocks"
>> + property. Must contain "ref", "phy" and "pipe".
>> +
>> +- vdd-supply:
>> + Value type: <phandle>
>> + Definition: phandle to the regulator VDD supply node.
>> +
>> +- vdda1p8-supply:
>> + Value type: <phandle>
>> + Definition: phandle to the regulator 1.8V supply node.
>> +
>> +Optional properties:
>> +
>> +- resets:
>> + Value type: <prop-encoded-array>
>> + Definition: See reset.txt section "consumers". Specifiers for COM and
>> + PHY resets.
>> +
>> +- reset-names:
>> + Value type: <string>
>> + Definition: Names of the resets in 1-1 correspondence with the "resets"
>> + property. Must contain "com" and "phy" if the property is
>> + specified.
>> +
>> +Required child nodes:
>> +
>> +- usb connector node as defined in bindings/connector/usb-connector.txt
>> + containing the property vbus-supply.
>> +
>> +Example:
>> +
>> +usb3_phy: usb3-phy@78000 {
>> + compatible = "qcom,snps-usb-ssphy";
>> + reg = <0x78000 0x400>;
>> + #phy-cells = <0>;
>> + clocks = <&rpmcc RPM_SMD_LN_BB_CLK>,
>> + <&gcc GCC_USB_HS_PHY_CFG_AHB_CLK>,
>> + <&gcc GCC_USB3_PHY_PIPE_CLK>;
>> + clock-names = "ref", "phy", "pipe";
>> + resets = <&gcc GCC_USB3_PHY_BCR>,
>> + <&gcc GCC_USB3PHY_PHY_BCR>;
>> + reset-names = "com", "phy";
>> + vdd-supply = <&vreg_l3_1p05>;
>> + vdda1p8-supply = <&vreg_l5_1p8>;
>> + usb3_c_connector: usb3-c-connector {
>
> The USB-C connector is attached both to the HS and SS PHYs, so I think
> you should represent this external to this node and use of_graph to
> query it.
but AFAICS we wont be able to retrieve the vbux-supply from an external
node (that interface does not exist).
rob, do you have a suggestion?
>
> So the connector should look similar to example 2 in
> connector/usb-connector.txt.
>
> Regards,
> Bjorn
>
>> + compatible = "usb-c-connector";
>> + label = "USB-C";
>> + type = "micro";
>> + vbus-supply = <&usb3_vbus_reg>;
>> + };
>> +};
>> --
>> 2.20.1
>>
>
next prev parent reply other threads:[~2019-08-29 7:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 11:17 [PATCH v4 0/4] USB SS PHY for Qualcomm's QCS404 Jorge Ramirez-Ortiz
2019-02-07 11:17 ` [PATCH v4 1/4] dt-bindings: phy: remove qcom-dwc3-usb-phy Jorge Ramirez-Ortiz
2019-02-13 21:44 ` Rob Herring
2019-02-07 11:17 ` [PATCH v4 2/4] dt-bindings: connector: Add vbus-supply property Jorge Ramirez-Ortiz
2019-02-13 21:44 ` Rob Herring
2019-02-07 11:17 ` [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings Jorge Ramirez-Ortiz
2019-02-13 21:43 ` Rob Herring
2019-02-23 16:52 ` Bjorn Andersson
2019-08-29 7:03 ` Jorge Ramirez [this message]
2019-08-30 16:01 ` Stephen Boyd
2019-08-30 16:45 ` Bjorn Andersson
2019-08-30 18:28 ` Stephen Boyd
2019-09-02 6:23 ` Jorge Ramirez
2019-09-03 17:39 ` Jack Pham
2019-09-03 21:45 ` Stephen Boyd
2019-09-03 23:34 ` Bjorn Andersson
2019-09-05 7:18 ` Jorge Ramirez
2019-09-05 17:58 ` Jack Pham
2019-09-06 5:26 ` Stephen Boyd
2019-09-06 18:25 ` Bjorn Andersson
2019-09-06 20:40 ` Stephen Boyd
2019-02-07 11:17 ` [PATCH v4 4/4] phy: qualcomm: usb: Add SuperSpeed PHY driver Jorge Ramirez-Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dc0957d-5806-7643-4454-966015865d38@linaro.org \
--to=jorge.ramirez-ortiz@linaro.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=khasim.mohammed@linaro.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).