From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFC4CEB64DB for ; Wed, 14 Jun 2023 07:26:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234919AbjFNH0v (ORCPT ); Wed, 14 Jun 2023 03:26:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234743AbjFNHZs (ORCPT ); Wed, 14 Jun 2023 03:25:48 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C979719BC for ; Wed, 14 Jun 2023 00:25:45 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-51873d9a75dso3080584a12.1 for ; Wed, 14 Jun 2023 00:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686727544; x=1689319544; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZYUp6f+gg9nccS7jAmhavJJDmvTnWdlOMMShB2IfyLM=; b=f+YcEOcsWR8xL+5nkBdWG/XfQuwyydCnwar9FyE0t3Il1q/TbBYviUimty8SCA+6JI OVAHeuvn5JYITI7W9hGiUU7vMeA0ISeoGPV0GNyi9lbrYkZ/vU9OKmTFoGEG1EaL80EF WoVjyhNosru4+9vZSX4c1N0vtx2IB2ySXYBz2+3wBy7u5yU53WuKY2tKmVQuJbfPkb6V ex3iX/Qm0KBiyzrxddSfGNS3SqjqzEj+Dyw+rK8fdfBGTds/xOsFw2TDpwSP/IS5ZAg6 +eWVXA0FHOT9SHrACDTibQjZ80tQRKeJNAW01TYc+zt+xoOxBvHkKneW41gn8SX8Pj95 V+Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686727544; x=1689319544; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZYUp6f+gg9nccS7jAmhavJJDmvTnWdlOMMShB2IfyLM=; b=LQx7HYssDJm4C24PlNx2GdbyhQVzMDxsSv9OPGAzjjfTyuvLpfOmaytc8DIvE5x+s2 PAx0GZc/d+hflG63k4H/0mj/mmIOT5K1ypmwnDsOMGJIMCAqo9cT7hYY7b4cJosMsh7Q bOEBng23ik3DQnojQYuW6L0ftIUoGnyN/6i5f4x1OGWWALBvVAcnU7LXLYIKVOFTV7Qt +2RcwGZBvLND6JmtaDfBFs9A3tSaWhvlO6ywxBFPPhlQMT3xrSAPFFPGM2L8Xnj9lt2N D9fAQh+XqSXkz4MNLayRiYYJ08Qa+C2b8UHZNTeoirnVF590wCtAv+LwDhLxbKh44wcz NkWw== X-Gm-Message-State: AC+VfDxCFYzdyzZ/1Nnu2XQCLomLKnCHZLvMESqQulJsFb7cZlrDBE0Z th2mIbnnZ2GMvVVugsju2SPm8A== X-Google-Smtp-Source: ACHHUZ7mP70TiHTncN1MepuY33PcI4oQtT42XBiiH2VcreWZ2uAPSk4CyOcrDDgSGNYQSZjYSpcrNQ== X-Received: by 2002:a05:6402:180f:b0:513:fa61:397a with SMTP id g15-20020a056402180f00b00513fa61397amr816136edy.12.1686727544263; Wed, 14 Jun 2023 00:25:44 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id b24-20020a056402139800b0051827a12b47sm5256406edv.15.2023.06.14.00.25.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 00:25:43 -0700 (PDT) Message-ID: <712b2650-f0c1-088a-612c-ef6d6bcc1eb0@linaro.org> Date: Wed, 14 Jun 2023 09:25:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 20/26] dt-bindings: net: qcom,ethqos: add description for sa8775p Content-Language: en-US To: Bartosz Golaszewski , Vinod Koul , Bhupesh Sharma , Andy Gross , Bjorn Andersson , Konrad Dybcio , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kishon Vijay Abraham I , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu Cc: netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Bartosz Golaszewski References: <20230612092355.87937-1-brgl@bgdev.pl> <20230612092355.87937-21-brgl@bgdev.pl> From: Krzysztof Kozlowski In-Reply-To: <20230612092355.87937-21-brgl@bgdev.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 12/06/2023 11:23, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add the compatible for the MAC controller on sa8775p platforms. This MAC > works with a single interrupt so add minItems to the interrupts property. > The fourth clock's name is different here so change it. Enable relevant > PHY properties. > I think the patch should be squashed with previous. Adding compatible to common snps,dwmac binding does not make sense on its own. It makes sense with adding compatible here. > Signed-off-by: Bartosz Golaszewski > --- > .../devicetree/bindings/net/qcom,ethqos.yaml | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > index 60a38044fb19..b20847c275ce 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > @@ -20,6 +20,7 @@ properties: > compatible: > enum: > - qcom,qcs404-ethqos > + - qcom,sa8775p-ethqos > - qcom,sc8280xp-ethqos > - qcom,sm8150-ethqos > > @@ -32,11 +33,13 @@ properties: > - const: rgmii > > interrupts: > + minItems: 1 > items: > - description: Combined signal for various interrupt events > - description: The interrupt that occurs when Rx exits the LPI state > > interrupt-names: > + minItems: 1 > items: > - const: macirq > - const: eth_lpi > @@ -49,11 +52,20 @@ properties: > - const: stmmaceth > - const: pclk > - const: ptp_ref > - - const: rgmii > + - enum: > + - rgmii > + - phyaux > > iommus: > maxItems: 1 > > + phys: true > + > + phy-supply: true Isn't this property of the phy? > + > + phy-names: > + const: serdes Keep the phy-names after phys. Best regards, Krzysztof