From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Maxime Ripard <maxime@cerno.tech>,
Thierry Reding <thierry.reding@gmail.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Robert Foss <robert.foss@linaro.org>,
Jonas Karlman <jonas@kwiboo.se>,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>,
linux-arm-msm@vger.kernel.org,
Joonyoung Shim <jy0922.shim@samsung.com>,
Rob Clark <robdclark@gmail.com>,
Tian Tao <tiantao6@hisilicon.com>,
Chen Feng <puck.chen@hisilicon.com>,
Xinwei Kong <kong.kongxinwei@hisilicon.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-samsung-soc@vger.kernel.org,
Xinliang Liu <xinliang.liu@linaro.org>,
John Stultz <john.stultz@linaro.org>,
linux-kernel@vger.kernel.org, Inki Dae <inki.dae@samsung.com>,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
Sean Paul <sean@poorly.run>
Subject: Re: [v6,02/21] drm/bridge: adv7511: Register and attach our DSI device at probe
Date: Fri, 29 Oct 2021 08:23:45 +0200 [thread overview]
Message-ID: <73c13cf5-ca36-f47b-f53a-11d4f015505c@samsung.com> (raw)
In-Reply-To: <20211025151536.1048186-3-maxime@cerno.tech>
Hi,
On 25.10.2021 17:15, Maxime Ripard wrote:
> In order to avoid any probe ordering issue, the best practice is to move
> the secondary MIPI-DSI device registration and attachment to the
> MIPI-DSI host at probe time. Let's do this.
>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
This patch landed in linux-next as commit 864c49a31d6b ("drm/bridge:
adv7511: Register and attach our DSI device at probe"). Sadly it causes
endless probe-fail-defer loop on DragonBoard 410c board
(arch/arm64/boot/dts/qcom/apq8016-sbc.dts):
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: PMIC
REV: 1 CODEC Version: 1
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
source widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
source widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget ADC1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget ADC1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
source widget PDM_RX3 overwritten
debugfs: File 'Capture' in directory 'dapm' already present!
adv7511 3-0039: failed to find dsi host
adv7511 3-0039: supply dvdd not found, using dummy regulator
adv7511 3-0039: supply pvdd not found, using dummy regulator
adv7511 3-0039: supply a2vdd not found, using dummy regulator
debugfs: Directory '7708000.audio-controller' with parent 'DB410c'
already present!
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: PMIC
REV: 1 CODEC Version: 1
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
source widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
source widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget ADC1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget ADC1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
source widget PDM_RX3 overwritten
debugfs: File 'Capture' in directory 'dapm' already present!
adv7511 3-0039: failed to find dsi host
adv7511 3-0039: supply dvdd not found, using dummy regulator
adv7511 3-0039: supply pvdd not found, using dummy regulator
adv7511 3-0039: supply a2vdd not found, using dummy regulator
debugfs: Directory '7708000.audio-controller' with parent 'DB410c'
already present!
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: PMIC
REV: 1 CODEC Version: 1
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
source widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
source widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget ADC1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget ADC1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
sink widget PDM_RX1 overwritten
qcom,pm8916-wcd-spmi-codec 200f000.spmi:pmic@1:audio-codec@f000: ASoC:
source widget PDM_RX3 overwritten
debugfs: File 'Capture' in directory 'dapm' already present!
adv7511 3-0039: failed to find dsi host
adv7511 3-0039: supply dvdd not found, using dummy regulator
adv7511 3-0039: supply pvdd not found, using dummy regulator
adv7511 3-0039: supply a2vdd not found, using dummy regulator
debugfs: Directory '7708000.audio-controller' with parent 'DB410c'
already present!
...
Reverting it on top of linux next-20211028 'fixes' this issue.
> ---
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index 9e3585f23cf1..f8e5da148599 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -910,9 +910,6 @@ static int adv7511_bridge_attach(struct drm_bridge *bridge,
> return ret;
> }
>
> - if (adv->type == ADV7533 || adv->type == ADV7535)
> - ret = adv7533_attach_dsi(adv);
> -
> if (adv->i2c_main->irq)
> regmap_write(adv->regmap, ADV7511_REG_INT_ENABLE(0),
> ADV7511_INT0_HPD);
> @@ -1288,8 +1285,18 @@ static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
> drm_bridge_add(&adv7511->bridge);
>
> adv7511_audio_init(dev, adv7511);
> +
> + if (adv7511->type == ADV7533 || adv7511->type == ADV7535) {
> + ret = adv7533_attach_dsi(adv7511);
> + if (ret)
> + goto err_unregister_audio;
> + }
> +
> return 0;
>
> +err_unregister_audio:
> + adv7511_audio_exit(adv7511);
> + drm_bridge_remove(&adv7511->bridge);
> err_unregister_cec:
> i2c_unregister_device(adv7511->i2c_cec);
> clk_disable_unprepare(adv7511->cec_clk);
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2021-10-29 6:23 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 15:15 [PATCH v6 00/21] drm/bridge: Make panel and bridge probe order consistent Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 01/21] drm/bridge: adv7533: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 02/21] drm/bridge: adv7511: Register and attach our DSI device at probe Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
[not found] ` <CGME20211029062347eucas1p1431402205321b066349e3ccf432d2452@eucas1p1.samsung.com>
2021-10-29 6:23 ` Marek Szyprowski [this message]
2021-10-29 8:05 ` [v6,02/21] " Maxime Ripard
2021-10-29 8:36 ` Marek Szyprowski
2021-10-29 8:46 ` Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 03/21] drm/bridge: anx7625: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 04/21] drm/bridge: anx7625: Register and attach our DSI device at probe Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 05/21] drm/bridge: lt8912b: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 06/21] drm/bridge: lt8912b: Register and attach our DSI device at probe Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 07/21] drm/bridge: lt9611: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 08/21] drm/bridge: lt9611: Register and attach our DSI device at probe Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 09/21] drm/bridge: lt9611uxc: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 10/21] drm/bridge: lt9611uxc: Register and attach our DSI device at probe Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 11/21] drm/bridge: ps8640: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 12/21] drm/bridge: ps8640: Register and attach our DSI device at probe Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 13/21] drm/bridge: sn65dsi83: Fix bridge removal Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 14/21] drm/bridge: sn65dsi83: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 15/21] drm/bridge: sn65dsi83: Register and attach our DSI device at probe Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 16/21] drm/bridge: sn65dsi86: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 17/21] drm/bridge: sn65dsi86: Register and attach our DSI device at probe Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 18/21] drm/bridge: tc358775: Switch to devm MIPI-DSI helpers Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 19/21] drm/bridge: tc358775: Register and attach our DSI device at probe Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 20/21] drm/kirin: dsi: Adjust probe order Maxime Ripard
2021-10-27 18:34 ` John Stultz
2021-10-27 20:09 ` (subset) " Maxime Ripard
2021-10-25 15:15 ` [PATCH v6 21/21] drm/msm/dsi: " Maxime Ripard
2021-10-27 20:09 ` (subset) " Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73c13cf5-ca36-f47b-f53a-11d4f015505c@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jernej.skrabec@gmail.com \
--cc=john.stultz@linaro.org \
--cc=jonas@kwiboo.se \
--cc=jy0922.shim@samsung.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=puck.chen@hisilicon.com \
--cc=robdclark@gmail.com \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@gmail.com \
--cc=tiantao6@hisilicon.com \
--cc=tzimmermann@suse.de \
--cc=xinliang.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).