From: David Collins <collinsd@codeaurora.org>
To: Rajendra Nayak <rnayak@codeaurora.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Andy Gross <andy.gross@linaro.org>,
devicetree@vger.kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners
Date: Wed, 30 May 2018 11:27:27 -0700 [thread overview]
Message-ID: <7432f626-69cd-3535-04bc-de42e0285d41@codeaurora.org> (raw)
In-Reply-To: <0e07d577-9728-e97a-2da0-dd7dd324f058@codeaurora.org>
Hello Rajendra,
On 05/30/2018 03:14 AM, Rajendra Nayak wrote:
> On 05/30/2018 02:47 PM, Ulf Hansson wrote:
>> On 25 May 2018 at 12:01, Rajendra Nayak <rnayak@codeaurora.org> wrote:
...
>>> + pm_genpd_init(&rpmpds[i]->pd, NULL, true);
>>
>> Question: Is there no hierarchical topology of the PM domains. No
>> genpd subdomains?
>
> The hierarchy if any is all handled by the remote core (RPM in this case).
> For Linux its just a flat view.
There is one special case that we'll need to handle somehow. The APPS
vlvl request for VDD_MX needs to be greater than or equal to the vlvl
request for VDD_CX. Can you please add the necessary code to achieve
this? RPMh hardware doesn't handle this hardware requirement due to
concerns about modem use case latency.
Please note that this is handled in a somewhat hacky manner [1] with the
downstream rpmh-regulator driver by specifying VDD_MX as the parent of
VDD_CX and VDD_MX_AO as the parent of VDD_CX_AO with a dropout voltage of
-1. That way, enabling CX causes MX to be enabled and voltage level
requests are propagated from CX to MX (the -1 is ignored because it is
rounded up within the sparse vlvl numbering space).
Thanks,
David
[1]:
https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/arch/arm64/boot/dts/qcom/sdm845-regulator.dtsi?h=msm-4.9#n135
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-05-30 18:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 10:01 [PATCH v2 0/6] Add powerdomain driver for corners on msm8996/sdm845 Rajendra Nayak
2018-05-25 10:01 ` [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners Rajendra Nayak
2018-05-30 9:17 ` Ulf Hansson
2018-05-30 10:14 ` Rajendra Nayak
2018-05-30 12:44 ` Ulf Hansson
2018-05-31 4:20 ` Rajendra Nayak
2018-05-31 11:09 ` Ulf Hansson
2018-05-30 18:27 ` David Collins [this message]
2018-05-31 3:53 ` Rajendra Nayak
2018-05-31 3:27 ` Rob Herring
2018-05-31 4:14 ` Rajendra Nayak
2018-05-25 10:01 ` [PATCH v2 2/6] dt-bindings: opp: Introduce qcom-opp bindings Rajendra Nayak
2018-05-25 22:33 ` David Collins
2018-05-29 9:49 ` Rajendra Nayak
2018-05-25 10:01 ` [PATCH v2 3/6] soc: qcom: rpmpd: Add support for get/set performance state Rajendra Nayak
2018-05-25 10:01 ` [PATCH v2 4/6] arm64: dts: msm8996: Add rpmpd device node Rajendra Nayak
2018-05-25 10:01 ` [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver Rajendra Nayak
2018-05-26 1:08 ` David Collins
2018-05-29 10:19 ` Rajendra Nayak
2018-05-29 19:03 ` David Collins
2018-05-30 8:55 ` Rajendra Nayak
2018-05-30 9:44 ` Viresh Kumar
2018-05-30 10:07 ` Rajendra Nayak
2018-06-01 8:48 ` Rajendra Nayak
2018-06-01 19:19 ` David Collins
2018-06-13 18:29 ` Lina Iyer
2018-05-31 3:31 ` Rob Herring
2018-05-31 4:15 ` Rajendra Nayak
2018-05-25 10:01 ` [PATCH v2 6/6] soc: qcom: rpmpd/rpmhpd: Add a max vote on all corners at init Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7432f626-69cd-3535-04bc-de42e0285d41@codeaurora.org \
--to=collinsd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).