From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 446C6C48BE5 for ; Wed, 16 Jun 2021 19:11:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F3D461246 for ; Wed, 16 Jun 2021 19:11:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232329AbhFPTN0 (ORCPT ); Wed, 16 Jun 2021 15:13:26 -0400 Received: from mga03.intel.com ([134.134.136.65]:39857 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232530AbhFPTNY (ORCPT ); Wed, 16 Jun 2021 15:13:24 -0400 IronPort-SDR: xA/GS1uI8oTlRt0ZkDutN8YFPoCK+WzLIBTHet2pesEgUmrmRH2+jgutMi032ZH2ja7vNe6ACo B2NV2EWfM1Pw== X-IronPort-AV: E=McAfee;i="6200,9189,10016"; a="206278121" X-IronPort-AV: E=Sophos;i="5.83,278,1616482800"; d="scan'208";a="206278121" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2021 12:11:16 -0700 IronPort-SDR: n6zRFDrwjIzQ47702ClxTmPuOe3ZO+JXUoWxQtosamnGyR9/uvZ608qFuQhnMUaTWvtcZYsAfp Ft5a6WSHOxlg== X-IronPort-AV: E=Sophos;i="5.83,278,1616482800"; d="scan'208";a="640104279" Received: from mindylam-mobl1.amr.corp.intel.com (HELO [10.213.182.47]) ([10.213.182.47]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2021 12:11:14 -0700 Subject: Re: [PATCH] ASoC: max98357a: set channels_max to 4 To: Cheng-yi Chiang Cc: Taniya Das , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ALSA development , Banajit Goswami , Rob Herring , Stephan Gerhold , Liam Girdwood , linux-arm-msm , Patrick Lai , Takashi Iwai , Tzung-Bi Shih , Stephen Boyd , Tzung-Bi Shih , Andy Gross , Rohit kumar , Mark Brown , Douglas Anderson , Dylan Reid , Bjorn Andersson , Judy Hsiao , "moderated list:ARM/Mediatek SoC support" References: <20210526154704.114957-1-judyhsiao@chromium.org> <3501e398-dfba-43b1-4638-325a158e860d@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <7748e621-ba54-db90-6b56-23e006eb1dbe@linux.intel.com> Date: Wed, 16 Jun 2021 11:23:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org >> I don't think it's correct to declare 4-channel support at the >> individual codec DAI level when in practice each device will be provided >> with a TDM mask that selects two slots. > > On this platform there is no TDM support, so there were two I2S data lines. > >> >> This is confusing device capabilities and TDM link configuration. > > I see that in most of the use cases of multiple amps, we should use > codecs and num_codecs of the link. > But in this case we only want one codec to control the only GPIO > shared by 4 max98357a amps > I think we should be able to use 1 max98357 codec and 3 dummy codec to > fulfill this use case. > Not sure if the number of dummy codec would really matter. > With num_codec > 1 we should be able to bypass the channel checking > and just use the channel from CPU DAI. Interesting, I haven't seen such 'multi-lane' solutions so far for I2S.