From: alokc@codeaurora.org
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-spi@vger.kernel.org, linux-serial@vger.kernel.org,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
dianders@chromium.org, swboyd@chromium.org,
bjorn.andersson@linaro.org
Subject: Re: [PATCH 1/6] dt-bindings: soc: qcom: Add interconnect binding for GENI QUP
Date: Wed, 30 Jan 2019 14:29:52 -0800 [thread overview]
Message-ID: <77a4841746b00a67a14daa42886be57b@codeaurora.org> (raw)
In-Reply-To: <c4260d66-5ca4-b194-0cbc-2a682a99db4b@linaro.org>
On 2019-01-23 10:35, Georgi Djakov wrote:
> Hi Alok,
>
> Thanks for the patches!
>
> On 1/22/19 08:33, Alok Chauhan wrote:
>> Add documentation for the interconnect and interconnect-names bindings
>
> s/interconnect /interconnects /
>
>> for the GENI QUP as detailed by
>> bindings/interconnect/interconnect.txt.
>>
>> Signed-off-by: Alok Chauhan <alokc@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt | 10
>> ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
>> b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
>> index dab7ca9..44d7e02 100644
>> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
>> @@ -17,6 +17,12 @@ Required properties if child node exists:
>> - #address-cells: Must be <1> for Serial Engine Address
>> - #size-cells: Must be <1> for Serial Engine Address Size
>> - ranges: Must be present
>> +- interconnects: phandle to a interconnect provider. Please refer
>
> s/a interconnect/an interconnect/
sure, will do.
>
>> + ../interconnect/interconnect.txt for details.
>> + Must be 2 paths corresponding to 2 AXI ports.
>> +- interconnect-names: Port names to differentiate between the
>> + 2 interconnect paths defined with interconnect
>> + specifier.
>>
>> Properties for children:
>>
>> @@ -67,6 +73,10 @@ Example:
>> #size-cells = <1>;
>> ranges;
>>
>> + interconnects = <&qnoc 11 &qnoc 512>,
>> + <&qnoc 0 &qnoc 543>;
>
> Please take a snippet from your patch 6/6 and put it here instead of
> the
> hard-coded integers above.
sure
>
>> + interconnect-names = "qup-memory", "qup-config";
>> +
>> i2c0: i2c@a94000 {
>> compatible = "qcom,geni-i2c";
>> reg = <0xa94000 0x4000>;
>>
>
> When you post a new version, please change the subject of the patch
> series to PATCH v2, PATCH v3 etc, in order to be able to distinguish
> between different versions.
sure, will do this.
>
> Thanks,
> Georgi
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2019-01-30 22:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 6:33 [PATCH 0/6] Add interconnect support for GENI QUPs Alok Chauhan
2019-01-22 6:33 ` [PATCH 1/6] dt-bindings: soc: qcom: Add interconnect binding for GENI QUP Alok Chauhan
2019-01-23 6:48 ` alokc
2019-01-23 17:07 ` Bjorn Andersson
2019-01-23 18:41 ` Georgi Djakov
2019-02-23 0:26 ` Rob Herring
2019-02-25 17:39 ` Georgi Djakov
2019-01-23 18:35 ` Georgi Djakov
2019-01-30 22:29 ` alokc [this message]
2019-01-24 1:10 ` Evan Green
2019-01-30 22:27 ` alokc
2019-01-22 6:33 ` [PATCH 2/6] soc: qcom: Add wrapper to support for Interconnect path Alok Chauhan
2019-01-23 7:02 ` alokc
2019-01-23 18:14 ` Bjorn Andersson
2019-01-22 6:33 ` [PATCH 3/6] i2c: i2c-qcom-geni: Add interconnect support Alok Chauhan
2019-01-22 9:07 ` Wolfram Sang
2019-01-22 9:13 ` Peter Rosin
2019-01-23 6:51 ` alokc
2019-01-24 1:19 ` Evan Green
2019-01-22 6:33 ` [PATCH 4/6] spi: spi-geni-qcom: " Alok Chauhan
2019-01-22 20:29 ` Mark Brown
2019-01-23 7:15 ` alokc
2019-01-23 10:58 ` Mark Brown
2019-01-23 16:04 ` Mark Brown
2019-01-24 1:20 ` Evan Green
2019-01-22 6:33 ` [PATCH 5/6] tty: serial: qcom_geni_serial: " Alok Chauhan
2019-01-23 6:53 ` alokc
2019-01-22 6:33 ` [PATCH 6/6] arm64: dts: sdm845: Add interconnect for GENI QUP Alok Chauhan
2019-01-23 6:54 ` alokc
2019-01-23 6:45 ` [PATCH 0/6] Add interconnect support for GENI QUPs alokc
-- strict thread matches above, loose matches on Subject: below --
2019-01-21 11:21 Alok Chauhan
2019-01-21 11:21 ` [PATCH 1/6] dt-bindings: soc: qcom: Add interconnect binding for GENI QUP Alok Chauhan
2019-01-22 6:43 ` alokc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77a4841746b00a67a14daa42886be57b@codeaurora.org \
--to=alokc@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).