From: Sinan Kaya <Okaya@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: dan.j.williams@intel.com, vkoul@kernel.org,
Andy Gross <agross@kernel.org>,
David Brown <david.brown@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] dma: qcom: hidma: no need to check return value of debugfs_create functions
Date: Wed, 12 Jun 2019 12:17:31 -0400 [thread overview]
Message-ID: <78da53a1-1363-fad8-16fa-4dfc6555f4e4@kernel.org> (raw)
In-Reply-To: <20190612153948.GA21828@kroah.com>
On 6/12/2019 11:39 AM, Greg Kroah-Hartman wrote:
>> Interesting. Wouldn't debugfs_create_file() blow up if dir is NULL
>> for some reason?
> It will create a file in the root of debugfs. But how will that happen?
> debugfs_create_dir() can not return NULL.
I see.
>
>> + debugfs_create_file("stats", S_IRUGO, dir, chan,
>> + &hidma_chan_fops);
>>
>> Note that code ignores the return value of hidma_debug_init();
>> It was just trying to do clean up on debugfs failure by calling
>>
>> debugfs_remove_recursive(dmadev->debugfs);
> Is that a problem?
I just wanted to double check. You probably want to remove the return
value on debugfs_create_file() to prevent others from doing the same
thing.
Acked-by: Sinan Kaya <okaya@kernel.org>
next prev parent reply other threads:[~2019-06-12 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190612122557.24158-1-gregkh@linuxfoundation.org>
2019-06-12 12:25 ` [PATCH 6/6] dma: qcom: hidma: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-12 15:24 ` Sinan Kaya
2019-06-12 15:39 ` Greg Kroah-Hartman
2019-06-12 16:17 ` Sinan Kaya [this message]
2019-06-12 16:47 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78da53a1-1363-fad8-16fa-4dfc6555f4e4@kernel.org \
--to=okaya@kernel.org \
--cc=agross@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=david.brown@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).