From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
To: Stephan Gerhold <stephan@gerhold.net>,
Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, He Ying <heying24@huawei.com>,
Arnd Bergmann <arnd@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] cpuidle: ARM_QCOM_SPM_CPUIDLE should depend on HAVE_ARM_SMCCC
Date: Mon, 7 Jun 2021 19:30:36 +0200 [thread overview]
Message-ID: <7a207351-43e1-d439-9d86-bb28b6935fa2@intel.com> (raw)
In-Reply-To: <YL4Is1LNzBuViF3/@gerhold.net>
On 6/7/2021 1:53 PM, Stephan Gerhold wrote:
> Hi!
>
> On Sun, Jun 06, 2021 at 12:00:48PM -0700, Randy Dunlap wrote:
>> QCOM_SCM depends on HAVE_ARM_SMCCC, so ARM_QCOM_SPM_CPUIDLE should
>> also depend on HAVE_ARM_SMCCC since 'select' does not follow any
>> dependency chains.
>>
>> This fixes a kconfig warning and subsequent build errors:
>>
>> WARNING: unmet direct dependencies detected for QCOM_SCM
>> Depends on [n]: (ARM [=y] || ARM64) && HAVE_ARM_SMCCC [=n]
>> Selected by [y]:
>> - ARM_QCOM_SPM_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_QCOM [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
>>
>> arm-linux-gnueabi-ld: drivers/firmware/qcom_scm-smc.o: in function `__scm_smc_do_quirk':
>> qcom_scm-smc.c:(.text+0x5c): undefined reference to `__arm_smccc_smc'
>> arm-linux-gnueabi-ld: drivers/firmware/qcom_scm-legacy.o: in function `scm_legacy_call':
>> qcom_scm-legacy.c:(.text+0x140): undefined reference to `__arm_smccc_smc'
>> arm-linux-gnueabi-ld: drivers/firmware/qcom_scm-legacy.o: in function `scm_legacy_call_atomic':
>> qcom_scm-legacy.c:(.text+0x364): undefined reference to `__arm_smccc_smc'
>>
>> Fixes: a871be6b8eee ("cpuidle: Convert Qualcomm SPM driver to a generic CPUidle driver")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Stephan Gerhold <stephan@gerhold.net>
>> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> Cc: Andy Gross <agross@kernel.org>
>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Cc: linux-arm-msm@vger.kernel.org
>> Cc: He Ying <heying24@huawei.com>
> There was a similar patch from Arnd a while ago (which fixes another
> warning for ARM_CPU_SUSPEND?):
>
> https://lore.kernel.org/linux-pm/20210421135723.3601743-1-arnd@kernel.org/
>
> I'm not sure who is supposed to pick it up. :)
ARM cpuidle drivers are maintained by Daniel Lezcano.
Also, please CC power management material to linux-pm@vger.kernel.org.
>
>> ---
>> drivers/cpuidle/Kconfig.arm | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20210604.orig/drivers/cpuidle/Kconfig.arm
>> +++ linux-next-20210604/drivers/cpuidle/Kconfig.arm
>> @@ -108,6 +108,7 @@ config ARM_TEGRA_CPUIDLE
>> config ARM_QCOM_SPM_CPUIDLE
>> bool "CPU Idle Driver for Qualcomm Subsystem Power Manager (SPM)"
>> depends on (ARCH_QCOM || COMPILE_TEST) && !ARM64 && MMU
>> + depends on HAVE_ARM_SMCCC
>> select ARM_CPU_SUSPEND
>> select CPU_IDLE_MULTIPLE_DRIVERS
>> select DT_IDLE_STATES
prev parent reply other threads:[~2021-06-07 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-06 19:00 [PATCH] cpuidle: ARM_QCOM_SPM_CPUIDLE should depend on HAVE_ARM_SMCCC Randy Dunlap
2021-06-07 11:53 ` Stephan Gerhold
2021-06-07 17:30 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a207351-43e1-d439-9d86-bb28b6935fa2@intel.com \
--to=rafael.j.wysocki@intel.com \
--cc=agross@kernel.org \
--cc=arnd@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=heying24@huawei.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).