From: Lukasz Luba <lukasz.luba@arm.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thara Gopinath <thara.gopinath@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] base: arch_topology: Use policy->max to calculate freq_factor
Date: Wed, 17 Nov 2021 15:08:04 +0000 [thread overview]
Message-ID: <7f077790-da4c-35b8-0eea-cbdc630f9d2a@arm.com> (raw)
In-Reply-To: <CAJZ5v0iRDtr5yae5UndwU2SmVL4cak=BN0irVGbgNzQiS8K3mA@mail.gmail.com>
On 11/17/21 12:49 PM, Rafael J. Wysocki wrote:
> On Wed, Nov 17, 2021 at 11:46 AM Lukasz Luba <lukasz.luba@arm.com> wrote:
>>
>> Hi Rafael,
>>
>> On 11/16/21 7:05 PM, Rafael J. Wysocki wrote:
>>> On Mon, Nov 15, 2021 at 9:10 PM Thara Gopinath
>>> <thara.gopinath@linaro.org> wrote:
>>>>
>>>> cpuinfo.max_freq can reflect boost frequency if enabled during boot. Since
>>>> we don't consider boost frequencies while calculating cpu capacities, use
>>>> policy->max to populate the freq_factor during boot up.
>>>
>>> I'm not sure about this. schedutil uses cpuinfo.max_freq as the max frequency.
>>
>> Agree it's tricky how we treat the boost frequencies and also combine
>> them with thermal pressure.
>> We probably would have consider these design bits:
>> 1. Should thermal pressure include boost frequency?
>
> Well, I guess so.
>
> Running at a boost frequency certainly increases thermal pressure.
>
>> 2. Should max capacity 1024 be a boost frequency so scheduler
>> would see it explicitly?
>
> That's what it is now if cpuinfo.max_freq is a boost frequency.
>
>> - if no, then schedutil could still request boost freq thanks to
>> map_util_perf() where we add 25% to the util and then
>> map_util_freq() would return a boost freq when util was > 1024
>>
>>
>> I can see in schedutil only one place when cpuinfo.max_freq is used:
>> get_next_freq(). If the value stored in there is a boost,
>> then don't we get a higher freq value for the same util?
>
> Yes. we do, which basically is my point.
>
> The schedutil's response is proportional to cpuinfo.max_freq and that
> needs to be taken into account for the results to be consistent.
>
This boost thing wasn't an issue for us, because we didn't have
platforms which come with it (till recently). I've checked that you have
quite a few CPUs which support huge boost freq, e.g. 5GHz vs. 3.6GHz
nominal max freq [1]. Am I reading this correctly as kernel boost freq?
Do you represent this 5GHz as 1024 capacity?
From this schedutil get_next_freq() I would guess yes.
I cannot find if you use thermal pressure, could you help me with this,
please?
[1]
https://ark.intel.com/content/www/us/en/ark/products/186605/intel-core-i99900k-processor-16m-cache-up-to-5-00-ghz.html
next prev parent reply other threads:[~2021-11-17 15:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 20:10 [PATCH] base: arch_topology: Use policy->max to calculate freq_factor Thara Gopinath
2021-11-16 19:05 ` Rafael J. Wysocki
2021-11-17 10:46 ` Lukasz Luba
2021-11-17 12:49 ` Rafael J. Wysocki
2021-11-17 15:08 ` Lukasz Luba [this message]
2021-11-17 15:17 ` Rafael J. Wysocki
2021-11-17 15:47 ` Lukasz Luba
2021-11-17 17:01 ` Thara Gopinath
2021-11-17 17:59 ` Rafael J. Wysocki
2021-12-02 10:50 ` Morten Rasmussen
2021-12-02 16:31 ` Rafael J. Wysocki
2021-12-03 9:48 ` Morten Rasmussen
2021-12-03 15:07 ` Rafael J. Wysocki
2021-12-08 9:20 ` Morten Rasmussen
2021-11-17 11:21 ` Dietmar Eggemann
2021-11-17 10:12 ` Lukasz Luba
2021-11-24 16:22 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f077790-da4c-35b8-0eea-cbdc630f9d2a@arm.com \
--to=lukasz.luba@arm.com \
--cc=bjorn.andersson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).