From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that resume in ARM state Date: Mon, 08 Jun 2015 15:03:04 -0700 Message-ID: <7htwuhsvs7.fsf@deeprootsystems.com> References: <1433272378-8470-1-git-send-email-sboyd@codeaurora.org> <1433272378-8470-2-git-send-email-sboyd@codeaurora.org> <20150602234048.GA7557@n2100.arm.linux.org.uk> <20150603001120.GA4534@codeaurora.org> <7h3821ubpf.fsf@deeprootsystems.com> <55760B6D.7090302@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pd0-f174.google.com ([209.85.192.174]:33102 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932498AbbFHWDH (ORCPT ); Mon, 8 Jun 2015 18:03:07 -0400 Received: by pdjn11 with SMTP id n11so469197pdj.0 for ; Mon, 08 Jun 2015 15:03:06 -0700 (PDT) In-Reply-To: <55760B6D.7090302@codeaurora.org> (Stephen Boyd's message of "Mon, 08 Jun 2015 14:38:53 -0700") Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Russell King - ARM Linux , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andy Gross , Kumar Gala , Ard Biesheuvel , Lina Iyer Stephen Boyd writes: > On 06/08/2015 02:33 PM, Kevin Hilman wrote: >> Stephen Boyd writes: >> >>> On 06/03, Russell King - ARM Linux wrote: >>>> On Tue, Jun 02, 2015 at 12:12:57PM -0700, Stephen Boyd wrote: >>>>> Some platforms always enter the kernel in the ARM state even if >>>>> the kernel is compiled for THUMB2. Add a small wrapper on top of >>>>> cpu_resume() that switches into THUMB2 state. >>>>> >>>>> This fixes a problem reported by Kevin Hilman on next-20150601 >>>>> where the ifc6410 fails to boot a THUMB2 kernel because the >>>>> platform's firmware always enters the kernel in ARM mode from >>>>> deep idle states. >>>> I think this bit of the commit message isn't quite correct: this will >>>> only resolve the boot problem with a T2 kernel when the failing platform >>>> is converted to use the cpu_resume_arm() entry point. >>>> >>>> Apart from that, the patch looks good to me, thanks. >>> Sure, it could say "This provides the functionality to fix a problem >>> reported by..." >> Stephen, are you planning to submit this through Russell's patch >> tracker? or... >> >> Russell, should we take this through arm-soc along with PATCH 2/2 which >> depends on this one? >> > > I'm happy to see it be applied by arm-soc maintainers directly given > that Russell said "the patch looks good to me". The commit text needs a > slight reword here though, so I can resubmit the patches to arm-soc if > you like. Go ahead and respin/resubmit, and I can get them ready, but I'll wait for an official word or acked-by from Russell before taking them both through arm-soc. Kevin