Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: agross@kernel.org, robh+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, rohitkr@codeaurora.org,
	srinivas.kandagatla@linaro.org,
	Ajit Pandey <ajitp@codeaurora.org>,
	V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver
Date: Tue, 1 Dec 2020 09:22:40 +0530
Message-ID: <838489a9-22df-0d1c-9b8c-30f9c35e8442@codeaurora.org> (raw)
In-Reply-To: <X8UjShseQ0F7itZe@builder.lan>

Thanks Bjorn For your comments!!!

On 11/30/2020 10:22 PM, Bjorn Andersson wrote:
> On Fri 18 Sep 09:51 CDT 2020, Srinivasa Rao Mandadapu wrote:
>
>> From: Ajit Pandey <ajitp@codeaurora.org>
>>
>> Add dai link for supporting lpass I2S driver, which is used
>> for audio capture and playback.
>> Add lpass-cpu node with  pin controls and i2s primary
>> and secondary dai-links
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
>> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> Ajit needs to certify the origin of the patch, with his signed-off-by
> and as you are the last to touch it your signed-off-by should be last.
>
> Also, please advice on the dependencies of this patch, because the tree
> doesn't build after applying this patch.
>
> Regards,
> Bjorn

After this patch v2 patch is posted.

https://lore.kernel.org/patchwork/patch/1317796/

>> ---
>>   arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 59 ++++++++++++++++++++++++++++
>>   1 file changed, 59 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
>> index bf87558..5724982 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
>> @@ -220,6 +220,44 @@
>>   			max-brightness = <1023>;
>>   		};
>>   	};
>> +
>> +	sound {
>> +		compatible = "qcom,sc7180-sndcard";
>> +		model = "sc7180-snd-card";
>> +
>> +		audio-routing =
>> +			"Headphone Jack", "HPOL",
>> +			"Headphone Jack", "HPOR";
>> +
>> +		audio-jack = <&alc5682>;
>> +
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +		dai-link@0 {
>> +			link-name = "MultiMedia0";
>> +			reg = <0>;
>> +			cpu {
>> +				sound-dai = <&lpass_cpu 0>;
>> +			};
>> +
>> +			codec {
>> +				sound-dai = <&alc5682 0>;
>> +			};
>> +		};
>> +
>> +		dai-link@1 {
>> +			link-name = "MultiMedia1";
>> +			reg = <1>;
>> +			cpu {
>> +				sound-dai = <&lpass_cpu 1>;
>> +			};
>> +
>> +			codec {
>> +				sound-dai = <&max98357a>;
>> +			};
>> +		};
>> +	};
>>   };
>>   
>>   &qfprom {
>> @@ -725,6 +763,27 @@ hp_i2c: &i2c9 {
>>   	modem-init;
>>   };
>>   
>> +&lpass_cpu {
>> +	status = "okay";
>> +
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&sec_mi2s_active &pri_mi2s_active &pri_mi2s_mclk_active>;
>> +
>> +	#address-cells = <1>;
>> +	#size-cells = <0>;
>> +
>> +	mi2s-primary@0 {
>> +		reg = <MI2S_PRIMARY>;
>> +		qcom,playback-sd-lines = <1>;
>> +		qcom,capture-sd-lines = <0>;
>> +	};
>> +
>> +	mi2s-secondary@1 {
>> +		reg = <MI2S_SECONDARY>;
>> +		qcom,playback-sd-lines = <0>;
>> +	};
>> +};
>> +
>>   &mdp {
>>   	status = "okay";
>>   };
>> -- 
>> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
>> is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
>>
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 14:51 Srinivasa Rao Mandadapu
2020-11-30 16:52 ` Bjorn Andersson
2020-12-01  3:52   ` Srinivasa Rao Mandadapu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838489a9-22df-0d1c-9b8c-30f9c35e8442@codeaurora.org \
    --to=srivasam@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=ajitp@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rohitkr@codeaurora.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=vsujithk@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git