From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 968B5C433FE for ; Fri, 15 Oct 2021 01:28:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75620611CE for ; Fri, 15 Oct 2021 01:28:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232102AbhJOBaF (ORCPT ); Thu, 14 Oct 2021 21:30:05 -0400 Received: from alexa-out.qualcomm.com ([129.46.98.28]:30303 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231871AbhJOBaF (ORCPT ); Thu, 14 Oct 2021 21:30:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1634261280; x=1665797280; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=/8ELnxm3qwPuqI4ajB9klaDzyOwohX5IHI+2TL0f6Ng=; b=e4SvXk4o5cglvEADYl2RCuS9TsMPsw0JmribBqxUbcmZVoK88pwUYnXB 2MH6XAU4BQQw7Yh0bJB1Wh51vDNOJiGDDk5xuQOk+bhiRHIwEGLgtR5Gk 08fST4/GbQa/rvRHYwvIOSGkQcKDD/na7TTIOF5RfFi52Zdx1Rl8TEtpK w=; Received: from ironmsg07-lv.qualcomm.com ([10.47.202.151]) by alexa-out.qualcomm.com with ESMTP; 14 Oct 2021 18:27:59 -0700 X-QCInternal: smtphost Received: from nalasex01c.na.qualcomm.com ([10.47.97.35]) by ironmsg07-lv.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 18:27:59 -0700 Received: from [10.231.205.174] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.7; Thu, 14 Oct 2021 18:27:57 -0700 Subject: Re: [RESEND PATCH v1 1/9] spmi: pmic-arb: add a print in cleanup_irq To: Stephen Boyd , , CC: , , Abhijeet Dharmapurikar References: <1631860384-26608-1-git-send-email-quic_fenglinw@quicinc.com> <1631860384-26608-2-git-send-email-quic_fenglinw@quicinc.com> <163406078422.936959.12726677103787301939@swboyd.mtv.corp.google.com> <6c91a6ad-0ff2-a431-138a-2ec83f2bfa74@quicinc.com> <163415372158.936959.16897606198271075227@swboyd.mtv.corp.google.com> <163426014715.936959.6136985763712059359@swboyd.mtv.corp.google.com> From: Fenglin Wu Message-ID: <83fa65c8-3442-ee26-22ed-e26b013cca14@quicinc.com> Date: Fri, 15 Oct 2021 09:27:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <163426014715.936959.6136985763712059359@swboyd.mtv.corp.google.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 10/15/2021 9:09 AM, Stephen Boyd wrote: > Quoting Fenglin Wu (2021-10-13 19:26:55) >> On 10/14/2021 3:35 AM, Stephen Boyd wrote: >>> Quoting Fenglin Wu (2021-10-12 21:15:42) >>>> On 10/13/2021 1:46 AM, Stephen Boyd wrote: >>>>> Quoting Fenglin Wu (2021-09-16 23:32:56) >>>>>> From: Abhijeet Dharmapurikar >>>>>> >>>>>> The cleanup_irq() was meant to clear and mask interrupts that were >>>>>> left enabled in the hardware but there was no interrupt handler >>>>>> registered for it. Add an error print when it gets invoked. >>>>> Why? Don't we get the genirq spurious irq message in this scenario? >>>> Thanks for reviewing the change. >>>> >>>> No, there is no existing message printed out in this special case ( IRQ >>>> fired for not registered interrupt). >>> Ah I see so the irq doesn't have a flow handler? Shouldn't you call >>> handle_bad_irq() in this case so we get a irq descriptor print? >> In such case, the irq number is not valid and there won't be a valid >> irq_desc, hence it's not possible to call handle_bad_irq() here. > I mean handle_bad_irq() on the irqdesc for the spmi pmic arb chained > irq. Because things are not good with the chained irq. Okay, how about this, Update periph_interrupt() function with a return value, and return -EINVAL once an invalid IRQ is detected. In pmic_arb_chained_irq(), call handle_bad_irq() if periph_interrupt() returned -EINVAL.