From: Felipe Balbi <balbi@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jarrett Schultz <jaschultzms@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
Maximilian Luz <luzmaximilian@gmail.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jarrett Schultz <jaschultz@microsoft.com>
Subject: Re: [PATCH 2/3] platform: surface: Add surface xbl
Date: Fri, 29 Oct 2021 16:12:08 +0300 [thread overview]
Message-ID: <875ytgt1lm.fsf@kernel.org> (raw)
In-Reply-To: <CAHp75VcwbVh7K=UMgiJ1QpaeB_f_==K4Ewzjt5OwYcOAXqiyUw@mail.gmail.com>
Hi,
Andy Shevchenko <andy.shevchenko@gmail.com> writes:
>> >> > Capital L will be better to read and understand the
>> >> > abbreviation. Actually usually we do something like this:
>> >> >
>> >> > Extensible Boot Loader (EBL)
>> >>
>> >> nah, this is silly Andy. It's just capitalized as eXtensible Boot
>> >> Loader, very much akin to eXtensible Host Controller Interface.
>> >
>> > My point here is to have a full name followed by the abbreviation. and
>> > n(O)t in (F)ancy st(Y)le.
>>
>> too bad my patch removing acronyms from the kernel got rejects :-p
>>
>> Seriously, this is pretty pointless. You're vouching for something that
>> will just cause confusion. Every piece of internal documentation refers
>> to xbl and you want this to be renamed to ebl because it looks nicer for
>> you. Thanks, but no thanks.
>
> Maybe I was too unclear. I'm not pushing for EBL, I'm pushing for the form os
>
> "Foo bAr BullSh*t (FABS)" vs. "(F)oo b(a)r (B)ull(s)h*t".
>
> If you have x there to be capitalized, do it like "eXtensible Boot
> Loader (XBL)". Is it too hard?
Take a breather Andy, you need it. Winter sure is coming
>> >> > +static const struct attribute_group inputs_attr_group = {
>> >> > + .attrs = inputs_attrs,
>> >> > +};
>> >> > +
>> >> > +static u8 surface_xbl_readb(void __iomem *base, u32 offset)
>> >> > +{
>> >> > + return readb(base + offset);
>> >> > +}
>> >> > +
>> >> > +static u16 surface_xbl_readw(void __iomem *base, u32 offset)
>> >> > +{
>> >> > + return readw(base + offset);
>> >> > +}
>> >> >
>> >> > Either use corresponding io accessors in-line, or make first parameter
>> >> > to be sirface_xbl pointer. Otherwise these helpers useless.
>> >>
>> >> I agree with passing surface_xbl point as first parameter, but calling
>> >> the accessors pointless is a bit much. At a minimum, they make it easier
>> >> to ftrace the entire driver by simply ftracing surface_xbl_*
>> >
>> > My point is that the above seems half-baked. It's pointless to have a
>> > func(a,b) { return readl(a + b); }. It doesn't add value.
>>
>> sure it does. echo surface_xbl_* > ftrace_filter_function (or whatever
>> the filename was) it reason enough IMHO. Not to mention that these
>> little accessors will likely be optimized by the compiler.
>
> readl() will appear in the traces, no? But yeah I also was thinking
> about the weakness in your argument that the compiler can silently
> inline them anyway.
In non-debug builds, when tracers are enabled a thunk will be added for
runtime patching ;-) (IIRC)
--
balbi
next prev parent reply other threads:[~2021-10-29 13:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 21:17 [PATCH 0/3] platform: surface: Introduce Surface XBL Driver Jarrett Schultz
2021-10-28 21:17 ` [PATCH 1/3] dt-bindings: platform: microsoft: Document surface xbl Jarrett Schultz
2021-10-28 21:56 ` Rob Herring
2021-10-28 22:52 ` Bjorn Andersson
2021-10-28 21:17 ` [PATCH 2/3] platform: surface: Add " Jarrett Schultz
2021-10-28 22:43 ` Randy Dunlap
2021-10-28 23:12 ` Maximilian Luz
[not found] ` <CAHp75Vfq7ZkXytuAFhGOMGuH7_AsXcYf9O=p30e4OUx+a4jMgw@mail.gmail.com>
2021-10-29 4:45 ` Felipe Balbi
2021-10-29 8:57 ` Andy Shevchenko
2021-10-29 12:32 ` Felipe Balbi
2021-10-29 12:56 ` Andy Shevchenko
2021-10-29 13:12 ` Felipe Balbi [this message]
2021-10-29 15:02 ` Andy Shevchenko
2021-10-28 21:17 ` [PATCH 3/3] arm64: dts: qcom: surface-duo: " Jarrett Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ytgt1lm.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=agross@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=hdegoede@redhat.com \
--cc=jaschultz@microsoft.com \
--cc=jaschultzms@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).