From: Kalle Valo <kvalo@codeaurora.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-msm@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 1/5] misc: qca639x: add support for QCA639x powerup sequence
Date: Sun, 31 Jan 2021 16:18:16 +0200 [thread overview]
Message-ID: <875z3dmbpz.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <20210128175225.3102958-2-dmitry.baryshkov@linaro.org> (Dmitry Baryshkov's message of "Thu, 28 Jan 2021 20:52:21 +0300")
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes:
> Qualcomm QCA639x is a family of WiFi + Bluetooth SoCs, with BT part
> being controlled through the UART and WiFi being present on PCIe
> bus. Both blocks share common power sources. Add device driver handling
> power sequencing of QCA6390/1.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/misc/Kconfig | 12 +++
> drivers/misc/Makefile | 1 +
> drivers/misc/qcom-qca639x.c | 164 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 177 insertions(+)
> create mode 100644 drivers/misc/qcom-qca639x.c
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index e90c2524e46c..a14f67ab476c 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -255,6 +255,18 @@ config QCOM_FASTRPC
> applications DSP processor. Say M if you want to enable this
> module.
>
> +config QCOM_QCA639X
> + tristate "Qualcomm QCA639x WiFi/Bluetooth module support"
> + depends on REGULATOR && PM_GENERIC_DOMAINS
> + help
> + If you say yes to this option, support will be included for Qualcomm
> + QCA639x family of WiFi and Bluetooth SoCs. Note, this driver supports
> + only power control for this SoC, you still have to enable individual
> + Bluetooth and WiFi drivers.
> +
> + Say M here if you want to include support for QCA639x chips as a
> + module. This will build a module called "qcom-qca639x".
Is this is something you need on ARM platforms? As on x86 this is
definitely not needed, for example it's enough to load ath11k_pci to get
QCA6390 Wi-Fi working. I think the documentation should be clarified
where this QCOM_QCA639X is needed (and it's not needed on normal PCI
devices).
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-01-31 15:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 17:52 [PATCH v2 0/5] Add support for Qualcomm QCA639x chips family Dmitry Baryshkov
2021-01-28 17:52 ` [PATCH v2 1/5] misc: qca639x: add support for QCA639x powerup sequence Dmitry Baryshkov
2021-01-31 14:18 ` Kalle Valo [this message]
2021-01-28 17:52 ` [PATCH v2 2/5] arm64: qcom: dts: qrb5165-rb5: add qca6391 power device Dmitry Baryshkov
2021-01-30 3:47 ` Bjorn Andersson
2021-01-30 3:59 ` Manivannan Sadhasivam
2021-01-28 17:52 ` [PATCH v2 3/5] pcie-qcom: provide a way to power up qca6390 chip on RB5 platform Dmitry Baryshkov
[not found] ` <CAL_JsqLRn40h0K-Fze5m1LS2+raLp94LariMkUh7XtekTBT5+Q@mail.gmail.com>
2021-01-29 3:45 ` Dmitry Baryshkov
2021-01-29 21:50 ` Bjorn Helgaas
2021-01-29 22:19 ` Dmitry Baryshkov
2021-01-29 22:39 ` Bjorn Helgaas
2021-01-30 3:53 ` Bjorn Andersson
2021-01-30 16:14 ` Dmitry Baryshkov
2021-02-02 19:48 ` Bjorn Andersson
2021-02-02 21:37 ` Rob Herring
2021-02-02 21:50 ` Bjorn Andersson
2021-02-03 4:14 ` Dmitry Baryshkov
2021-01-29 23:39 ` Rob Herring
2021-06-13 18:40 ` Konrad Dybcio
2021-01-28 17:52 ` [PATCH v2 4/5] arm64: dtb: qcom: qrb5165-rb5: add bridge@0,0 to power up qca6391 chip Dmitry Baryshkov
[not found] ` <CAL_Jsq+uim_0fDsCqSjgbz-xzUEu4GAf+KOgxSd1KdrFWjhd3Q@mail.gmail.com>
2021-01-29 3:48 ` Dmitry Baryshkov
2021-01-28 17:52 ` [PATCH v2 5/5] arm64: dts: qcom: Add Bluetooth support on RB5 Dmitry Baryshkov
[not found] ` <CAL_Jsq+nNRv3KceHthgktHR1oRMs+eKWC4O7n0k78izs1aTPfA@mail.gmail.com>
2021-01-29 3:49 ` Dmitry Baryshkov
2021-02-02 6:16 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z3dmbpz.fsf@tynnyri.adurom.net \
--to=kvalo@codeaurora.org \
--cc=agross@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).