From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34C34C04AB5 for ; Mon, 3 Jun 2019 15:52:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08FA7248ED for ; Mon, 3 Jun 2019 15:52:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oBApCORx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728659AbfFCPwx (ORCPT ); Mon, 3 Jun 2019 11:52:53 -0400 Received: from mail-it1-f194.google.com ([209.85.166.194]:36470 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729655AbfFCPwu (ORCPT ); Mon, 3 Jun 2019 11:52:50 -0400 Received: by mail-it1-f194.google.com with SMTP id e184so27378523ite.1 for ; Mon, 03 Jun 2019 08:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GpFzEpr1ezfAmPIG1U95ynZ5Rh+k9URxN/mncQwbUQk=; b=oBApCORx2TVaSa216x4E5fWeNliHwLcHKgzvAiwAQj8dhZ1r9t956omEZF1QQfS9Qn L4GYcQEFUI2hVJ5He6pUDQDUNyPznBtxjBYhYgWqf0fpncq8kFEDs/+HOYrnAP6r9obM T9qxjp1J8zHbaJiaXN6PDoLBGISs83YZyJ8Usa30SQiYXgwfXXGbF1s6FibOLcl34SKl vmBvNMOVYyW8K4XlWvfPG76wjQWDeeqOPEjNgfG57tXvxOLi3EN0fasmt5IWrPSqUfvx 8DX+S2kyo+AAwLnSKCV0MFxSNOmOYqzTkLSHwEUJsGuBY6OmAel+brYjn8OUNx7Xym6d +xdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GpFzEpr1ezfAmPIG1U95ynZ5Rh+k9URxN/mncQwbUQk=; b=YMa82YTTLaQee/ihNWJDcIhHQWMXUFKulLN8f5ztbogp5gH7M/ZElw8m7oM8noxRLQ XLDTVYJ1W130qz0DzQDSFf3CkTiW/2Gjscjb46J2ZAm+EBn1PPdHUMtqP89H3BzVRljZ jbsLkSZnHjT2nxVB+u3uk/uP7GjeERyR0xoVNlcATrIM/j6iMpshUNBCtJApnfPqJaPw GXVmIIzDf3Qi1ek70NKM2+J97qFsWmfbaPZoka6gUprbnN4LRkkDfMUnb8TTHI2qqrTI el/ozSC63CcXoRg9IPlskQaikrlBNXWNhOWLAcKTL+xOEE5e8D1i3EhpTU5hxM+YlHuH ximQ== X-Gm-Message-State: APjAAAUnRQNvnwc1L3+lXdnsUMtshJXM2H7yREHsaNYPlZGZd45jzcgd BQbFup+9TW1FTmWayk0hM88bOqPP5to= X-Google-Smtp-Source: APXvYqzo9/FdjdMy/rm+ux/zzuCDzs64hnhuS0f9Cbu5oq0R0BChyY/kjFKdvtNpy1Rib9l/GhHFOQ== X-Received: by 2002:a24:e943:: with SMTP id f64mr17241456ith.32.1559577169293; Mon, 03 Jun 2019 08:52:49 -0700 (PDT) Received: from [172.22.22.26] (c-71-195-29-92.hsd1.mn.comcast.net. [71.195.29.92]) by smtp.googlemail.com with ESMTPSA id j23sm2301492ioo.6.2019.06.03.08.52.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 08:52:48 -0700 (PDT) Subject: Re: [PATCH v2 00/17] net: introduce Qualcomm IPA driver To: Dan Williams , Arnd Bergmann Cc: David Miller , Bjorn Andersson , Ilias Apalodimas , evgreen@chromium.org, Ben Chan , Eric Caruso , cpratapa@codeaurora.org, syadagir@codeaurora.org, Subash Abhinov Kasiviswanathan , abhishek.esse@gmail.com, Networking , DTML , Linux Kernel Mailing List , linux-soc@vger.kernel.org, Linux ARM , linux-arm-msm@vger.kernel.org References: <20190531035348.7194-1-elder@linaro.org> <065c95a8-7b17-495d-f225-36c46faccdd7@linaro.org> <3b1e12b145a273dd3ded2864d976bdc5fa90e68a.camel@redhat.com> From: Alex Elder Message-ID: <87f98f81-8f77-3bc5-374c-f498e07cb1bd@linaro.org> Date: Mon, 3 Jun 2019 10:52:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <3b1e12b145a273dd3ded2864d976bdc5fa90e68a.camel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 6/3/19 9:54 AM, Dan Williams wrote: >> To be perfectly honest, at first I thought having IPA use rmnet >> was a cargo cult thing like Dan suggested, because I didn't see > To be clear I only meant cargo-culting the naming, not any > functionality. Clearly IPA/rmnet/QMAP are pretty intimately connected > at this point. But this goes back to whether IPA needs a netdev itself > or whether you need an rmnet device created on top. If the former then > I'd say no cargo-culting, if the later then it's a moot point because > the device name will be rmnet%d anyway. OK I thought you weren't sure why rmnet was a layer at all. As I said, I didn't have a very good understanding of why it was even needed when I first started working on this. I can't (or won't) comment right now on whether IPA needs its own netdev for rmnet to use. The IPA endpoints used for the modem network interfaces are enabled when the netdev is opened and disabled when closed. Outside of that, TX and RX are pretty much immediately passed through to the layer below or above. IPA currently has no other net device operations. -Alex