From: Felipe Balbi <balbi@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Felipe Balbi <felipe.balbi@microsoft.com>
Subject: Re: [PATCH] arm64: dts: qcom: add initial device-tree for Microsoft Surface Duo
Date: Fri, 28 May 2021 15:03:11 +0300 [thread overview]
Message-ID: <87v9739ibk.fsf@kernel.org> (raw)
In-Reply-To: <874kenb2p7.fsf@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]
Felipe Balbi <balbi@kernel.org> writes:
> Bjorn Andersson <bjorn.andersson@linaro.org> writes:
>
>> On Tue 11 May 03:07 CDT 2021, Felipe Balbi wrote:
>>> Bjorn Andersson <bjorn.andersson@linaro.org> writes:
>>> >> diff --git a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
>> [..]
>>> >> +&remoteproc_adsp {
>>> >> + status = "okay";
>>> >> + firmware-name = "qcom/sm8150/adsp.mdt";
>>> >
>>> > For platforms where we have a Dragonboard or similar we push the
>>> > test-signed firmware to qcom/<platform>/. I presume that the Duo
>>> > wouldn't run on the test-signed firmware.
>>> >
>>> > So I think it's better to make this qcom/sm8150/ms-duo/adsp.mdt...from
>>> > the start.
>>>
>>> ms-duo would look odd. How about qcom/sm8150/microsoft/adsp.mdt?
>>>
>>
>> Sounds good to me.
>>
>> I do prefer using the non-split firmware package though (i.e. .mbn), if
>> you don't have it you can repack the .mdt + .bNN files using
>>
>> https://github.com/andersson/pil-squasher
>
> Cool, I'll check if we have the non-split version and rename the FW
> files.
doesn't seem like pil-squasher works with our slpi image. Gives me a
0-byte image :-)
I would rather not touch the binaries if I can avoid it, though. Is this
a strong requirement to use mbn rather than mdt?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
next prev parent reply other threads:[~2021-05-28 12:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 12:05 [PATCH] arm64: dts: qcom: add initial device-tree for Microsoft Surface Duo Felipe Balbi
2021-05-11 4:43 ` Bjorn Andersson
2021-05-11 8:07 ` Felipe Balbi
2021-05-25 17:32 ` Bjorn Andersson
2021-05-28 9:57 ` Felipe Balbi
2021-05-28 12:03 ` Felipe Balbi [this message]
2021-05-29 16:56 ` Bjorn Andersson
2021-06-03 10:19 ` Felipe Balbi
2021-05-18 20:57 ` Konrad Dybcio
2021-05-28 10:00 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9739ibk.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=felipe.balbi@microsoft.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).