From: Alex Elder <elder@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>,
phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
Pavel Dubrova <pashadubrova@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>, Arnd Bergmann <arnd@arndb.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thara Gopinath <thara.gopinath@linaro.org>,
Elliot Berman <eberman@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] firmware: qcom: scm: Remove reassignment to desc following initializer
Date: Wed, 8 Dec 2021 07:30:20 -0600 [thread overview]
Message-ID: <88091904-3430-d717-75a4-5928566b79b4@linaro.org> (raw)
In-Reply-To: <20211208083423.22037-2-marijn.suijten@somainline.org>
On 12/8/21 2:34 AM, Marijn Suijten wrote:
> Member assignments to qcom_scm_desc were moved into struct initializers
> in 57d3b816718c ("firmware: qcom_scm: Remove thin wrappers") including
> the case in qcom_scm_iommu_secure_ptbl_init, except that the - now
> duplicate - assignment to desc was left in place. While not harmful,
> remove this unnecessary extra reassignment.
>
> Fixes: 57d3b816718c ("firmware: qcom_scm: Remove thin wrappers")
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Looks good.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> drivers/firmware/qcom_scm.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 7db8066b19fd..3f67bf774821 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -749,12 +749,6 @@ int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare)
> };
> int ret;
>
> - desc.args[0] = addr;
> - desc.args[1] = size;
> - desc.args[2] = spare;
> - desc.arginfo = QCOM_SCM_ARGS(3, QCOM_SCM_RW, QCOM_SCM_VAL,
> - QCOM_SCM_VAL);
> -
> ret = qcom_scm_call(__scm->dev, &desc, NULL);
>
> /* the pg table has been initialized already, ignore the error */
>
next prev parent reply other threads:[~2021-12-08 13:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 8:34 [PATCH 0/3] firmware: qcom: scm: Add IOMMU pool size and Marijn Suijten
2021-12-08 8:34 ` [PATCH 1/3] firmware: qcom: scm: Remove reassignment to desc following initializer Marijn Suijten
2021-12-08 13:30 ` Alex Elder [this message]
2021-12-08 8:34 ` [PATCH 2/3] firmware: qcom: scm: Add function to set the maximum IOMMU pool size Marijn Suijten
2021-12-08 13:30 ` Alex Elder
2021-12-08 23:44 ` Marijn Suijten
2021-12-10 16:28 ` AngeloGioacchino Del Regno
2021-12-10 21:44 ` Alex Elder
2021-12-08 8:34 ` [PATCH 3/3] firmware: qcom: scm: Add function to set IOMMU pagetable addressing Marijn Suijten
2021-12-08 13:30 ` Alex Elder
2022-02-04 18:35 ` [PATCH 0/3] firmware: qcom: scm: Add IOMMU pool size and Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88091904-3430-d717-75a4-5928566b79b4@linaro.org \
--to=elder@linaro.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=eberman@codeaurora.org \
--cc=jami.kettunen@somainline.org \
--cc=konrad.dybcio@somainline.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=pashadubrova@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=thara.gopinath@linaro.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).