From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C280C4332B for ; Thu, 4 Feb 2021 14:17:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A16464F51 for ; Thu, 4 Feb 2021 14:17:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236477AbhBDORc (ORCPT ); Thu, 4 Feb 2021 09:17:32 -0500 Received: from m-r1.th.seeweb.it ([5.144.164.170]:35075 "EHLO m-r1.th.seeweb.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236637AbhBDOR0 (ORCPT ); Thu, 4 Feb 2021 09:17:26 -0500 Received: from [192.168.1.101] (abaf219.neoplus.adsl.tpnet.pl [83.6.169.219]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id E97C71F881; Thu, 4 Feb 2021 15:16:24 +0100 (CET) Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits To: Amit Pundir , Andy Gross , Bjorn Andersson , Rob Herring , John Stultz , Sumit Semwal Cc: linux-arm-msm , dt , lkml , phone-devel@vger.kernel.org References: <1612426177-6611-1-git-send-email-amit.pundir@linaro.org> From: Konrad Dybcio Message-ID: <889e6ed8-133a-9416-be3b-5b2a97ea7fbb@somainline.org> Date: Thu, 4 Feb 2021 15:16:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <1612426177-6611-1-git-send-email-amit.pundir@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi! >vreg_l14a_1p88: ldo14 { >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; Should probably be renamed to vreg_l14a_1p8 then. >+ ports { >+ port@1 { >+ endpoint { >+ remote-endpoint = <&tianma_nt36672a_in_0>; >+ data-lanes = <0 1 2 3>; >+ }; >+ }; >+ }; The endpoint has a label, you can simply use &dsi0_out {};. >+ vddpos-supply = <&lab>; >+ vddneg-supply = <&ibb>; With Angelo's latest series [1] merged in, I reckon you should explicitly configure lab/ibb (like in [2]), as wrong settings (which CAN BE SET BY THE BOOTLOADER in some instances!!) can lead to hardware damage. Konrad [1] https://lore.kernel.org/linux-arm-msm/20210119174421.226541-1-angelogioacchino.delregno@somainline.org/ [2] https://github.com/SoMainline/linux/commit/4f4853b2e252b5f9d03e90119110aac80258fc53