From: Hemant Kumar <hemantk@codeaurora.org>
To: Loic Poulain <loic.poulain@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: Re: [PATCH v7 1/4] bus: mhi: core: Add helper API to return number of free TREs
Date: Wed, 21 Oct 2020 10:55:00 -0700 [thread overview]
Message-ID: <891914f1-13f2-abf8-46a6-d52218d67094@codeaurora.org> (raw)
In-Reply-To: <CAMZdPi-SY-r2H7RBLKoNk9yfu5umrrwYMr0ckJoxSx-iqYXdQg@mail.gmail.com>
Hi Loic,
On 10/21/20 9:51 AM, Loic Poulain wrote:
> On Wed, 21 Oct 2020 at 18:25, Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org> wrote:
>>
>> On Wed, Oct 21, 2020 at 05:43:14PM +0200, Loic Poulain wrote:
>>> On Wed, 21 Oct 2020 at 17:27, Manivannan Sadhasivam <
>>> manivannan.sadhasivam@linaro.org> wrote:
>>>
>>>> On Fri, Oct 16, 2020 at 09:04:14PM -0700, Hemant Kumar wrote:
>>>>> Introduce mhi_get_free_desc_count() API to return number
>>>>
>>>
>>> Would it not be a good idea to have naming aligned with other methods?
>>> Like mhi_queue_num_free() or mhi_queue_no_free_elem...
>>>
>>
>> 'queue_num_free' doesn't sound like getting the number of available
>> descriptors...
>
> Right, TBH, just wanted the function to start with mhi_queue since
> it's about getting info about remaining size of the DL or UL 'virtual
> queue'. But AFAIU, this is the number of available ring elements that
> is returned here, not the number of transfer descriptors (that can be
> composed of one or more ring elements), so maybe
> mhi_queue_num_free_elements or something similar, I don't want to be
mhi_get_free_desc_count is the number of TREs available which queue APIs
can use to queue an transfer ring element. My only concern is if we get
confused with the name mhi_queue_ part of as number of TREs queued ?
Transfer ring element is indeed a transfer descriptor.
> picky here.
>
> Regards,
> Loic
>
Thanks,
Hemant
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-10-21 17:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 4:04 [PATCH v7 0/4] userspace MHI client interface driver Hemant Kumar
2020-10-17 4:04 ` [PATCH v7 1/4] bus: mhi: core: Add helper API to return number of free TREs Hemant Kumar
2020-10-21 15:27 ` Manivannan Sadhasivam
[not found] ` <CAMZdPi8xcsrKx2eV5da98fsGt2zO3f6ARMz7WJsyDSb3CnM0FA@mail.gmail.com>
2020-10-21 16:25 ` Manivannan Sadhasivam
2020-10-21 16:51 ` Loic Poulain
2020-10-21 17:55 ` Hemant Kumar [this message]
2020-10-17 4:04 ` [PATCH v7 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file Hemant Kumar
2020-10-21 15:23 ` Manivannan Sadhasivam
2020-10-17 4:04 ` [PATCH v7 3/4] docs: Add documentation for userspace client interface Hemant Kumar
2020-10-21 15:28 ` Jeffrey Hugo
2020-10-21 17:46 ` Hemant Kumar
2020-10-22 3:04 ` Jeffrey Hugo
2020-10-17 4:04 ` [PATCH v7 4/4] bus: mhi: Add userspace client interface driver Hemant Kumar
2020-10-17 7:32 ` kernel test robot
2020-10-21 16:11 ` Manivannan Sadhasivam
2020-10-21 17:43 ` Hemant Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=891914f1-13f2-abf8-46a6-d52218d67094@codeaurora.org \
--to=hemantk@codeaurora.org \
--cc=bbhatt@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).