* [PATCH] arm64: dts: qcom: pm8994: Add resin node to PON
@ 2020-12-29 12:47 Yassine Oudjana
2021-02-02 22:56 ` Bjorn Andersson
0 siblings, 1 reply; 4+ messages in thread
From: Yassine Oudjana @ 2020-12-29 12:47 UTC (permalink / raw)
To: agross, bjorn.andersson, linux-arm-msm
From: Yassine Oudjana <y.oudjana@protonmail.com>
Date: Sun, 27 Dec 2020 21:23:40 +0400
Add resin as a child node of PON.
Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
---
arch/arm64/boot/dts/qcom/pm8994.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pm8994.dtsi b/arch/arm64/boot/dts/qcom/pm8994.dtsi
index 5ffdf37d8e31..334774a38602 100644
--- a/arch/arm64/boot/dts/qcom/pm8994.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8994.dtsi
@@ -58,6 +58,14 @@ pwrkey {
linux,code = <KEY_POWER>;
};
+ resin {
+ compatible = "qcom,pm8941-resin";
+ interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
+ debounce = <15625>;
+ bias-pull-up;
+ linux,code = <KEY_VOLUMEDOWN>;
+ };
+
};
pm8994_temp: temp-alarm@2400 {
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: pm8994: Add resin node to PON
2020-12-29 12:47 [PATCH] arm64: dts: qcom: pm8994: Add resin node to PON Yassine Oudjana
@ 2021-02-02 22:56 ` Bjorn Andersson
2021-02-05 4:51 ` Yassine Oudjana
0 siblings, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2021-02-02 22:56 UTC (permalink / raw)
To: Yassine Oudjana; +Cc: agross, linux-arm-msm
On Tue 29 Dec 06:47 CST 2020, Yassine Oudjana wrote:
> From: Yassine Oudjana <y.oudjana@protonmail.com>
> Date: Sun, 27 Dec 2020 21:23:40 +0400
>
> Add resin as a child node of PON.
>
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> ---
> arch/arm64/boot/dts/qcom/pm8994.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8994.dtsi b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> index 5ffdf37d8e31..334774a38602 100644
> --- a/arch/arm64/boot/dts/qcom/pm8994.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> @@ -58,6 +58,14 @@ pwrkey {
> linux,code = <KEY_POWER>;
> };
>
> + resin {
> + compatible = "qcom,pm8941-resin";
> + interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
> + debounce = <15625>;
> + bias-pull-up;
> + linux,code = <KEY_VOLUMEDOWN>;
Is resin always volume down?
Also this node is already defined in apq8096-db820c.dtsi, so how about
moving the common properties here, but leave it status = "disabled" and
then in the device specific file make it status = okay?
Regards,
Bjorn
> + };
> +
> };
>
> pm8994_temp: temp-alarm@2400 {
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: pm8994: Add resin node to PON
2021-02-02 22:56 ` Bjorn Andersson
@ 2021-02-05 4:51 ` Yassine Oudjana
2021-02-05 5:47 ` Bjorn Andersson
0 siblings, 1 reply; 4+ messages in thread
From: Yassine Oudjana @ 2021-02-05 4:51 UTC (permalink / raw)
To: Bjorn Andersson; +Cc: agross, linux-arm-msm
On Wednesday, February 3, 2021 2:56 AM, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> On Tue 29 Dec 06:47 CST 2020, Yassine Oudjana wrote:
>
> > From: Yassine Oudjana y.oudjana@protonmail.com
> > Date: Sun, 27 Dec 2020 21:23:40 +0400
> > Add resin as a child node of PON.
> >
> > Signed-off-by: Yassine Oudjana y.oudjana@protonmail.com
> >
> > --------------------------------------------------------
> >
> > arch/arm64/boot/dts/qcom/pm8994.dtsi | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> > diff --git a/arch/arm64/boot/dts/qcom/pm8994.dtsi b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> > index 5ffdf37d8e31..334774a38602 100644
> > --- a/arch/arm64/boot/dts/qcom/pm8994.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> > @@ -58,6 +58,14 @@ pwrkey {
> > linux,code = <KEY_POWER>;
> > };
> >
> > - resin {
> >
> >
> > - compatible = "qcom,pm8941-resin";
> >
> >
> > - interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
> >
> >
> > - debounce = <15625>;
> >
> >
> > - bias-pull-up;
> >
> >
> > - linux,code = <KEY_VOLUMEDOWN>;
> >
> >
>
> Is resin always volume down?
I'm not sure, but I haven't found a device that uses it and sets it as anything else.
> Also this node is already defined in apq8096-db820c.dtsi, so how about
> moving the common properties here, but leave it status = "disabled" and
> then in the device specific file make it status = okay?
Sounds good. So have everything other than linux,code defined there, then
add status = "disabled" and a label to it?
> Regards,
> Bjorn
>
> > - };
> >
> >
> > - };
> >
> > pm8994_temp: temp-alarm@2400 {
> >
> >
> >
> > --
> > 2.29.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: pm8994: Add resin node to PON
2021-02-05 4:51 ` Yassine Oudjana
@ 2021-02-05 5:47 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2021-02-05 5:47 UTC (permalink / raw)
To: Yassine Oudjana; +Cc: agross, linux-arm-msm
On Thu 04 Feb 22:51 CST 2021, Yassine Oudjana wrote:
> On Wednesday, February 3, 2021 2:56 AM, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> > On Tue 29 Dec 06:47 CST 2020, Yassine Oudjana wrote:
> >
> > > From: Yassine Oudjana y.oudjana@protonmail.com
> > > Date: Sun, 27 Dec 2020 21:23:40 +0400
> > > Add resin as a child node of PON.
> > >
> > > Signed-off-by: Yassine Oudjana y.oudjana@protonmail.com
> > >
> > > --------------------------------------------------------
> > >
> > > arch/arm64/boot/dts/qcom/pm8994.dtsi | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > > diff --git a/arch/arm64/boot/dts/qcom/pm8994.dtsi b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> > > index 5ffdf37d8e31..334774a38602 100644
> > > --- a/arch/arm64/boot/dts/qcom/pm8994.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> > > @@ -58,6 +58,14 @@ pwrkey {
> > > linux,code = <KEY_POWER>;
> > > };
> > >
> > > - resin {
> > >
> > >
> > > - compatible = "qcom,pm8941-resin";
> > >
> > >
> > > - interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
> > >
> > >
> > > - debounce = <15625>;
> > >
> > >
> > > - bias-pull-up;
> > >
> > >
> > > - linux,code = <KEY_VOLUMEDOWN>;
> > >
> > >
> >
> > Is resin always volume down?
>
> I'm not sure, but I haven't found a device that uses it and sets it as anything else.
>
> > Also this node is already defined in apq8096-db820c.dtsi, so how about
> > moving the common properties here, but leave it status = "disabled" and
> > then in the device specific file make it status = okay?
>
> Sounds good. So have everything other than linux,code defined there, then
> add status = "disabled" and a label to it?
>
Sounds good to me.
Thanks,
Bjorn
> > Regards,
> > Bjorn
> >
> > > - };
> > >
> > >
> > > - };
> > >
> > > pm8994_temp: temp-alarm@2400 {
> > >
> > >
> > >
> > > --
> > > 2.29.2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-05 5:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-29 12:47 [PATCH] arm64: dts: qcom: pm8994: Add resin node to PON Yassine Oudjana
2021-02-02 22:56 ` Bjorn Andersson
2021-02-05 4:51 ` Yassine Oudjana
2021-02-05 5:47 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).