From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
daniel@ffwll.ch, airlied@linux.ie, alexander.deucher@amd.com,
christian.koenig@amd.com, liviu.dudau@arm.com,
brian.starkey@arm.com, sam@ravnborg.org, bbrezillon@kernel.org,
nicolas.ferre@microchip.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, stefan@agner.ch, alison.wang@nxp.com,
patrik.r.jakobsson@gmail.com, anitha.chrisanthus@intel.com,
robdclark@gmail.com, edmund.j.dea@intel.com, sean@poorly.run,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, jyri.sarha@iki.fi
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH 10/14] drm/tidss: Convert to Linux IRQ interfaces
Date: Thu, 29 Jul 2021 10:02:12 +0300 [thread overview]
Message-ID: <8b4895f2-b4db-4ce7-440f-3408af56cc0d@ideasonboard.com> (raw)
In-Reply-To: <20210727182721.17981-11-tzimmermann@suse.de>
On 27/07/2021 21:27, Thomas Zimmermann wrote:
> Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's
> IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers
> don't benefit from using it.
>
> DRM IRQ callbacks are now being called directly or inlined.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/tidss/tidss_drv.c | 15 +++++----------
> drivers/gpu/drm/tidss/tidss_drv.h | 2 ++
> drivers/gpu/drm/tidss/tidss_irq.c | 27 ++++++++++++++++++++++++---
> drivers/gpu/drm/tidss/tidss_irq.h | 4 +---
> 4 files changed, 32 insertions(+), 16 deletions(-)
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Works fine on AM6 EVM. Some cleanups can be done in tidss_irq_install(),
but those can be done later.
Tomi
next prev parent reply other threads:[~2021-07-29 7:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 18:27 [PATCH 00/14] drm: Make DRM's IRQ helpers legacy Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 01/14] drm/amdgpu: Convert to Linux IRQ interfaces Thomas Zimmermann
2021-07-28 10:27 ` Christian König
2021-07-28 14:03 ` Alex Deucher
2021-08-02 8:43 ` Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 02/14] drm/arm/hdlcd: " Thomas Zimmermann
[not found] ` <YQFcOU79/lpbt1VW@ravnborg.org>
2021-07-28 18:15 ` Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 03/14] drm/atmel-hlcdc: " Thomas Zimmermann
[not found] ` <YQFi96yaYbTG4OO7@ravnborg.org>
2021-07-28 15:11 ` Dan.Sneddon
[not found] ` <YQF7bKyeup8n3awU@ravnborg.org>
2021-07-28 17:50 ` Dan.Sneddon
[not found] ` <YQGdxtV0BGZ8VOpm@ravnborg.org>
2021-07-28 18:17 ` Thomas Zimmermann
2021-07-28 18:46 ` Dan.Sneddon
[not found] ` <YQGrMH36Udg3eKQY@ravnborg.org>
2021-07-28 19:19 ` Dan.Sneddon
[not found] ` <YQG5+/9lPexU3Dn3@ravnborg.org>
2021-07-29 19:18 ` Thomas Zimmermann
2021-07-29 19:21 ` Thomas Zimmermann
2021-07-29 19:24 ` Dan.Sneddon
2021-07-29 19:32 ` Thomas Zimmermann
[not found] ` <YQMF8X7gwKE/c2/R@ravnborg.org>
2021-07-29 19:55 ` Dan.Sneddon
2021-07-30 8:31 ` Thomas Zimmermann
2021-07-30 18:10 ` Dan.Sneddon
2021-07-28 18:19 ` Dan.Sneddon
2021-07-27 18:27 ` [PATCH 04/14] drm/fsl-dcu: " Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 05/14] drm/gma500: " Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 06/14] drm/kmb: " Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 07/14] drm/msm: " Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 08/14] drm/mxsfb: " Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 09/14] drm/radeon: " Thomas Zimmermann
2021-08-02 15:27 ` Alex Deucher
2021-07-27 18:27 ` [PATCH 10/14] drm/tidss: " Thomas Zimmermann
2021-07-29 7:02 ` Tomi Valkeinen [this message]
2021-07-27 18:27 ` [PATCH 11/14] drm/tilcdc: " Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 12/14] drm/vc4: " Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 13/14] drm: Remove unused devm_drm_irq_install() Thomas Zimmermann
2021-07-27 18:27 ` [PATCH 14/14] drm: IRQ midlayer is now legacy Thomas Zimmermann
[not found] ` <YQBVyuPuf9InsY7g@ravnborg.org>
2021-07-28 5:19 ` [PATCH 00/14] drm: Make DRM's IRQ helpers legacy Thomas Zimmermann
[not found] ` <YQWbWjV5TYzp+5C4@ravnborg.org>
2021-08-01 19:56 ` Thomas Zimmermann
[not found] ` <YQcDCVuSM2kLbQcI@ravnborg.org>
2021-08-02 8:42 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b4895f2-b4db-4ce7-440f-3408af56cc0d@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alison.wang@nxp.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=anitha.chrisanthus@intel.com \
--cc=bbrezillon@kernel.org \
--cc=brian.starkey@arm.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=edmund.j.dea@intel.com \
--cc=freedreno@lists.freedesktop.org \
--cc=jyri.sarha@iki.fi \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=patrik.r.jakobsson@gmail.com \
--cc=robdclark@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).