From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Acayan <mailingradian@gmail.com>,
Melody Olvera <quic_molvera@quicinc.com>
Subject: Re: [PATCH 1/5] dt-bindings: dma: qcom: gpi: use sm6350 fallback
Date: Mon, 17 Oct 2022 17:35:32 -0400 [thread overview]
Message-ID: <8bf0046c-51a9-8244-e355-78dd2725944b@linaro.org> (raw)
In-Reply-To: <Y00wWnkcLKaticjl@matsya>
On 17/10/2022 06:37, Vinod Koul wrote:
> On 15-10-22, 10:04, Krzysztof Kozlowski wrote:
>> Several devices like SM6350, SM8150 and SC7280 are actually compatible,
>> so use one compatible fallback for all of them.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
>> index 750b40c32213..0c2894498845 100644
>> --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
>> +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
>> @@ -20,12 +20,14 @@ properties:
>> compatible:
>> oneOf:
>> - enum:
>> - - qcom,sc7280-gpi-dma
>> - qcom,sdm845-gpi-dma
>> - qcom,sm6350-gpi-dma
>> - - qcom,sm8350-gpi-dma
>> - - qcom,sm8450-gpi-dma
>> -
>> + - items:
>> + - enum:
>> + - qcom,sc7280-gpi-dma
>> + - qcom,sm8350-gpi-dma
>> + - qcom,sm8450-gpi-dma
>> + - const: qcom,sm6350-gpi-dma
>
> I think it makes sense but can we document this in binding as well that
> why people should use these two compatibles. I am fine with this being
> comments here..
It is kind of implied (and maybe obvious) from the bindings - a list of
two items, one enum and one fallback compatible.
We usually do not document such patterns in the bindings with comments
for that reason. If you insist, I can add it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-17 21:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 14:04 [PATCH 0/5] dma/arm64: qcom: use one compatible also for 0x10000 offset Krzysztof Kozlowski
2022-10-15 14:04 ` [PATCH 1/5] dt-bindings: dma: qcom: gpi: use sm6350 fallback Krzysztof Kozlowski
2022-10-17 10:37 ` Vinod Koul
2022-10-17 21:35 ` Krzysztof Kozlowski [this message]
2022-10-17 18:33 ` Rob Herring
2022-10-17 21:10 ` Richard Acayan
2022-10-17 21:34 ` Krzysztof Kozlowski
2022-10-15 14:04 ` [PATCH 2/5] dmaengine: qcom: gpi: document preferred SM6350 binding Krzysztof Kozlowski
2022-10-17 21:23 ` Richard Acayan
2022-10-17 21:36 ` Krzysztof Kozlowski
2022-10-17 22:00 ` Richard Acayan
2022-10-17 22:12 ` Krzysztof Kozlowski
2022-10-18 0:37 ` Richard Acayan
2022-10-15 14:04 ` [PATCH 3/5] arm64: dts: qcom: sc7280: Add GPI DMA compatible fallback Krzysztof Kozlowski
2022-10-18 13:45 ` Neil Armstrong
2022-10-15 14:04 ` [PATCH 4/5] arm64: dts: qcom: sm8350: " Krzysztof Kozlowski
2022-10-18 13:45 ` Neil Armstrong
2022-10-15 14:04 ` [PATCH 5/5] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski
2022-10-18 13:45 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bf0046c-51a9-8244-e355-78dd2725944b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=quic_molvera@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).