From: Raju P L S S S N <rplsssn@codeaurora.org>
To: Doug Anderson <dianders@chromium.org>, Lina Iyer <ilina@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
msivasub@codeaurora.org, mkshah@codeaurora.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Evan Green <evgreen@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH v8 10/10] drivers: qcom: rpmh-rsc: allow active requests from wake TCS
Date: Wed, 23 May 2018 19:51:05 +0530 [thread overview]
Message-ID: <8d7f1fd2-1429-577f-309e-ffff8b7824bb@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=V519eo20KpoGMm_deJ1Zv5r60bX9xGgcjtSeZPrychgw@mail.gmail.com>
Hi,
On 5/12/2018 1:47 AM, Doug Anderson wrote:
> Hi,
>
> On Wed, May 9, 2018 at 10:01 AM, Lina Iyer <ilina@codeaurora.org> wrote:
>> Some RSCs may only have sleep and wake TCS, i.e, there is no dedicated
>> TCS for active mode request, but drivers may still want to make active
>> requests from these RSCs. In such cases re-purpose the wake TCS to send
>> active state requests.
>>
>> The requirement for this is that the driver is aware that the wake TCS
>> is being repurposed to send active request, hence the sleep and wake
>> TCSes be invalidated before the active request is sent.
>>
>> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>> ---
>> drivers/soc/qcom/rpmh-rsc.c | 18 +++++++++++++++++-
>> 1 file changed, 17 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
>> index 68c25ebbbe09..369b9b3eedc5 100644
>> --- a/drivers/soc/qcom/rpmh-rsc.c
>> +++ b/drivers/soc/qcom/rpmh-rsc.c
>> @@ -153,6 +153,7 @@ static struct tcs_group *get_tcs_for_msg(struct rsc_drv *drv,
>> const struct tcs_request *msg)
>> {
>> int type;
>> + struct tcs_group *tcs;
>>
>> switch (msg->state) {
>> case RPMH_ACTIVE_ONLY_STATE:
>> @@ -168,7 +169,22 @@ static struct tcs_group *get_tcs_for_msg(struct rsc_drv *drv,
>> return ERR_PTR(-EINVAL);
>> }
>>
>> - return get_tcs_of_type(drv, type);
>> + /*
>> + * If we are making an active request on a RSC that does not have a
>> + * dedicated TCS for active state use, then re-purpose a wake TCS to
>> + * send active votes.
>> + * NOTE: The driver must be aware that this RSC does not have a
>> + * dedicated AMC, and therefore would invalidate the sleep and wake
>> + * TCSes before making an active state request.
>> + */
>> + tcs = get_tcs_of_type(drv, type);
>> + if (msg->state == RPMH_ACTIVE_ONLY_STATE && IS_ERR(tcs)) {
>> + tcs = get_tcs_of_type(drv, WAKE_TCS);
>> + if (!IS_ERR(tcs))
>> + rpmh_rsc_invalidate(drv);
>
> I noticed that rpmh_rsc_invalidate() can return -EAGAIN. Do you need
> to deal with that here?
Yes. will add the check here.
Thanks,
Raju.
>
>
> -Doug
>
prev parent reply other threads:[~2018-05-23 14:21 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 17:01 [PATCH v8 00/10] drivers/qcom: add RPMH communication support Lina Iyer
2018-05-09 17:01 ` [PATCH v8 01/10] drivers: qcom: rpmh-rsc: add RPMH controller for QCOM SoCs Lina Iyer
2018-05-11 20:15 ` Doug Anderson
2018-05-23 12:15 ` Raju P L S S S N
2018-05-09 17:01 ` [PATCH v8 02/10] dt-bindings: introduce RPMH RSC bindings for Qualcomm SoCs Lina Iyer
2018-05-09 17:01 ` [PATCH v8 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE Lina Iyer
2018-05-09 17:49 ` Steven Rostedt
2018-05-10 15:12 ` Lina Iyer
2018-05-09 17:01 ` [PATCH v8 04/10] drivers: qcom: rpmh: add RPMH helper functions Lina Iyer
2018-05-11 20:17 ` Doug Anderson
2018-05-15 17:47 ` Lina Iyer
2018-05-15 18:22 ` Doug Anderson
2018-05-23 12:19 ` Raju P L S S S N
2018-05-09 17:01 ` [PATCH v8 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS Lina Iyer
2018-05-09 23:25 ` Matthias Kaehlcke
2018-05-10 15:15 ` Lina Iyer
2018-05-09 17:01 ` [PATCH v8 06/10] drivers: qcom: rpmh-rsc: allow invalidation of sleep/wake TCS Lina Iyer
2018-05-09 17:01 ` [PATCH v8 07/10] drivers: qcom: rpmh: cache sleep/wake state requests Lina Iyer
2018-05-11 20:18 ` Doug Anderson
2018-05-23 12:21 ` Raju P L S S S N
2018-05-09 17:01 ` [PATCH v8 08/10] drivers: qcom: rpmh: allow requests to be sent asynchronously Lina Iyer
2018-05-09 23:39 ` Matthias Kaehlcke
2018-05-11 20:16 ` Doug Anderson
2018-05-23 12:30 ` Raju P L S S S N
2018-05-09 17:01 ` [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request Lina Iyer
2018-05-09 22:03 ` Matthias Kaehlcke
2018-05-10 15:17 ` Lina Iyer
2018-05-11 20:19 ` Doug Anderson
2018-05-14 19:59 ` Lina Iyer
2018-05-15 15:52 ` Doug Anderson
2018-05-15 16:23 ` Lina Iyer
2018-05-15 16:50 ` Doug Anderson
2018-05-15 18:03 ` Lina Iyer
2018-05-15 19:52 ` Doug Anderson
2018-05-23 13:27 ` Raju P L S S S N
2018-05-30 21:48 ` Doug Anderson
2018-05-09 17:01 ` [PATCH v8 10/10] drivers: qcom: rpmh-rsc: allow active requests from wake TCS Lina Iyer
2018-05-11 20:17 ` Doug Anderson
2018-05-23 14:21 ` Raju P L S S S N [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d7f1fd2-1429-577f-309e-ffff8b7824bb@codeaurora.org \
--to=rplsssn@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=msivasub@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).