Re: [PATCH v2 4/4] arm64: dts: qcom: msm8916-alcatel-idol347: Add framebuffer support

[Konrad Dybcio <konrad.dybcio@somainline.org>]

On 30.01.2021 11:57, Vincent Knecht wrote:
> Add simple-framebuffer support and related reserved-memory block.
>
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> ---
>  .../boot/dts/qcom/msm8916-alcatel-idol347.dts | 31 +++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
> index 540b1fa4b260..e4d22cec8ff0 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
> @@ -3,6 +3,7 @@
>  /dts-v1/;
>  
>  #include "msm8916-pm8916.dtsi"
> +#include <dt-bindings/clock/qcom,gcc-msm8916.h>
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/input/input.h>
>  
> @@ -16,6 +17,36 @@ aliases {
>  
>  	chosen {
>  		stdout-path = "serial0";
> +
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		framebuffer0: framebuffer@83200000 {
> +			status = "okay";
> +			compatible = "simple-framebuffer";
> +			reg = <0x0 0x83200000 0x0 (720 * 1280 * 3)>;
> +			width = <720>;
> +			height = <1280>;
> +			stride = <(720 * 3)>;
> +			format = "r8g8b8";
> +			power-domains = <&gcc MDSS_GDSC>;
> +			clocks = <&gcc GCC_MDSS_AHB_CLK>,
> +				 <&gcc GCC_MDSS_VSYNC_CLK>,
> +				 <&gcc GCC_MDSS_AXI_CLK>,
> +				 <&gcc GCC_MDSS_MDP_CLK>,
> +				 <&gcc GCC_MDSS_BYTE0_CLK>,
> +				 <&gcc GCC_MDSS_PCLK0_CLK>,

I'm not sure about BYTE/PCLK, it used to cause issues at least on my boards, but if it works for you, I guess it's only good.


> +				 <&gcc GCC_MDSS_ESC0_CLK>,
> +				 <&xo_board>;

Fake XO seems redundant here.


> +		};
> +	};
> +
> +	reserved-memory {
> +		continuous_splash: framebuffer@83000000 {
> +			reg = <0x0 0x83000000 0x0 0x1400000>;
> +			no-map;
> +		};
>  	};
>  
>  	gpio-keys {
>

Konrad