From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 935B9C433ED for ; Thu, 6 May 2021 17:17:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E4A76112F for ; Thu, 6 May 2021 17:17:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236042AbhEFRSb (ORCPT ); Thu, 6 May 2021 13:18:31 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:42017 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236191AbhEFRSb (ORCPT ); Thu, 6 May 2021 13:18:31 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1620321452; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=sZbTSso1rQbpoLwNuweS38D/XCG6W6+Ms1mW2K4ZuG4=; b=XNV68EAM34Wf8YsmoWIvDJgx/9WHTLUlsVNNVgWL1/mcjsO1lqx3h2av7nqy1ydkbHAOyaoT B39i7hU3Y6HjJgc8gHNHpG5DUVPN1Zv0eGR30iJkJfSRqimq3TAQ2kTLUn74STWCARKBGXU0 6IcgSvHF3nNWHjX3v+zGFX6Rl1Q= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 609424ab8166b7eff7472b8e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 06 May 2021 17:17:31 GMT Sender: deesin=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D8293C43143; Thu, 6 May 2021 17:17:30 +0000 (UTC) Received: from [192.168.1.3] (unknown [122.163.131.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: deesin) by smtp.codeaurora.org (Postfix) with ESMTPSA id 79AC1C4338A; Thu, 6 May 2021 17:17:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 79AC1C4338A Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=deesin@codeaurora.org Subject: Re: [PATCH V6 2/4] rpmsg: glink: Add support to handle signals command To: bjorn.andersson@linaro.org, clew@codeaurora.org, sibis@codeaurora.org, manivannan.sadhasivam@linaro.org, mathieu.poirier@linaro.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, Arun Kumar Neelakantam , Andy Gross , Ohad Ben-Cohen References: <1620320818-2206-1-git-send-email-deesin@codeaurora.org> <1593182819-30747-3-git-send-email-deesin@codeaurora.org> From: Deepak Kumar Singh Message-ID: <9095e858-61c3-1115-dc59-d290d81a4b4b@codeaurora.org> Date: Thu, 6 May 2021 22:47:17 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1593182819-30747-3-git-send-email-deesin@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Please ignore this instance. Wrongly pushed. On 5/6/2021 10:36 PM, Deepak Kumar Singh wrote: > From: Arun Kumar Neelakantam > > Remote peripherals send signal notifications over glink with commandID 15. > > Add support to send and receive the signal command and convert the signals > from NATIVE to TIOCM while receiving and vice versa while sending. > > Signed-off-by: Chris Lew > Signed-off-by: Deepak Kumar Singh > Signed-off-by: Arun Kumar Neelakantam > --- > drivers/rpmsg/qcom_glink_native.c | 125 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 125 insertions(+) > > diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c > index 0e8a28c0..1bf3235 100644 > --- a/drivers/rpmsg/qcom_glink_native.c > +++ b/drivers/rpmsg/qcom_glink_native.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -150,6 +151,8 @@ enum { > * @intent_req_lock: Synchronises multiple intent requests > * @intent_req_result: Result of intent request > * @intent_req_comp: Completion for intent_req signalling > + * @lsigs: local side signals > + * @rsigs: remote side signals > */ > struct glink_channel { > struct rpmsg_endpoint ept; > @@ -181,6 +184,10 @@ struct glink_channel { > struct mutex intent_req_lock; > bool intent_req_result; > struct completion intent_req_comp; > + > + unsigned int lsigs; > + unsigned int rsigs; > + > }; > > #define to_glink_channel(_ept) container_of(_ept, struct glink_channel, ept) > @@ -201,9 +208,15 @@ static const struct rpmsg_endpoint_ops glink_endpoint_ops; > #define RPM_CMD_TX_DATA_CONT 12 > #define RPM_CMD_READ_NOTIF 13 > #define RPM_CMD_RX_DONE_W_REUSE 14 > +#define RPM_CMD_SIGNALS 15 > > #define GLINK_FEATURE_INTENTLESS BIT(1) > > +#define NATIVE_DTR_SIG BIT(31) > +#define NATIVE_CTS_SIG BIT(30) > +#define NATIVE_CD_SIG BIT(29) > +#define NATIVE_RI_SIG BIT(28) > + > static void qcom_glink_rx_done_work(struct work_struct *work); > > static struct glink_channel *qcom_glink_alloc_channel(struct qcom_glink *glink, > @@ -975,6 +988,76 @@ static int qcom_glink_rx_open_ack(struct qcom_glink *glink, unsigned int lcid) > return 0; > } > > +/** > + * qcom_glink_send_signals() - convert a signal cmd to wire format and transmit > + * @glink: The transport to transmit on. > + * @channel: The glink channel > + * @sigs: The signals to encode. > + * > + * Return: 0 on success or standard Linux error code. > + */ > +static int qcom_glink_send_signals(struct qcom_glink *glink, > + struct glink_channel *channel, > + u32 sigs) > +{ > + struct glink_msg msg; > + > + /* convert signals from TIOCM to NATIVE */ > + sigs &= 0x0fff; > + if (sigs & TIOCM_DTR) > + sigs |= NATIVE_DTR_SIG; > + if (sigs & TIOCM_RTS) > + sigs |= NATIVE_CTS_SIG; > + if (sigs & TIOCM_CD) > + sigs |= NATIVE_CD_SIG; > + if (sigs & TIOCM_RI) > + sigs |= NATIVE_RI_SIG; > + > + msg.cmd = cpu_to_le16(RPM_CMD_SIGNALS); > + msg.param1 = cpu_to_le16(channel->lcid); > + msg.param2 = cpu_to_le32(sigs); > + > + return qcom_glink_tx(glink, &msg, sizeof(msg), NULL, 0, true); > +} > + > +static int qcom_glink_handle_signals(struct qcom_glink *glink, > + unsigned int rcid, unsigned int signals) > +{ > + struct glink_channel *channel; > + unsigned long flags; > + u32 old; > + > + spin_lock_irqsave(&glink->idr_lock, flags); > + channel = idr_find(&glink->rcids, rcid); > + spin_unlock_irqrestore(&glink->idr_lock, flags); > + if (!channel) { > + dev_err(glink->dev, "signal for non-existing channel\n"); > + return -EINVAL; > + } > + > + old = channel->rsigs; > + > + /* convert signals from NATIVE to TIOCM */ > + if (signals & NATIVE_DTR_SIG) > + signals |= TIOCM_DSR; > + if (signals & NATIVE_CTS_SIG) > + signals |= TIOCM_CTS; > + if (signals & NATIVE_CD_SIG) > + signals |= TIOCM_CD; > + if (signals & NATIVE_RI_SIG) > + signals |= TIOCM_RI; > + signals &= 0x0fff; > + > + channel->rsigs = signals; > + > + if (channel->ept.sig_cb) { > + channel->ept.sig_cb(channel->ept.rpdev, channel->ept.priv, > + old, channel->rsigs); > + } > + > + return 0; > +} > + > static irqreturn_t qcom_glink_native_intr(int irq, void *data) > { > struct qcom_glink *glink = data; > @@ -1036,6 +1119,10 @@ static irqreturn_t qcom_glink_native_intr(int irq, void *data) > qcom_glink_handle_intent_req_ack(glink, param1, param2); > qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8)); > break; > + case RPM_CMD_SIGNALS: > + qcom_glink_handle_signals(glink, param1, param2); > + qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8)); > + break; > default: > dev_err(glink->dev, "unhandled rx cmd: %d\n", cmd); > ret = -EINVAL; > @@ -1332,6 +1419,42 @@ static int qcom_glink_trysend(struct rpmsg_endpoint *ept, void *data, int len) > return __qcom_glink_send(channel, data, len, false); > } > > +static int qcom_glink_get_sigs(struct rpmsg_endpoint *ept) > +{ > + struct glink_channel *channel = to_glink_channel(ept); > + > + return channel->rsigs; > +} > + > +static int qcom_glink_set_sigs(struct rpmsg_endpoint *ept, u32 set, u32 clear) > +{ > + struct glink_channel *channel = to_glink_channel(ept); > + struct qcom_glink *glink = channel->glink; > + u32 sigs = channel->lsigs; > + > + if (set & TIOCM_DTR) > + sigs |= TIOCM_DTR; > + if (set & TIOCM_RTS) > + sigs |= TIOCM_RTS; > + if (set & TIOCM_CD) > + sigs |= TIOCM_CD; > + if (set & TIOCM_RI) > + sigs |= TIOCM_RI; > + > + if (clear & TIOCM_DTR) > + sigs &= ~TIOCM_DTR; > + if (clear & TIOCM_RTS) > + sigs &= ~TIOCM_RTS; > + if (clear & TIOCM_CD) > + sigs &= ~TIOCM_CD; > + if (clear & TIOCM_RI) > + sigs &= ~TIOCM_RI; > + > + channel->lsigs = sigs; > + > + return qcom_glink_send_signals(glink, channel, sigs); > +} > + > /* > * Finds the device_node for the glink child interested in this channel. > */ > @@ -1365,6 +1488,8 @@ static const struct rpmsg_endpoint_ops glink_endpoint_ops = { > .destroy_ept = qcom_glink_destroy_ept, > .send = qcom_glink_send, > .trysend = qcom_glink_trysend, > + .get_signals = qcom_glink_get_sigs, > + .set_signals = qcom_glink_set_sigs, > }; > > static void qcom_glink_rpdev_release(struct device *dev) >