From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA443C433ED for ; Mon, 10 May 2021 06:35:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF49861449 for ; Mon, 10 May 2021 06:35:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230076AbhEJGg4 (ORCPT ); Mon, 10 May 2021 02:36:56 -0400 Received: from ivanoab7.miniserver.com ([37.128.132.42]:57944 "EHLO www.kot-begemot.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbhEJGg4 (ORCPT ); Mon, 10 May 2021 02:36:56 -0400 X-Greylist: delayed 2046 seconds by postgrey-1.27 at vger.kernel.org; Mon, 10 May 2021 02:36:56 EDT Received: from tun252.jain.kot-begemot.co.uk ([192.168.18.6] helo=jain.kot-begemot.co.uk) by www.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfyz9-0006DY-Qs; Mon, 10 May 2021 06:01:44 +0000 Received: from madding.kot-begemot.co.uk ([192.168.3.98]) by jain.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lfyz7-0004m2-Bb; Mon, 10 May 2021 07:01:43 +0100 Subject: Re: [PATCH v2 0/1] drm/msm/dpu: Fix error return code in dpu_mdss_init() To: Zhen Lei , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm , dri-devel , freedreno , linux-kernel References: <20210510031606.3112-1-thunder.leizhen@huawei.com> From: Anton Ivanov Organization: Cambridge Greys Message-ID: <9109a395-099b-ed14-4433-d4bf6dbf5cef@cambridgegreys.com> Date: Mon, 10 May 2021 07:01:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210510031606.3112-1-thunder.leizhen@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Clacks-Overhead: GNU Terry Pratchett Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 10/05/2021 04:16, Zhen Lei wrote: > v1 --> v2: > According to Anton Ivanov's review comments, detele the unnecessary local > variable initialization "ret = 0". > > > Zhen Lei (1): > drm/msm/dpu: Fix error return code in dpu_mdss_init() > > drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > I do not recall reviewing this. I think you got the wrong Anton Ivanov - I maintain UML so the previous revision hit someone's else inbox. -- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/