From: Chanwoo Choi <cw00.choi@samsung.com>
To: Stephan Gerhold <stephan@gerhold.net>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: qcom-usb-hs: Fix extcon double register after power cycle
Date: Thu, 10 Oct 2019 20:08:30 +0900 [thread overview]
Message-ID: <91431b4c-fd65-9641-394b-4c9ff6f7a855@samsung.com> (raw)
In-Reply-To: <20191008115208.149987-1-stephan@gerhold.net>
On 19. 10. 8. 오후 8:52, Stephan Gerhold wrote:
> Commit f0b5c2c96370 ("phy: qcom-usb-hs: Replace the extcon API")
> switched from extcon_register_notifier() to the resource-managed
> API, i.e. devm_extcon_register_notifier().
>
> This is problematic in this case, because the extcon notifier
> is dynamically registered/unregistered whenever the PHY is powered
> on/off. The resource-managed API does not unregister the notifier
> until the driver is removed, so as soon as the PHY is power cycled,
> attempting to register the notifier again results in:
>
> double register detected
> WARNING: CPU: 1 PID: 182 at kernel/notifier.c:26 notifier_chain_register+0x74/0xa0
> Call trace:
> ...
> extcon_register_notifier+0x74/0xb8
> devm_extcon_register_notifier+0x54/0xb8
> qcom_usb_hs_phy_power_on+0x1fc/0x208
> ...
>
> ... and USB stops working after plugging the cable out and in
> another time.
>
> The easiest way to fix this is to make a partial revert of
> commit f0b5c2c96370 ("phy: qcom-usb-hs: Replace the extcon API")
> and avoid using the resource-managed API in this case.
>
> Fixes: f0b5c2c96370 ("phy: qcom-usb-hs: Replace the extcon API")
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> An other way to fix this would be keep the extcon notifier
> permanently registered, and check in qcom_usb_hs_phy_vbus_notifier
> if the PHY is currently powered on.
> ---
> drivers/phy/qualcomm/phy-qcom-usb-hs.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-usb-hs.c b/drivers/phy/qualcomm/phy-qcom-usb-hs.c
> index b163b3a1558d..61054272a7c8 100644
> --- a/drivers/phy/qualcomm/phy-qcom-usb-hs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-usb-hs.c
> @@ -158,8 +158,8 @@ static int qcom_usb_hs_phy_power_on(struct phy *phy)
> /* setup initial state */
> qcom_usb_hs_phy_vbus_notifier(&uphy->vbus_notify, state,
> uphy->vbus_edev);
> - ret = devm_extcon_register_notifier(&ulpi->dev, uphy->vbus_edev,
> - EXTCON_USB, &uphy->vbus_notify);
> + ret = extcon_register_notifier(uphy->vbus_edev, EXTCON_USB,
> + &uphy->vbus_notify);
> if (ret)
> goto err_ulpi;
> }
> @@ -180,6 +180,9 @@ static int qcom_usb_hs_phy_power_off(struct phy *phy)
> {
> struct qcom_usb_hs_phy *uphy = phy_get_drvdata(phy);
>
> + if (uphy->vbus_edev)
> + extcon_unregister_notifier(uphy->vbus_edev, EXTCON_USB,
> + &uphy->vbus_notify);
> regulator_disable(uphy->v3p3);
> regulator_disable(uphy->v1p8);
> clk_disable_unprepare(uphy->sleep_clk);
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
prev parent reply other threads:[~2019-10-10 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191008115339epcas3p313aae9554dcee0a4269518fef1474ccd@epcas3p3.samsung.com>
2019-10-08 11:52 ` [PATCH] phy: qcom-usb-hs: Fix extcon double register after power cycle Stephan Gerhold
2019-10-10 11:08 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91431b4c-fd65-9641-394b-4c9ff6f7a855@samsung.com \
--to=cw00.choi@samsung.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).