Re: [PATCH V5 3/7] arm64: dts: sc7280: Add QUPv3 wrapper_0 nodes

[rajpat@codeaurora.org]

On 2021-08-19 05:34, Doug Anderson wrote:
> Hi,
> 
> On Thu, Aug 12, 2021 at 12:42 AM Rajesh Patil <rajpat@codeaurora.org> 
> wrote:
>> 
>> @@ -542,8 +561,305 @@
>>                         #address-cells = <2>;
>>                         #size-cells = <2>;
>>                         ranges;
>> +                       iommus = <&apps_smmu 0x123 0x0>;
>>                         status = "disabled";
>> 
>> +                       i2c0: i2c@980000 {
> 
> Not a full review of your patch (I think Matthias has already looked
> in a bunch of detail), but can I also request that you add i2c and spi
> aliases in your next spin (I think you have to spin this anyway,
> right?) Add these under the "aliases" mode before the mmc ones (to
> keep sort order good):
> 

ok I will add them.

Thanks
Rajesh

> i2c0 = &i2c0;
> i2c1 = &i2c1;
> i2c2 = &i2c2;
> i2c3 = &i2c3;
> i2c4 = &i2c4;
> i2c5 = &i2c5;
> i2c6 = &i2c6;
> i2c7 = &i2c7;
> i2c8 = &i2c8;
> i2c9 = &i2c9;
> i2c10 = &i2c10;
> i2c11 = &i2c11;
> i2c12 = &i2c12;
> i2c13 = &i2c13;
> i2c14 = &i2c14;
> i2c15 = &i2c15;
> 
> ...and these after:
> 
> spi0 = &spi0;
> spi1 = &spi1;
> spi2 = &spi2;
> spi3 = &spi3;
> spi4 = &spi4;
> spi5 = &spi5;
> spi6 = &spi6;
> spi7 = &spi7;
> spi8 = &spi8;
> spi9 = &spi9;
> spi10 = &spi10;
> spi11 = &spi11;
> spi12 = &spi12;
> spi13 = &spi13;
> spi14 = &spi14;
> spi15 = &spi15;
> 
> The "Quad SPI" doesn't get an alias, but that's OK. It doesn't have a
> well-defined number in the manual and it's fine to have it be
> auto-assigned. It's really just confusing when there's something with
> a well-defined number in the manual and it's a _different_ one in the
> logs. ;-)
> 
> -Doug