From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BE20C48BCF for ; Sat, 12 Jun 2021 19:39:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E02161186 for ; Sat, 12 Jun 2021 19:39:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231557AbhFLTl2 (ORCPT ); Sat, 12 Jun 2021 15:41:28 -0400 Received: from relay07.th.seeweb.it ([5.144.164.168]:45283 "EHLO relay07.th.seeweb.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231417AbhFLTl0 (ORCPT ); Sat, 12 Jun 2021 15:41:26 -0400 Received: from [192.168.1.101] (83.6.168.161.neoplus.adsl.tpnet.pl [83.6.168.161]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 2C9873F356; Sat, 12 Jun 2021 21:39:24 +0200 (CEST) Subject: Re: [PATCH 1/2] arm64: dts: qcom: sm8250: Disable Adreno and Venus by default To: Rob Clark Cc: ~postmarketos/upstreaming@lists.sr.ht, Martin Botka , AngeloGioacchino Del Regno , Marijn Suijten , jamipkettunen@somainline.org, Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List References: <20210611113514.27173-1-konrad.dybcio@somainline.org> From: Konrad Dybcio Message-ID: <94bf5d73-6939-75dc-46da-ddb8d6ae017a@somainline.org> Date: Sat, 12 Jun 2021 21:39:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 11.06.2021 20:54, Rob Clark wrote: > On Fri, Jun 11, 2021 at 4:35 AM Konrad Dybcio > wrote: >> Components that rely on proprietary (not to mention signed!) firmware should >> not be enabled by default, as lack of the aforementioned firmware could cause >> various issues, from random errors to straight-up failing to boot. > I admit I probably don't test much without fw, but I think maybe > *that* is the issue to solve instead. > > Taking a guess, I think the situation is that you have *some* of the > fw (ie. the unsigned parts coming from linux-firmware) but not > specifically the zap fw. So adreno_zap_shader_load() returns -ENODEV, > which is interpreted to mean "this is a platform that doesn't need zap > to take GPU out of secure mode", and then things go boom when we try > to write RBBM_SECVID_TRUST_CNTL ? While we're not yet there to test that out on A6xx-equipped platforms, my experience with lack ofAdreno firmware so far has been like so: no ZAP, wrong ZAP address in the DT, bad ZAP - either a lockup or a reboot no pm4/pfp - mostly a sane failing route with GPU just not activating after all, yet still I can recall having some problems that I probably won't be able to reproduce right now no GMU fw - as stated before, can't really test properly just yet Konrad