From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35F9EC04FF3 for ; Fri, 21 May 2021 22:29:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0808D60BD3 for ; Fri, 21 May 2021 22:29:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229526AbhEUWat (ORCPT ); Fri, 21 May 2021 18:30:49 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:41717 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbhEUW3K (ORCPT ); Fri, 21 May 2021 18:29:10 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1621636067; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=sAUYM5V3gq+ufKbiwhke5LyxwcnPMFHcCcu9hhiqJwI=; b=ZQMSEegmb3dWDreTUqnO+qlSmIE2auSvcqKK9iqsYIU9ri7CvU90MQPh4f4dyKmpVoN+FpDl LLxw40kccLudwZo9X04CvSh6J50m2byvPi2h8ljYgCkzz91myen6WuTspccCRZM20LQLmene fJaLETlfyh63CLA99GZJn9aOD68= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 60a833d52bff04e53b037e8c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 21 May 2021 22:27:33 GMT Sender: khsieh=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 25471C4323A; Fri, 21 May 2021 22:27:33 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: khsieh) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0C921C433D3; Fri, 21 May 2021 22:27:31 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 21 May 2021 15:27:31 -0700 From: khsieh@codeaurora.org To: Stephen Boyd Cc: agross@kernel.org, bjorn.andersson@linaro.org, robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org, abhinavk@codeaurora.org, aravindh@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/2] drm/msm/dp: handle irq_hpd with sink_count = 0 correctly In-Reply-To: References: <1621455753-28966-1-git-send-email-khsieh@codeaurora.org> Message-ID: <955c69a5fe7bfee9380faf3d2b71a728@codeaurora.org> X-Sender: khsieh@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-05-21 14:56, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-05-19 13:22:33) >> irq_hpd interrupt should be handled after dongle plugged in and >> before dongle unplugged. Hence irq_hpd interrupt is enabled at >> the end of the plugin handle and disabled at the beginning of >> unplugged handle. Current irq_hpd with sink_count = 0 is wrongly >> handled same as the dongle unplugged which tears down the mainlink >> and disables the phy. This patch fixes this problem by only tearing >> down the mainlink but keeping phy enabled at irq_hpd with >> sink_count = 0 handle so that next irq_hpd with sink_count =1 can be >> handled by setup mainlink only. This patch also set dongle into D3 >> (power off) state at end of handling irq_hpd with sink_count = 0. >> >> Changes in v2: >> -- add ctrl->phy_Power_count >> >> Changes in v3: >> -- del ctrl->phy_Power_count >> -- add phy_power_off to dp_ctrl_off_link_stream() >> >> Changes in v4: >> -- return immediately if clock disable failed at >> dp_ctrl_off_link_stream() >> >> Changes in v5: >> -- set dongle to D3 (power off) state at dp_ctrl_off_link_stream() >> >> Changes in v6: >> -- add Fixes tag >> >> Fixes: 94e58e2d06e3 ("drm/msm/dp: reset dp controller only at boot up >> and pm_resume") >> >> Signed-off-by: Kuogee Hsieh >> --- > > Tested-by: Stephen Boyd > Reviewed-by: Stephen Boyd > > We can resolve the lingering dual irq issue later on if you don't want > to send another round of this. Also, the title says 1/2 so I wonder if > there's another patch? Doesn't look like there is but I have to ask. If > not, please generate patches with the right - argument or revision > range. new v6 uploaded