From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58B1EC433EF for ; Fri, 17 Sep 2021 09:08:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44136611C4 for ; Fri, 17 Sep 2021 09:08:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239861AbhIQJKE (ORCPT ); Fri, 17 Sep 2021 05:10:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238946AbhIQJJz (ORCPT ); Fri, 17 Sep 2021 05:09:55 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74923C061764 for ; Fri, 17 Sep 2021 02:08:33 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id d21so13961938wra.12 for ; Fri, 17 Sep 2021 02:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/I1Tt1HzjsE75nZdTSIEAGwCXwh62BBwx+UsI2exLfE=; b=g7vbAOuYwlGhiAw9321uxYSPDO4QmS+BNVRgg54rzvRGqw2zAa6COxOrt0WHHGiqd0 uM7aePVxRjSQYOkyW4FSx/bmhcVAO6vFcYS1WtWCF9EYw37AiDrqya4pk0xAU/KaevQd c5CcGZQo68v6rxSMr0qrq10qIYGCwbWSxQrc3nL1WaJMA1ENNAgpln9Is4QrBoAJDqO+ EqtnQ6Nwv29l0rGeSFmwg9e0WocgUqP04KB1yW/l5hhyuucSmsS384qOrgse9AxGGj1R KEeMdQiRrkTv9PSZShGqhWuQpBySfM8970yf8/fjidJmqn6gcAjaKv+4zHDxfY3h/B/z ThLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/I1Tt1HzjsE75nZdTSIEAGwCXwh62BBwx+UsI2exLfE=; b=kuCof6PF6XnWsErN4nO2g4oD1oGZeK2OYUb7wdHn404DsiEoWQEeNAj7n0L4WiYJWq x5Yc70cCVisvt0bNjqDZ3ESyu0JTIz7DJ3q0BRXTxTZvlMDYIapgE/2hB7xMu+ZFU93j qZqQmT5NTV7CO4X1T0rHBR28skY82hfEOYLVh62PFgNFzLNUH2+/xe8eVLz+H5Zl0OmP IFOsH/2pLmQsmUc7I+KgXEV03152rNbMJpZPxNCYJgik/Wt6TT8XMkSjwYD4YwXxzjr7 5DTJNrciatyrXD7IRxnv4CV8emhhYnP+Lv+DMTHLliNFTztW+nK54yFfvSaKFWlv72l9 5icA== X-Gm-Message-State: AOAM5323zDABdP28dXOjIRInxqTB7fdNB7kVnWD36rxAteJx0INTy7Qj NfuNPi6EGaCQUXIF8oQtn2m3gA== X-Google-Smtp-Source: ABdhPJwUBCGdpmC3bQGNPhpHns+vpWRXUWfkWp9nmnSGcm2X6UWVp0FLYQO7wVAmPuVCIOurE3k+IA== X-Received: by 2002:a5d:6dad:: with SMTP id u13mr10421628wrs.55.1631869711923; Fri, 17 Sep 2021 02:08:31 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:cf95:6508:8470:7171? ([2a01:e34:ed2f:f020:cf95:6508:8470:7171]) by smtp.googlemail.com with ESMTPSA id y8sm5986742wrh.44.2021.09.17.02.08.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Sep 2021 02:08:31 -0700 (PDT) Subject: Re: [PATCH v2 1/2] drivers: thermal: tsens: fix wrong check for tzd in irq handlers To: Ansuel Smith , Andy Gross , Bjorn Andersson , Amit Kucheria , Thara Gopinath , Zhang Rui , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Matthias Kaehlcke References: <20210907212543.20220-1-ansuelsmth@gmail.com> From: Daniel Lezcano Message-ID: <95c7a633-144c-917b-376f-636b904f8b73@linaro.org> Date: Fri, 17 Sep 2021 11:08:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210907212543.20220-1-ansuelsmth@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Applied, thanks On 07/09/2021 23:25, Ansuel Smith wrote: > Some device can have some thermal sensor disabled from the factory. The > current 2 irq handler functions check all the sensor by default and the > check if the sensor was actually registered is wrong. The tzd is > actually never set if the registration fail hence the IS_ERR check is > wrong. > > Signed-off-by: Ansuel Smith > Reviewed-by: Matthias Kaehlcke > --- > drivers/thermal/qcom/tsens.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c > index 4c7ebd1d3f9c..b1162e566a70 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -417,7 +417,7 @@ static irqreturn_t tsens_critical_irq_thread(int irq, void *data) > const struct tsens_sensor *s = &priv->sensor[i]; > u32 hw_id = s->hw_id; > > - if (IS_ERR(s->tzd)) > + if (!s->tzd) > continue; > if (!tsens_threshold_violated(priv, hw_id, &d)) > continue; > @@ -467,7 +467,7 @@ static irqreturn_t tsens_irq_thread(int irq, void *data) > const struct tsens_sensor *s = &priv->sensor[i]; > u32 hw_id = s->hw_id; > > - if (IS_ERR(s->tzd)) > + if (!s->tzd) > continue; > if (!tsens_threshold_violated(priv, hw_id, &d)) > continue; > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog