From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88160C433B4 for ; Wed, 19 May 2021 22:43:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CC0E61353 for ; Wed, 19 May 2021 22:43:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229508AbhESWoZ (ORCPT ); Wed, 19 May 2021 18:44:25 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:47747 "EHLO mail-40131.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbhESWoZ (ORCPT ); Wed, 19 May 2021 18:44:25 -0400 Date: Wed, 19 May 2021 22:42:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connolly.tech; s=protonmail; t=1621464183; bh=A95P5VcW4Kdb09IztDj5EB+t6+VkeKybrxN1hQ+voYY=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=ZUUs/S5Mzy19CNGOoQ3stt6FfQ/Ep6H2OBSxP0h/0HKl9+RaA3qoIJxvMgU7kMhN9 yCK0FBM7qMjMywrw4pYtQJfJTY3BZg4ajKuItRGJWSboLTgQlH6bAVRZ76VWQp9sdB iVkVUnpR+oQE4sYjCywpv+azmr77lp96tQABIl9c= To: Saravana Kannan , Rob Clark From: Caleb Connolly Cc: John Stultz , Amit Pundir , Bjorn Andersson , Douglas Anderson , Stephen Boyd , linux-arm-msm , dmitry.baryshkov@linaro.org Reply-To: Caleb Connolly Subject: Re: fw_devlink breakage on SDM845 / a630 with DSI displays Message-ID: <968c8e20-82ef-cc3d-c809-f38d801699c8@connolly.tech> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Saravana, On 19/05/2021 10:52 pm, Saravana Kannan wrote: > On Wed, May 19, 2021 at 8:36 AM Rob Clark wrote: >> >> + some more folks and msm list.. >> >> I suppose I didn't hit this because CONFIG_FBDEV_EMULATION is not >> normally enabled for CrOS.. but I'm not really to familiar with >> fw_devlink >> >> BR, >> -R >> >> On Wed, May 19, 2021 at 8:26 AM Caleb Connolly wro= te: >>> >>> >>> Hi, >>> >>> Since -rc1 I've been hit by some DRM breakage in freedreno which happen= s >>> when fw_devlink=3Don. It seems to cause some clocks (rcg) to get stuck = and >>> break DSI displays, here's a full log from the OnePlus 6: >>> https://paste.ubuntu.com/p/8kPx4nFGF5/ (that is with >>> "deferred_probe_timeout") The PocoPhone F1 also seems to be affected by >>> this. >>> >>> The display will still come up after pressing the power button a few >>> times, although it will be incredibly slow. >>> >>> It's worth noting that the issue only happens with >>> CONFIG_FBDEV_EMULATION is enabled, I've previously required this to see >>> kernel logs during boot and general boot splash with postmarketOS. >>> Without it the display will be stuck on the bootloader splash until I >>> press the power button and cause it to update once UI (like Phosh) has >>> started (though this has been the case for quite some time). >>> >>> I'd appreciate any help with debugging / resolving this issue, I'm >>> afraid I haven't been able to determine much from some brief digging. >>> > > Hi Caleb, > > Is this a device that's supported upstream? If so, can you please > point me to the DTS file that corresponds to this board? The DTS can be found in arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi (the two devices "enchilada" and "fajita" share almost all hardware in common). > > Also, can you please change all the dev_dbg to dev_info in these > functions and give me the full boot log? > device_link_add() > device_links_check_suppliers() I've uploaded a log here: https://paste.ubuntu.com/p/8ynFgRWbYW/ For reference, the same but with fw_devlink=3Dpermissive: https://paste.ubuntu.com/p/F2853CphHb/ > > Can you also tell what device are not probing with fw_devlink=3Don that > might be probing with fw_devlink=3Dpermissive? The devices in question are ae00000.mdss, ae94000.dsi and ae01000.mdp. > You should be able to compare //devices_deferred to figure that = out. devices_deferred is empty for me, however device_component contains (only) the following: oneplus6:/home/user# cat /sys/kernel/debug/device_component/ae00000.mdss master name status ------------------------------------------------------------- ae00000.mdss bound device name status ------------------------------------------------------------- ae01000.mdp bound ae94000.dsi bound 5000000.gpu bound > > Thanks, > Saravana > I tried reverting the commit Dmitry mentioned however it didn't seem to have any effect for me. (Cc'd) -- Kind Regards, Caleb