From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4B51C11F66 for ; Wed, 30 Jun 2021 19:56:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC7C561481 for ; Wed, 30 Jun 2021 19:56:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233777AbhF3T7D (ORCPT ); Wed, 30 Jun 2021 15:59:03 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:49015 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233893AbhF3T7C (ORCPT ); Wed, 30 Jun 2021 15:59:02 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1625082993; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=QTTE8NNuBrvvp0efVaqe5OgIC5A/+9SKhlJOrgHTdOU=; b=jnygpPFAs1X4N/W3UKX7GGFNutxs5ZiUwAvLzaPZ2Bdo2YDQ1MIM2B25Nx68OtqDN+OhjXmT LrwSpcbB+XCspIvQ7S4c90kuwvOedwR3c9lM3r+qxsFq1OVEZFm7BMFSX+UixkJfEoVLxJIP vvtUMdE7xF1MQwjI8nPChH665Po= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 60dccc6b2a2a9a976194a481 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 30 Jun 2021 19:56:27 GMT Sender: sibis=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E12C0C4323A; Wed, 30 Jun 2021 19:56:26 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: sibis) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0D57DC433D3; Wed, 30 Jun 2021 19:56:25 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 01 Jul 2021 01:26:25 +0530 From: Sibi Sankar To: Matthias Kaehlcke Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org, swboyd@chromium.org, ulf.hansson@linaro.org, rjw@rjwysocki.net, agross@kernel.org, ohad@wizery.com, mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, rishabhb@codeaurora.org, sidgup@codeaurora.org Subject: Re: [PATCH v3 11/13] soc: qcom: aoss: Drop power domain support In-Reply-To: References: <1624560727-6870-1-git-send-email-sibis@codeaurora.org> <1624560727-6870-12-git-send-email-sibis@codeaurora.org> Message-ID: <97e360aff212cc75021279f727a70454@codeaurora.org> X-Sender: sibis@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-06-26 03:31, Matthias Kaehlcke wrote: > On Fri, Jun 25, 2021 at 12:22:05AM +0530, Sibi Sankar wrote: >> The load state resources are expected to follow the life cycle of the >> remote processor it tracks. However, modeling load state resources as >> power-domains result in them getting turned off during system suspend >> and thereby falling out of sync with the remote processors that are >> still >> on. Fix this by replacing load state resource control through the >> generic >> qmp message send interface instead. > > nit: the above sounds as if this patch does all of that, when it only > removes power domain support. Instead you could start with saying what > the patch actually does (remove power domain support), followed by why > PD support isn't needed anymore (now done by sending QMP messages > directly). > sure, will fix this up in the next re-spin. >> Signed-off-by: Sibi Sankar >> --- >> drivers/soc/qcom/qcom_aoss.c | 109 >> ++----------------------------------------- >> 1 file changed, 3 insertions(+), 106 deletions(-) >> >> diff --git a/drivers/soc/qcom/qcom_aoss.c >> b/drivers/soc/qcom/qcom_aoss.c >> index 998ee7605eb2..f0c3726e8c46 100644 >> --- a/drivers/soc/qcom/qcom_aoss.c >> +++ b/drivers/soc/qcom/qcom_aoss.c >> >> ... >> >> @@ -650,13 +550,11 @@ static int qmp_probe(struct platform_device >> *pdev) >> if (ret) >> goto err_close_qmp; >> >> - ret = qmp_pd_add(qmp); >> - if (ret) >> - goto err_remove_qdss_clk; >> - >> ret = qmp_cooling_devices_register(qmp); >> - if (ret) >> + if (ret) { >> dev_err(&pdev->dev, "failed to register aoss cooling devices\n"); >> + goto err_remove_qdss_clk; > > This isn't really related with the PD removal, right? I wonder if it > was > intentional to have _probe() succeed even when the cooling device > registration failed, since the cooling devices aren't essential. > Thanks for catching ^^ > If it is still desirable to fail the change should be done in a > separate > patch, unless it is actually related with removing PD support. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.