From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6AC2C433FE for ; Sun, 14 Nov 2021 12:46:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B721061104 for ; Sun, 14 Nov 2021 12:46:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234722AbhKNMtj (ORCPT ); Sun, 14 Nov 2021 07:49:39 -0500 Received: from m43-7.mailgun.net ([69.72.43.7]:34346 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230186AbhKNMth (ORCPT ); Sun, 14 Nov 2021 07:49:37 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1636894003; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=mC3LjhRSX3c0QTWBp0qcXjBnbouZr3462yGwYzm+tFU=; b=fiM+yUwgIkUpmAsB9/Nh2OLgQdXn3+gCih8OuwEb+2MGuaNHSWbwbYJFMXQ0hzX0d4k6t1Dq Fk1/t5FiNXVgmZd/oDpkwu1Ba8W4Fas4B5DDVEyECRDqU26KBS2YeKtgjSIo11XW2j1iTRCh KaPa+t9/JsumJQ0cxIh7XruHFHQ= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 61910527c48ba48884f0b040 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 14 Nov 2021 12:46:31 GMT Sender: zijuhu=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4AAB1C4360D; Sun, 14 Nov 2021 12:46:31 +0000 (UTC) Received: from [192.168.0.104] (unknown [183.195.15.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zijuhu) by smtp.codeaurora.org (Postfix) with ESMTPSA id 09536C4338F; Sun, 14 Nov 2021 12:46:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 09536C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Subject: Re: [PATCH v1] Bluetooth: hci_h4: Fix padding calculation error within h4_recv_buf() To: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com Cc: linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org, c-hbandi@codeaurora.org, hemantg@codeaurora.org, rjliao@codeaurora.org, Zijun Hu References: <1636546159-8339-1-git-send-email-zijuhu@codeaurora.org> From: Zijun Hu Message-ID: <97e8c186-3c4f-a3ff-8389-e15ea476280e@codeaurora.org> Date: Sun, 14 Nov 2021 20:46:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <1636546159-8339-1-git-send-email-zijuhu@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org could you please code review for this patch? On 11/10/2021 8:09 PM, Zijun Hu wrote: > From: Zijun Hu > > it is erroneous to calculate padding by subtracting length of type > indication from skb->len, it will cause data analysis error for > alignment which is greater than 1, so fixed by adding length of type > indication with skb->len. > > Signed-off-by: Zijun Hu > --- > drivers/bluetooth/hci_h4.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/bluetooth/hci_h4.c b/drivers/bluetooth/hci_h4.c > index 4b3b14a34794..1d0cdf023243 100644 > --- a/drivers/bluetooth/hci_h4.c > +++ b/drivers/bluetooth/hci_h4.c > @@ -252,7 +252,7 @@ struct sk_buff *h4_recv_buf(struct hci_dev *hdev, struct sk_buff *skb, > } > > if (!dlen) { > - hu->padding = (skb->len - 1) % alignment; > + hu->padding = (skb->len + 1) % alignment; > hu->padding = (alignment - hu->padding) % alignment; > > /* No more data, complete frame */ > @@ -260,7 +260,7 @@ struct sk_buff *h4_recv_buf(struct hci_dev *hdev, struct sk_buff *skb, > skb = NULL; > } > } else { > - hu->padding = (skb->len - 1) % alignment; > + hu->padding = (skb->len + 1) % alignment; > hu->padding = (alignment - hu->padding) % alignment; > > /* Complete frame */ >