From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F1A8C433E6 for ; Sun, 21 Feb 2021 18:40:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC0E264F29 for ; Sun, 21 Feb 2021 18:40:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230148AbhBUSkF (ORCPT ); Sun, 21 Feb 2021 13:40:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230081AbhBUSkE (ORCPT ); Sun, 21 Feb 2021 13:40:04 -0500 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41D53C061786 for ; Sun, 21 Feb 2021 10:39:24 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id e8so12972638ljj.5 for ; Sun, 21 Feb 2021 10:39:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5I3tMMTBMyjB/2CdlpmtYbbra5FZ++dhXNjXHnm0pkc=; b=NPxuhy9ewQtSl+JUt7hx4Vt61oDQN8ny87nxySsXBD7XDdR/Glar5huLBBvO/2p6Mq O+IzvO7vbKIrxvnjPZjYwffSP8gCyVoo/gjXZcglmzIG8CCILwD+wnsG87b4mG6toALR W999ksjJ0ai9oO+2Yw77nIHqoedqcoHwdnpstg77Fx4h35ibtuH5U8ClfjO4wt0/O2Ir MaMKOGRZA+LkpjStWxGb9gtAPUjb8GrDpbcqO6Y3XzDFXsGoCAMSm0KkpIdIBzz6rI7m 4Jv0/tRpsfyCKOcWhPxGxcfB1Lgevf6j1+fFTugMJvzitd2k0lt0AQNT3u+zV0l8EBA3 +sMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5I3tMMTBMyjB/2CdlpmtYbbra5FZ++dhXNjXHnm0pkc=; b=FvVrSm8cmFs7rlAhT5avcWRjPvXLH2QIky6Lz3ZTaffp/t4SjSrT60b5i/LNPuQOYb F/Z2L5HkA4JDjAy/p66VGXRE40//907+HzuyhSPga91vc9CEyhwesPgaHQrOg47lLAm+ PP6r3bCUKl3fOfIlWH/s2xju5g3G6e/hQfC1+KOcn3WIMd7EURy3skUw2MYpExcEq6l3 TB7GsNaeluXmK87XsAwNF0qmu39258fpMFqv0TGwKbs+cn2BkvgSZqQhq/OoihVJCmop MRLMkOgZDmCFJ9l1XLue15FJrOK+j/qboxN8h1ZA0jfO6s49j7qdWgQnfwkB2GAHO6oL r7RQ== X-Gm-Message-State: AOAM5306b6gAzluiyfC7FTLy0XvJM+28y40OiQmABCONMpqz9QBaqM5k yLt3UkYTpZCY4V10p5Gsm8WSAg== X-Google-Smtp-Source: ABdhPJzyPK/Lok31uLcddeKKE6KehkSGm/6qNIlTxjr1qm/9OxPMa8LN0bFwvO3Tz1eYRkcLnPRovg== X-Received: by 2002:a05:6512:36c9:: with SMTP id e9mr3644403lfs.343.1613932762637; Sun, 21 Feb 2021 10:39:22 -0800 (PST) Received: from [192.168.118.216] ([85.249.43.69]) by smtp.gmail.com with ESMTPSA id y13sm706921ljd.6.2021.02.21.10.39.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Feb 2021 10:39:22 -0800 (PST) Subject: Re: [PATCH v5 20/22] arm64: dts: sdm845: Add CAMSS ISP node To: Robert Foss , agross@kernel.org, bjorn.andersson@linaro.org, todor.too@gmail.com, mchehab@kernel.org, robh+dt@kernel.org, angelogioacchino.delregno@somainline.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , Sakari Ailus , Nicolas Boichat Cc: Rob Herring , Tomasz Figa , Azam Sadiq Pasha Kapatrala Syed , Sarvesh Sridutt , Laurent Pinchart , Jonathan Marek References: <20210217112122.424236-1-robert.foss@linaro.org> <20210217112122.424236-21-robert.foss@linaro.org> From: Andrey Konovalov Message-ID: <9b8f9394-3ab6-3a2f-32cf-4e60012be2d8@linaro.org> Date: Sun, 21 Feb 2021 21:39:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210217112122.424236-21-robert.foss@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Robert, Thank you for your patch! Reviewed-by: Andrey Konovalov Thanks, Andrey On 17.02.2021 14:21, Robert Foss wrote: > Add the camss dt node for sdm845. > > Signed-off-by: Robert Foss > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 135 +++++++++++++++++++++++++++ > 1 file changed, 135 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index bcf888381f14..4fe93c69908a 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -3911,6 +3911,141 @@ videocc: clock-controller@ab00000 { > #reset-cells = <1>; > }; > > + camss: camss@a00000 { > + compatible = "qcom,sdm845-camss"; > + > + reg = <0 0xacb3000 0 0x1000>, > + <0 0xacba000 0 0x1000>, > + <0 0xacc8000 0 0x1000>, > + <0 0xac65000 0 0x1000>, > + <0 0xac66000 0 0x1000>, > + <0 0xac67000 0 0x1000>, > + <0 0xac68000 0 0x1000>, > + <0 0xacaf000 0 0x4000>, > + <0 0xacb6000 0 0x4000>, > + <0 0xacc4000 0 0x4000>; > + reg-names = "csid0", > + "csid1", > + "csid2", > + "csiphy0", > + "csiphy1", > + "csiphy2", > + "csiphy3", > + "vfe0", > + "vfe1", > + "vfe_lite"; > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + interrupt-names = "csid0", > + "csid1", > + "csid2", > + "csiphy0", > + "csiphy1", > + "csiphy2", > + "csiphy3", > + "vfe0", > + "vfe1", > + "vfe_lite"; > + > + power-domains = <&clock_camcc IFE_0_GDSC>, > + <&clock_camcc IFE_1_GDSC>, > + <&clock_camcc TITAN_TOP_GDSC>; > + > + clocks = <&clock_camcc CAM_CC_CAMNOC_AXI_CLK>, > + <&clock_camcc CAM_CC_CPAS_AHB_CLK>, > + <&clock_camcc CAM_CC_CPHY_RX_CLK_SRC>, > + <&clock_camcc CAM_CC_IFE_0_CSID_CLK>, > + <&clock_camcc CAM_CC_IFE_0_CSID_CLK_SRC>, > + <&clock_camcc CAM_CC_IFE_1_CSID_CLK>, > + <&clock_camcc CAM_CC_IFE_1_CSID_CLK_SRC>, > + <&clock_camcc CAM_CC_IFE_LITE_CSID_CLK>, > + <&clock_camcc CAM_CC_IFE_LITE_CSID_CLK_SRC>, > + <&clock_camcc CAM_CC_CSIPHY0_CLK>, > + <&clock_camcc CAM_CC_CSI0PHYTIMER_CLK>, > + <&clock_camcc CAM_CC_CSI0PHYTIMER_CLK_SRC>, > + <&clock_camcc CAM_CC_CSIPHY1_CLK>, > + <&clock_camcc CAM_CC_CSI1PHYTIMER_CLK>, > + <&clock_camcc CAM_CC_CSI1PHYTIMER_CLK_SRC>, > + <&clock_camcc CAM_CC_CSIPHY2_CLK>, > + <&clock_camcc CAM_CC_CSI2PHYTIMER_CLK>, > + <&clock_camcc CAM_CC_CSI2PHYTIMER_CLK_SRC>, > + <&clock_camcc CAM_CC_CSIPHY3_CLK>, > + <&clock_camcc CAM_CC_CSI3PHYTIMER_CLK>, > + <&clock_camcc CAM_CC_CSI3PHYTIMER_CLK_SRC>, > + <&gcc GCC_CAMERA_AHB_CLK>, > + <&gcc GCC_CAMERA_AXI_CLK>, > + <&clock_camcc CAM_CC_SLOW_AHB_CLK_SRC>, > + <&clock_camcc CAM_CC_SOC_AHB_CLK>, > + <&clock_camcc CAM_CC_IFE_0_AXI_CLK>, > + <&clock_camcc CAM_CC_IFE_0_CLK>, > + <&clock_camcc CAM_CC_IFE_0_CPHY_RX_CLK>, > + <&clock_camcc CAM_CC_IFE_0_CLK_SRC>, > + <&clock_camcc CAM_CC_IFE_1_AXI_CLK>, > + <&clock_camcc CAM_CC_IFE_1_CLK>, > + <&clock_camcc CAM_CC_IFE_1_CPHY_RX_CLK>, > + <&clock_camcc CAM_CC_IFE_1_CLK_SRC>, > + <&clock_camcc CAM_CC_IFE_LITE_CLK>, > + <&clock_camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>, > + <&clock_camcc CAM_CC_IFE_LITE_CLK_SRC>; > + clock-names = "camnoc_axi", > + "cpas_ahb", > + "cphy_rx_src", > + "csi0", > + "csi0_src", > + "csi1", > + "csi1_src", > + "csi2", > + "csi2_src", > + "csiphy0", > + "csiphy0_timer", > + "csiphy0_timer_src", > + "csiphy1", > + "csiphy1_timer", > + "csiphy1_timer_src", > + "csiphy2", > + "csiphy2_timer", > + "csiphy2_timer_src", > + "csiphy3", > + "csiphy3_timer", > + "csiphy3_timer_src", > + "gcc_camera_ahb", > + "gcc_camera_axi", > + "slow_ahb_src", > + "soc_ahb", > + "vfe0_axi", > + "vfe0", > + "vfe0_cphy_rx", > + "vfe0_src", > + "vfe1_axi", > + "vfe1", > + "vfe1_cphy_rx", > + "vfe1_src", > + "vfe_lite", > + "vfe_lite_cphy_rx", > + "vfe_lite_src"; > + > + iommus = <&apps_smmu 0x0808 0x0>, > + <&apps_smmu 0x0810 0x8>, > + <&apps_smmu 0x0c08 0x0>, > + <&apps_smmu 0x0c10 0x8>; > + > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > + > cci: cci@ac4a000 { > compatible = "qcom,sdm845-cci"; > #address-cells = <1>; >