From: Jason Wang <jasowang@redhat.com>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org,
open list <linux-kernel@vger.kernel.org>,
shahafs@mellanox.com, lulu@redhat.com, sgarzare@redhat.com,
Randy Dunlap <rdunlap@infradead.org>,
lkft-triage@lists.linaro.org,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH V3 16/19] virtio-pci: introduce modern device module
Date: Wed, 10 Feb 2021 12:38:34 +0800 [thread overview]
Message-ID: <9cc9d649-e891-8bcc-e5f8-cec7c0d40077@redhat.com> (raw)
In-Reply-To: <CA+G9fYteUN=s5Mp+BhdMPZt96B3qDa+2HwudmWgEmmrDELLPdw@mail.gmail.com>
On 2021/2/9 下午6:15, Naresh Kamboju wrote:
> Hi Jason,
>
> On Mon, 4 Jan 2021 at 12:28, Jason Wang <jasowang@redhat.com> wrote:
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> ---
>> drivers/virtio/Kconfig | 10 +-
>> drivers/virtio/Makefile | 1 +
>> drivers/virtio/virtio_pci_common.h | 27 +-
>> drivers/virtio/virtio_pci_modern.c | 617 -------------------------
>> drivers/virtio/virtio_pci_modern_dev.c | 599 ++++++++++++++++++++++++
>> include/linux/virtio_pci_modern.h | 111 +++++
>> 6 files changed, 721 insertions(+), 644 deletions(-)
>> create mode 100644 drivers/virtio/virtio_pci_modern_dev.c
>> create mode 100644 include/linux/virtio_pci_modern.h
>>
>> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
>> index 7b41130d3f35..6b9b81f4b8c2 100644
>> --- a/drivers/virtio/Kconfig
>> +++ b/drivers/virtio/Kconfig
>> @@ -12,6 +12,14 @@ config ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>> This option is selected if the architecture may need to enforce
>> VIRTIO_F_ACCESS_PLATFORM
>>
>> +config VIRTIO_PCI_MODERN
>> + tristate "Modern Virtio PCI Device"
>> + depends on PCI
>> + help
>> + Modern PCI device implementation. This module implements the
>> + basic probe and control for devices which are based on modern
>> + PCI device with possible vendor specific extensions.
>> +
>> menuconfig VIRTIO_MENU
>> bool "Virtio drivers"
>> default y
>> @@ -20,7 +28,7 @@ if VIRTIO_MENU
>>
>> config VIRTIO_PCI
>> tristate "PCI driver for virtio devices"
>> - depends on PCI
>> + depends on VIRTIO_PCI_MODERN
> While booting Linux next tag 20210208 kernel on qemu_arm64 and qemu_arm
> mount rootfs failed. The root cause seems to be due to missing configs
> CONFIG_VIRTIO_PCI=y
> CONFIG_VIRTIO_PCI_LEGACY=y
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>
> Then I have to force to enable this MODERN config
> CONFIG_VIRTIO_PCI_MODERN=y
> and which enabled
> CONFIG_VIRTIO_PCI=y
> CONFIG_VIRTIO_PCI_LEGACY=y
>
> and the qemu_arm64 and qemu_arm boot pass.
>
>
> New build link,
> https://builds.tuxbuild.com/1oEse4EFsoQr1FkKBfiLmhMCe7j/
Thanks for the reporting.
I will post a patch to fix the def config to enable VIRTIO_PCI_MODERN.
Thanks
>
>
prev parent reply other threads:[~2021-02-10 4:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210104065503.199631-1-jasowang@redhat.com>
[not found] ` <20210104065503.199631-17-jasowang@redhat.com>
2021-02-09 10:15 ` [PATCH V3 16/19] virtio-pci: introduce modern device module Naresh Kamboju
2021-02-10 4:38 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cc9d649-e891-8bcc-e5f8-cec7c0d40077@redhat.com \
--to=jasowang@redhat.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=naresh.kamboju@linaro.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=sgarzare@redhat.com \
--cc=shahafs@mellanox.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).