From: Marcel Holtmann <marcel@holtmann.org>
To: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
devicetree@vger.kernel.org, Matthias Kaehlcke <mka@chromium.org>,
open list <linux-kernel@vger.kernel.org>,
Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>,
Hemantg <hemantg@codeaurora.org>,
MSM <linux-arm-msm@vger.kernel.org>,
Balakrishna Godavarthi <bgodavar@codeaurora.org>,
Rocky Liao <rjliao@codeaurora.org>,
hbandi@codeaurora.org, abhishekpandit@chromium.org
Subject: Re: [PATCH v3 3/5] Bluetooth: btqca: Moved extracting rom version info to common place
Date: Fri, 7 May 2021 09:53:35 +0200 [thread overview]
Message-ID: <A9592AB3-EE71-4A1A-8CE4-AC209A98BDE5@holtmann.org> (raw)
In-Reply-To: <1620322392-27148-4-git-send-email-gubbaven@codeaurora.org>
Hi Venkata,
> Moved extracting rom version info to common place as this code is
> common in all if else ladder in qca_uart_setup.
>
> Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
> ---
> drivers/bluetooth/btqca.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index 320c555..658fd8e4 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -533,24 +533,21 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate,
>
> config.user_baud_rate = baudrate;
>
> + /* Firmware files to download are based on ROM version.
> + * ROM version is derived from last two bytes of soc_ver.
> + */
> + rom_ver = ((soc_ver & 0x00000f00) >> 0x04) |
> + (soc_ver & 0x0000000f);
> +
please try to align this properly.
Regards
Marcel
next prev parent reply other threads:[~2021-05-07 7:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 17:33 [PATCH v3 0/5] Enable Bluetooth functinality for WCN6750 Venkata Lakshmi Narayana Gubba
2021-05-06 17:33 ` [PATCH v3 1/5] Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6750 Venkata Lakshmi Narayana Gubba
2021-05-06 17:33 ` [PATCH v3 2/5] Bluetooth: btqca: Add support for firmware image with mbn type for WCN6750 Venkata Lakshmi Narayana Gubba
2021-05-07 7:00 ` Marcel Holtmann
2021-05-10 17:16 ` gubbaven
2021-05-06 17:33 ` [PATCH v3 3/5] Bluetooth: btqca: Moved extracting rom version info to common place Venkata Lakshmi Narayana Gubba
2021-05-07 7:53 ` Marcel Holtmann [this message]
2021-05-10 17:09 ` gubbaven
2021-05-06 17:33 ` [PATCH v3 4/5] dt-bindings: net: bluetooth: Convert Qualcomm BT binding to DT schema Venkata Lakshmi Narayana Gubba
2021-05-07 1:17 ` Rob Herring
2021-05-07 6:55 ` Marcel Holtmann
2021-05-07 17:19 ` Rob Herring
2021-05-13 15:21 ` Marcel Holtmann
2021-05-18 16:30 ` gubbaven
2021-05-06 17:33 ` [PATCH v3 5/5] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn6750 Venkata Lakshmi Narayana Gubba
2021-05-07 1:19 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A9592AB3-EE71-4A1A-8CE4-AC209A98BDE5@holtmann.org \
--to=marcel@holtmann.org \
--cc=abhishekpandit@chromium.org \
--cc=bgodavar@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=gubbaven@codeaurora.org \
--cc=hbandi@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rjliao@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).