From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A7ADC433E0 for ; Tue, 9 Feb 2021 10:18:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F6C964E77 for ; Tue, 9 Feb 2021 10:18:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231308AbhBIKSt (ORCPT ); Tue, 9 Feb 2021 05:18:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231436AbhBIKQd (ORCPT ); Tue, 9 Feb 2021 05:16:33 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21881C061786 for ; Tue, 9 Feb 2021 02:15:45 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id hs11so30426914ejc.1 for ; Tue, 09 Feb 2021 02:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zeO3sY4fbSBwh5uWv4Oqzo1Gi6tqlkYzvN/i5rqf3qU=; b=spw3R/IQ+ixH4qYVWy1fvUGlrOVdgInPdBvFjZeqyzbtEOqs1+X95sHl/HLLJ4VLLk f/zCWcsYsIGVxFo3DtWdh4loosYk4PDaki0Z66TJGdxEAn1X4uIO411xgU0w+TS32yES TgNwhsLlSeYp5zOMvXfik/iwxbNg17Iyfg06o/2vjPLVXLaoyrwuS7yL3HPnMSj+CEc3 WCn62lyieJuwi6KV8qL+aBhCZ8EGrYKboHcc1VltCLlKjUceTsCqerLZaAod0AlBTQot bk/P7uysddwFDcJ+kmfogaC16xgoU6kBDC61vr+NFK0MDgPRUaQMOmzc5Xf+Fylvnazi WHWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zeO3sY4fbSBwh5uWv4Oqzo1Gi6tqlkYzvN/i5rqf3qU=; b=aohNnfqLr7htEyeO01YpiVkV1P2KLLpvuXrqBfVXxfmEddAUj67zxTAcGBrDhlX+DX bM4G5wsgwTXIlBXWyXM9pO0DzHIOQ/j3Y4RpIT1zMudZpBVdFQv0mJ/PySv4zWSpQEAZ +fbUtkprtTo1X9XUj0GcAMwwTtXKwaq9DN4zISbxQykPYa3NfH5Pd/7t0AcjQvmZZElW KrpNw5dfvOa6DkfCevZT5KMR172YJDqBzj9SqF1Ho3Z9FUN/0UyCdWIhAsip60mAzRcc UggvGgfd6GvFCC8VuW3v7kl7PzfJ4bpT7fBT8ZKlSjXR40+rbYCfBI1ryD73a8VfB59B 2B8A== X-Gm-Message-State: AOAM532aDk2mSssB6+qyUd5gq+c8LyRfSLnaEaj7I20f3qyMHixmw5Na bepIIEgbju1yEkWRaVGL7v3k7Pz1OD9TuipV8XqDyQ== X-Google-Smtp-Source: ABdhPJyivaUoVOHT/b59A0UT7hjGtf3I5Gw7XQw0zN+7mKUdmfdZvWXnEWoEcRnJ8KO3EMcS0vOSEk4+NNJqOGmhDGk= X-Received: by 2002:a17:906:d8ca:: with SMTP id re10mr1468224ejb.18.1612865743771; Tue, 09 Feb 2021 02:15:43 -0800 (PST) MIME-Version: 1.0 References: <20210104065503.199631-1-jasowang@redhat.com> <20210104065503.199631-17-jasowang@redhat.com> In-Reply-To: <20210104065503.199631-17-jasowang@redhat.com> From: Naresh Kamboju Date: Tue, 9 Feb 2021 15:45:32 +0530 Message-ID: Subject: Re: [PATCH V3 16/19] virtio-pci: introduce modern device module To: Jason Wang Cc: "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org, open list , shahafs@mellanox.com, lulu@redhat.com, sgarzare@redhat.com, Randy Dunlap , lkft-triage@lists.linaro.org, Linux-Next Mailing List , linux-arm-msm , Linux ARM , Arnd Bergmann , Catalin Marinas , Will Deacon , Stephen Rothwell Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Jason, On Mon, 4 Jan 2021 at 12:28, Jason Wang wrote: > > Signed-off-by: Jason Wang > --- > drivers/virtio/Kconfig | 10 +- > drivers/virtio/Makefile | 1 + > drivers/virtio/virtio_pci_common.h | 27 +- > drivers/virtio/virtio_pci_modern.c | 617 ------------------------- > drivers/virtio/virtio_pci_modern_dev.c | 599 ++++++++++++++++++++++++ > include/linux/virtio_pci_modern.h | 111 +++++ > 6 files changed, 721 insertions(+), 644 deletions(-) > create mode 100644 drivers/virtio/virtio_pci_modern_dev.c > create mode 100644 include/linux/virtio_pci_modern.h > > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > index 7b41130d3f35..6b9b81f4b8c2 100644 > --- a/drivers/virtio/Kconfig > +++ b/drivers/virtio/Kconfig > @@ -12,6 +12,14 @@ config ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS > This option is selected if the architecture may need to enforce > VIRTIO_F_ACCESS_PLATFORM > > +config VIRTIO_PCI_MODERN > + tristate "Modern Virtio PCI Device" > + depends on PCI > + help > + Modern PCI device implementation. This module implements the > + basic probe and control for devices which are based on modern > + PCI device with possible vendor specific extensions. > + > menuconfig VIRTIO_MENU > bool "Virtio drivers" > default y > @@ -20,7 +28,7 @@ if VIRTIO_MENU > > config VIRTIO_PCI > tristate "PCI driver for virtio devices" > - depends on PCI > + depends on VIRTIO_PCI_MODERN While booting Linux next tag 20210208 kernel on qemu_arm64 and qemu_arm mount rootfs failed. The root cause seems to be due to missing configs CONFIG_VIRTIO_PCI=y CONFIG_VIRTIO_PCI_LEGACY=y Reported-by: Naresh Kamboju Then I have to force to enable this MODERN config CONFIG_VIRTIO_PCI_MODERN=y and which enabled CONFIG_VIRTIO_PCI=y CONFIG_VIRTIO_PCI_LEGACY=y and the qemu_arm64 and qemu_arm boot pass. New build link, https://builds.tuxbuild.com/1oEse4EFsoQr1FkKBfiLmhMCe7j/ -- Linaro LKFT https://lkft.linaro.org