From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12EBC433FE for ; Thu, 7 Oct 2021 22:29:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D57261152 for ; Thu, 7 Oct 2021 22:29:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234621AbhJGWbN (ORCPT ); Thu, 7 Oct 2021 18:31:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234140AbhJGWbM (ORCPT ); Thu, 7 Oct 2021 18:31:12 -0400 Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C399C061760 for ; Thu, 7 Oct 2021 15:29:18 -0700 (PDT) Received: by mail-yb1-xb2e.google.com with SMTP id u32so16744089ybd.9 for ; Thu, 07 Oct 2021 15:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vfTVFiINmIY6UFMHbXcxPSbLfMBK2gvbq9x+fWTLigY=; b=fm8fNapj6cv7jEuvRUnTgxhkE/7LPu1Xhi5MQFHABrW45dz/chNi2zpSw+Mrupyp0F KeQ5yHXEkPxpzUdhd0ZlBL0F5rYVkSUXYjFs7fMSumZX/3ZUJMAj/gjJNSiPjfy/03E/ 5Qq4ZJ3ZP8vhVvHOslqM84evlajprp7bKAFvg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vfTVFiINmIY6UFMHbXcxPSbLfMBK2gvbq9x+fWTLigY=; b=wvuwgxZLUX8O/py2UnsK7AsCYPaqI5B/GoGwRStEsusqNz8eTkqi9EaSSFXRzhyPZF dnQW5O2A3h6gCZvwxRdq28zYiUV8EX16/2dNmUvmJyyXnqjscUnC220NeMqXaCafFxKr 2Co6EwSIybpIWiFX9/ZZ/cMF+3rq2UL8Z/OfdSf1ckEaQEJU23kxRad2gvx6DK4CfC0W 1v2ncD22yAT4/AXBQeeMPB52aA5rNkc01xDRy1pq9UXy6V5ZJ8g38koGF7hbLUQ9OLlq 5TYgG1bVT1jzw0v71R+t5BChRfOsO42/UpQvvhKGN5tfku9HlUejJaNSXthBP3Lg4hE0 zFPQ== X-Gm-Message-State: AOAM530IemIL0KjdK8X3tC+sX4xpRhf32zaAfEZoRNJnnftd0e62IqGf 0Ie/zVDzF8zKMM0cLK4OkPnUDwegLcD5llcYS5r4YQ== X-Google-Smtp-Source: ABdhPJxcAJ4KyzDkJW4oIS4zvj5BhTUN+q0gQP7cUPWu/LFMm+spExO4FNIlXXgO6PkpUlbbDS/bo6dPaBOOd3/+4Rk= X-Received: by 2002:a25:54c5:: with SMTP id i188mr7898822ybb.43.1633645757774; Thu, 07 Oct 2021 15:29:17 -0700 (PDT) MIME-Version: 1.0 References: <20210929173343.v2.1.Ib7e63ae17e827ce0636a09d5dec9796043e4f80a@changeid> In-Reply-To: From: Philip Chen Date: Thu, 7 Oct 2021 15:29:07 -0700 Message-ID: Subject: Re: [PATCH v2 1/3] arm64: dts: sc7180: Factor out ti-sn65dsi86 support To: Doug Anderson Cc: LKML , Stephen Boyd , Andy Gross , Bjorn Andersson , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi On Thu, Sep 30, 2021 at 9:22 AM Doug Anderson wrote: > > Hi, > > On Wed, Sep 29, 2021 at 5:35 PM Philip Chen wrote: > > > > Factor out ti-sn65dsi86 edp bridge as a separate dts fragment. > > This helps us introduce the second source edp bridge later. > > > > Reviewed-by: Stephen Boyd > > Signed-off-by: Philip Chen > > --- > > > > Changes in v2: > > - Move edp_brij_i2c completely out of sc7180-trogdor.dtsi to the > > bridge dts fragment, so that we can cleanly assign different > > edp bridge in every board rev. > > > > .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 1 + > > .../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 1 + > > .../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 1 + > > .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 1 + > > .../dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi | 90 +++++++++++++++++++ > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 86 ------------------ > > 6 files changed, 94 insertions(+), 86 deletions(-) > > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > > index a758e4d22612..1d13fba3bd2f 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > > @@ -11,6 +11,7 @@ > > ap_h1_spi: &spi0 {}; > > > > #include "sc7180-trogdor.dtsi" > > +#include "sc7180-trogdor-ti-sn65dsi86.dtsi" > > It looks like you're missing homestar, aren't you? I'd expect that > after applying your change that: > > git grep -A1 include.*sc7180-trogdor.dtsi > > ...should show your new include right after all includes of > sc7180-trogdor.dtsi, but I don't see it for homestar. I can't find homestar dts file in my upstream checkout. But I found: https://patchwork.kernel.org/project/linux-arm-msm/patch/20210909122053.1.Ieafda79b74f74a2b15ed86e181c06a3060706ec5@changeid/ ...Is it merged anywhere? > > Other than that this looks good to me. Feel free to add my Reviewed-by.