From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF668C433F5 for ; Fri, 1 Oct 2021 00:13:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D201C61267 for ; Fri, 1 Oct 2021 00:13:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351070AbhJAAOz (ORCPT ); Thu, 30 Sep 2021 20:14:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345765AbhJAAOw (ORCPT ); Thu, 30 Sep 2021 20:14:52 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61437C06176A for ; Thu, 30 Sep 2021 17:13:09 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id f130so7595954qke.6 for ; Thu, 30 Sep 2021 17:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FNKKr9E1dVe3sE87atOo7bDCMgvAC5uMdOIVxSHldZI=; b=FMk2682Q3LfDJL6qfYd3sqNp4kR7efCRowAdIiyYpGqErUuRyLaLscC7UYBE/vKX50 M0PlTaAuYt6pO7UsspmZMPRLkwJr0dVivYVpQUv02Gr1ByHo8eFKLrkv9tHEvzkLSGnA AmHO7uS8LMgJZScOwO+vfjZ9fNIeZVHIlq8gzBy1etaFXdLU08YhFNkKrEpQYaFvR5QP ty2Ms6R95h9JjFD+4KzDmtxTF1jrOVp2nYpl/NfEANs4Wp4EES+aieKHflJ/ejqpJKf7 odr138CBqrY9sBShYQMHtyyfMWk6jjauhA3m7KvLI11Hjo/EjG8TSd11Q/bY40dV+2ty f1Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FNKKr9E1dVe3sE87atOo7bDCMgvAC5uMdOIVxSHldZI=; b=JS3Eeth6cF6MDtp9PGaIh5T40SW1OKAbZYQPUT/qtIiNE4sEVITX8VUNgDg262ZAk8 qdzE5ZmBQfg6CZ7SMe1kGSVchNnT93CBrwSK0Rc/0VDbxfOkvjLaIIumoCEeirCl1Y0Z xfdeyo/YfPSco5mIbY0xVsgiOnuEB9i5H1XVnHXFhx8zcySNySGPWrRCcceYOAikySDl GhTd2RpkL2ukya14S+STii1zTnnF+eQ8K2G3lXPgTMnpRAq0WYTZsYRJD5kkk+TcoS6t JHb0ePDsXi1nz1zQF7bQpqfudFx1yEqPzcHEBvLXR+4RC/kfDVq7lPiTedPjybYcVdqy SSIQ== X-Gm-Message-State: AOAM532ljH2b+eaGXTmZ0sgnMzGCVCFxq1/Up9HVt5yMRL668lNBLRnf qjGyou/cN9p24XEwMovZHYHRxJ6x1dSlyS0NtylFRB4DWxcSZgRX X-Google-Smtp-Source: ABdhPJyNJfE7qMcISH4vQzi7Tu3ieEnqSZjsmlTjdanho9MUGhLMsonD73lCjAiQ9X9zJijPNz6q25+X2M9dXr2rZTg= X-Received: by 2002:a37:a391:: with SMTP id m139mr7319292qke.186.1633047186236; Thu, 30 Sep 2021 17:13:06 -0700 (PDT) MIME-Version: 1.0 References: <20210930215300.60290-1-bjorn.andersson@linaro.org> In-Reply-To: <20210930215300.60290-1-bjorn.andersson@linaro.org> From: Dmitry Baryshkov Date: Fri, 1 Oct 2021 03:12:55 +0300 Message-ID: Subject: Re: [PATCH] arm64: defconfig: Disable firmware sysfs fallback To: Bjorn Andersson Cc: Catalin Marinas , Will Deacon , Shawn Guo , Geert Uytterhoeven , Vinod Koul , Arnd Bergmann , Linux ARM , open list , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Robin Gong Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 1 Oct 2021 at 00:51, Bjorn Andersson wrote: > > Part of the enablement of SDMA on the IMX platforms, '7f4e4afa140c > ("arm64: defconfig: Enable SDMA on i.mx8mq/8mm")' also enabled > CONFIG_FW_LOADER_USER_HELPER_FALLBACK, to allow "firmware loaded by > udev". > > Unfortunately having the fallback enabled does, due to the 60 second > timeout, essentially requiring userspace to provide a firmware loader. > But systemd dropped the support for this interface back in 2014 and > because arm64 is the only architecture that has this enabled, there > doesn't seem to be any standard solution available. I tend to use the following 'standard' solution: cat /lib/udev/rules.d/50-firmware.rules # stub for immediately telling the kernel that userspace firmware loading # failed; necessary to avoid long timeouts with CONFIG_FW_LOADER_USER_HELPER=y SUBSYSTEM=="firmware", ACTION=="add", ATTR{loading}="-1" > Examples of this problem can be found in e.g. the ath10k driver, which > with a standard distro can take about 10 minutes before wlan0 appears. > > The alternative to this patch would be to change these drivers to use > firmware_request_direct(), to avoid the sysfs fallback. But that would > prevent other systems, such as Android, to rely on a userspace firmware > loader to pick the firmware from a non-standard place, with just a > custom defconfig. > > This patch therefor attempts to align the arm64 defconfig will all other > architectures in the upstream kernel. > > Cc: Robin Gong > Cc: Shawn Guo > Signed-off-by: Bjorn Andersson Reviewed-by: Dmitry Baryshkov > --- > arch/arm64/configs/defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index da988a54bfb9..f9e0b3fdaf0b 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -243,7 +243,6 @@ CONFIG_PCI_EPF_TEST=m > CONFIG_DEVTMPFS=y > CONFIG_DEVTMPFS_MOUNT=y > CONFIG_FW_LOADER_USER_HELPER=y > -CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y > CONFIG_HISILICON_LPC=y > CONFIG_SIMPLE_PM_BUS=y > CONFIG_FSL_MC_BUS=y > -- > 2.29.2 > -- With best wishes Dmitry