From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12016C433F5 for ; Mon, 4 Oct 2021 12:37:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E645160F35 for ; Mon, 4 Oct 2021 12:37:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233108AbhJDMjL (ORCPT ); Mon, 4 Oct 2021 08:39:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233081AbhJDMjL (ORCPT ); Mon, 4 Oct 2021 08:39:11 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B62CC061746 for ; Mon, 4 Oct 2021 05:37:22 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id t2so15641069qtx.8 for ; Mon, 04 Oct 2021 05:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jGP8TVCyTNKC8lYp46gRsaBQwXm6B5JGGuNtiC4p2to=; b=xg7b0UuDwntcgtEAt/AHqlb+K0LE+HZmn1Oqe4wj9ZTl8ACrCiVaPxulOPo7qzXjdH nctGwYnj9vWCI0hSXGYlRTI2GBcOla4sXRzmQUrYYb83H+Kr9FEmWL25y+y/LpgouP+f 4rgbquxjLzD84AEaX1HQOsVh4t0JsK/OEae805W4QrbMfzNN9s+WepJf8ouualMpJ94t Q1yY6y81WM5PhMn/gTBbVfYvddoAkDKrdQzuflsINtSuQEfAqZtyKQRuGIIGrqI2jYGq YLtMXXawXGIuJjicJmhByzqJB7ZDpXguKFQ42ASwc2AWuPq3lHn/p9p6hDtxb8wk/Upb OxnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jGP8TVCyTNKC8lYp46gRsaBQwXm6B5JGGuNtiC4p2to=; b=IOe9RK34itcG/j/da+z5caSx+VGOSgmdvC6bS7kPuyS+AEGsgn7e5y0/CEDQBK7GnR V1zB/r/O4G146eFlOHy8Tn9Yk612EmNmvL8ALuZXr7xmR60bJody3RyxPw9OlOY8omv9 Z2UY968j81ks3MyP6vKCKhglRjx5p2B0JJKJfMVsPd82xinDy6Gtb2UTxWYk61vyU2x9 cl5zpUuBdqkUlpfWxq8lRijBdyOMG09t6TWVgXoNyB91+c/0AKdKc9Mo3J+Knn2LYpOa zokwM8jFRVLIUZRSX5RHOBBZx8fit5tyE30bpvqkuN2NgH+i/JMag9ydLINrycwbhfmb 8YJw== X-Gm-Message-State: AOAM533+fg4EuOmgtvPbwC7uE58BdzBoAKCaavXJ0FoGIRZGUXSv5VpK GperJhY/LUWaKMeKAsdJZ2KIYil5HQatYB/3zaBg25Xtr/c= X-Google-Smtp-Source: ABdhPJyZdhtbVrhLrPMBAYTp9LsJkvO2y3XEFNx9DpQIGB9Wr40AxahoMxXtorTA5kV8paCC1Yd9yueJDIKEbs3eXOk= X-Received: by 2002:ac8:6690:: with SMTP id d16mr12938010qtp.285.1633351041516; Mon, 04 Oct 2021 05:37:21 -0700 (PDT) MIME-Version: 1.0 References: <20210903232421.1384199-1-dmitry.baryshkov@linaro.org> <36128ee3-0dad-dbdb-ca66-0d0e45aa0b9d@linaro.org> <2fe2f8bd-c487-e859-54e1-28e6cb0fdece@kernel.org> In-Reply-To: <2fe2f8bd-c487-e859-54e1-28e6cb0fdece@kernel.org> From: Dmitry Baryshkov Date: Mon, 4 Oct 2021 15:37:10 +0300 Message-ID: Subject: Re: [PATCH v2 0/11] interconnect: merge AP-owned support into icc-rpm To: Georgi Djakov Cc: Andy Gross , Bjorn Andersson , AngeloGioacchino Del Regno , Shawn Guo , Yassine Oudjana , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Linux PM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, 4 Oct 2021 at 14:56, Georgi Djakov wrote: > > On 25.09.21 22:40, Dmitry Baryshkov wrote: > > On 04/09/2021 02:24, Dmitry Baryshkov wrote: > >> This patch series merges support for AP-owned and bus QoS from SDM660 > >> into common code (icc-rpm.c). MSM8916 and MSM8939 support code is > >> extended to support these features. As I was touching these drivers, per > >> Bjorn's suggestion expand DEFINE_QNODE macros (which makes adding > >> QoS support much easier to review). > >> > >> Dependencies: > >> - > >> https://lore.kernel.org/linux-arm-msm/20210902054915.28689-1-shawn.guo@linaro.org/ > >> > >> - > >> https://lore.kernel.org/linux-arm-msm/20210823014003.31391-1-shawn.guo@linaro.org/ > >> > >> - > >> https://lore.kernel.org/linux-arm-msm/20210824043435.23190-1-shawn.guo@linaro.org/ > >> > >> > >> Changes since v1: > >> - Rebase on top a2noc clocks support patch. > >> - Expand DEFINE_QNODE > >> - Simplify struct qcom_icc_node by moving links to separate array > > > > Georgi, since all dependencies were pulled in by you, I wanted to > > remind/ask: do you intend to pull this patchset for 5.16? > > Hi Dmitry, > Yes, that's the plan. I just responded with a few minor comments/fixes > to some of the patches. I can just fix them before applying, if you are > fine with these. Yes, I'm fine with your fixes. Please use them and apply the patchset. Thank you! > > Thanks again to all the people involved with this patchset! > > Thanks, > Georgi > > > > >> > >> ---------------------------------------------------------------- > >> Dmitry Baryshkov (11): > >> interconnect: icc-rpm: move bus clocks handling into qnoc_probe > >> interconnect: sdm660: expand DEFINE_QNODE macros > >> interconnect: sdm660: drop default/unused values > >> interconnect: sdm660: merge common code into icc-rpm > >> interconnect: icc-rpm: add support for QoS reg offset > >> interconnect: msm8916: expand DEFINE_QNODE macros > >> interconnect: msm8916: add support for AP-owned nodes > >> interconnect: msm8939: expand DEFINE_QNODE macros > >> interconnect: msm8939: add support for AP-owned nodes > >> interconnect: qcs404: expand DEFINE_QNODE macros > >> interconnect: qcom: drop DEFINE_QNODE macro > >> > >> drivers/interconnect/qcom/icc-rpm.c | 263 ++++- > >> drivers/interconnect/qcom/icc-rpm.h | 56 +- > >> drivers/interconnect/qcom/msm8916.c | 1214 ++++++++++++++++++++-- > >> drivers/interconnect/qcom/msm8939.c | 1283 +++++++++++++++++++++-- > >> drivers/interconnect/qcom/qcs404.c | 967 +++++++++++++++-- > >> drivers/interconnect/qcom/sdm660.c | 1940 > >> ++++++++++++++++++++++++----------- > >> 6 files changed, 4815 insertions(+), 908 deletions(-) > >> > >> > > > > > -- With best wishes Dmitry