From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: John Stultz <john.stultz@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vinod.koul@linaro.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>,
YongQin Liu <yongqin.liu@linaro.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: Regression: arm64: dts: sdm845-db845c: make firmware filenames follow linux-firmware
Date: Wed, 5 May 2021 21:43:34 +0300 [thread overview]
Message-ID: <CAA8EJppTgQSFvNcA4vEf1rSDeH0ec7nj3YHDA4DUgiJ5OPciOg@mail.gmail.com> (raw)
In-Reply-To: <CALAqxLXsLcA=r1x6hXxLx3aVA-8=RG5qd+yj+sKEFiaWPUzkSA@mail.gmail.com>
Hi
On Wed, 5 May 2021 at 09:20, John Stultz <john.stultz@linaro.org> wrote:
>
> Hey Dmitry, Bjorn,
> I wanted to raise a regression I caught in the merge window on db845c.
>
> I was seeing troubles with audio and while there are a few other
> pending fixes needed, they did not seem to work for me. So I spent
> some time bisecting things down and found the problematic commit was
> 7443ff06da45 ("arm64: dts: sdm845-db845c: make firmware filenames
> follow linux-firmware").
>
> It seems for systems using the old firmware filenames, this will break
> dependent devices on adsp_pas and cdsp_pas nodes.
>
> Now, obviously updating the firmware files in userland should resolve
> this, but it adds the complexity that we can't just replace the
> firmware files because older LTS kernels will look for the old names,
> while newer kernels will look for the new names. We can add both files
> to the system images, but then there is some confusion on which
> version of the firmware files are being used where.
>
> So yes, we should align with linux-firmware file names, but I think
> more care is needed for this sort of thing as it has the potential to
> break folks, and this isn't the first time around we've had similar
> firmware name changes break us.
>
> So I'm working on fixing this by including both filenames in userland,
> so we probably don't need a revert here, but *please* maybe take more
> care on this sort of change.
Point taken.
--
With best wishes
Dmitry
next prev parent reply other threads:[~2021-05-05 18:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 6:20 John Stultz
2021-05-05 15:08 ` Rob Clark
2021-05-05 19:35 ` John Stultz
2021-05-05 20:05 ` Rob Clark
2021-05-05 20:07 ` Dmitry Baryshkov
2021-05-05 21:14 ` John Stultz
2021-05-05 21:02 ` Bjorn Andersson
2021-05-05 18:43 ` Dmitry Baryshkov [this message]
2021-05-05 19:06 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8EJppTgQSFvNcA4vEf1rSDeH0ec7nj3YHDA4DUgiJ5OPciOg@mail.gmail.com \
--to=dmitry.baryshkov@linaro.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vinod.koul@linaro.org \
--cc=yongqin.liu@linaro.org \
--subject='Re: Regression: arm64: dts: sdm845-db845c: make firmware filenames follow linux-firmware' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).