From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E2A7D53E for ; Tue, 27 Feb 2024 02:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708999932; cv=none; b=dQOqDsO8OktAC1pybcwpnQUXHy16AGzWZDAYg8nbdeiWRtcF5E6tdyMvH7WNmOf1Xrd3UZivZSB4JLHbY47rrhcwKzutC+lejsx/bv4UYN9B5N8Yf6rRRGV5FImvEmXGlsjrWdEMPN/occHuX78jiR9udncHp/wyJ5YRyFOTlY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708999932; c=relaxed/simple; bh=Z56/LI8VZmdz98CuUjLKRxqM+/e9GrRj/1Z7Ht5aUfw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Km395JUpsgX2ZQHzLo+eTI06Lnf5bFgMId9AlxBIpOEyNJ6Sf9tAqwzTocrI/pZ8SW4rvaDzYt1Ahu3G32a3X/rSdOvepp48zKEjMzjjvmjw9D3nopLM3GcTG/ZWfcCgSQMM9m1YmSn5EUKY+bM6ms+vLUI9sjdDxDgwSjm13lc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lAwWueSj; arc=none smtp.client-ip=209.85.219.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lAwWueSj" Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-dcc80d6004bso3709149276.0 for ; Mon, 26 Feb 2024 18:12:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708999930; x=1709604730; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tkk2Ni6/yhyMeaZGa7IIqv+Yfz58c68ZVLrD2RbHJZ4=; b=lAwWueSjV4zfBBmTtNJxigVRZQ+zhyUyZvljhuzxtHCNg/vfHzo2m6gKWLG0THEA8W Kh8Sl5OVoPOcHbiae2DMkkmWL/G7efTrOJkH0yg2YO8bCItELs4e4WG6CPcqmBODBUGp 7wX3V0t+jkyYsCcpO6qxCShm4Dz+SjzArJ46rsWDCuEiPpYbjpnbwgryfNMiju9DNuFx J6Vvucq1r7nlOvR4jATY+3gzXQXPNG8c709UBhkyFHlo1o7HWX+/TLwBx61z9Mjhoxjw pa7muU7hrNQEpckhdeYvy3XNB5t63nusm4WVctz2egTxZDEcHb/5UPIKF2MjGejB0qnk F3YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708999930; x=1709604730; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tkk2Ni6/yhyMeaZGa7IIqv+Yfz58c68ZVLrD2RbHJZ4=; b=YK4KHkvP5P+/kEPSLWziFKqOFU0UhsjzC3k3XuGlhF4gw+UmWz2gNbXmerkT4KtBf7 MY+Xn/n8RwcIq6nNX5ZRzYF6+Pv9rkPsVj2UUo+hM2hUBKdFQhLQQIYqJSjsAbsMI884 fjIeZ5cfnsIUexCYcKAel48b0ecMzPaO2Fl1qY4wcnvXO4NGfKudX2hPapVNx9fyjLAS uA+3X5jcEfBxlL+jwIzqf6QBsW+YNFuBMu3vU3J0+75gwWbTPw8zDsA3cjiRRcS1BtrL 0aQd2CbaPjru4FSQqtDmp4lPDhOhI7Q+KjYKFzpGkIpNxnbfxJgBzoXuXmB9ajs7XTiA mdQg== X-Forwarded-Encrypted: i=1; AJvYcCUbowNb30KAxOZ69FuwLh8ZCVd3M+2MdRQvnQ3hgShuiST606UQrxzb6qdp5WSudACCw/c1jd4fk3qUoOv6XbphjPjjSvF09oh8FGVWGA== X-Gm-Message-State: AOJu0Yy8mP9CDqbRc73zXG9+dGWKN2ufxSkw6V8Lct59XXEOp2Cp570S NBTIquOvFWJAkf8rjBjwlB4BB1zdQTg0v7aFwlonrGaKnIgxHmLtvpcVazacgcR5qUSe2yqXwjl axsSrFlkW8mrUc7NBsuiOmuiYPOpbDyWRnktKlQ== X-Google-Smtp-Source: AGHT+IFxwZo4jdNC6Y1qg8jo3OFzprpy0HeWCrowjlAGstZGCPHgOw7rD/34/+prPDnHsvSDlgsCDFtxPaz0GjLwWbM= X-Received: by 2002:a25:9a05:0:b0:dcd:5635:5c11 with SMTP id x5-20020a259a05000000b00dcd56355c11mr940809ybn.45.1708999930374; Mon, 26 Feb 2024 18:12:10 -0800 (PST) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240226-rpmhpd-enable-corner-fix-v1-1-68c004cec48c@quicinc.com> In-Reply-To: <20240226-rpmhpd-enable-corner-fix-v1-1-68c004cec48c@quicinc.com> From: Dmitry Baryshkov Date: Tue, 27 Feb 2024 04:11:59 +0200 Message-ID: Subject: Re: [PATCH] pmdomain: qcom: rpmhpd: Fix enabled_corner aggregation To: quic_bjorande@quicinc.com Cc: Bjorn Andersson , Konrad Dybcio , Ulf Hansson , Stephen Boyd , Johan Hovold , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Tue, 27 Feb 2024 at 03:45, Bjorn Andersson via B4 Relay wrote: > > From: Bjorn Andersson > > Commit 'e3e56c050ab6 ("soc: qcom: rpmhpd: Make power_on actually enable > the domain")' aimed to make sure that a power-domain that is being > enabled without any particular performance-state requested will at least > turn the rail on, to avoid filling DeviceTree with otherwise unnecessary > required-opps properties. > > But in the event that aggregation happens on a disabled power-domain, with > an enabled peer without performance-state, both the local and peer > corner are 0. The peer's enabled_corner is not considered, with the > result that the underlying (shared) resource is disabled. > > One case where this can be observed is when the display stack keeps mmcx > enabled (but without a particular performance-state vote) in order to > access registers and sync_state happens in the rpmhpd driver. As mmcx_ao > is flushed the state of the peer (mmcx) is not considered and mmcx_ao > ends up turning off "mmcx.lvl" underneath mmcx. This has been observed > several times, but has been painted over in DeviceTree by adding an > explicit vote for the lowest non-disabled performance-state. > > Fixes: e3e56c050ab6 ("soc: qcom: rpmhpd: Make power_on actually enable the domain") > Reported-by: Johan Hovold > Closes: https://lore.kernel.org/linux-arm-msm/ZdMwZa98L23mu3u6@hovoldconsulting.com/ > Cc: > Signed-off-by: Bjorn Andersson > --- > This issue is the root cause of a display regression on SC8280XP boards, > resulting in the system often resetting during boot. It was exposed by > the refactoring of the DisplayPort driver in v6.8-rc1. > --- > drivers/pmdomain/qcom/rpmhpd.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Dmitry Baryshkov Tested-by: Dmitry Baryshkov Probably once this lands we can drop explicit required-opps properties. -- With best wishes Dmitry